mirror of
https://github.com/awizemann/scarf.git
synced 2026-05-10 18:44:45 +00:00
Compare commits
16 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| a8cdb3e663 | |||
| 441d11404f | |||
| 6e8480411a | |||
| 3a764e81e0 | |||
| 6e90741a17 | |||
| 93a3b40a67 | |||
| 52f0ddb36c | |||
| cedee04f2a | |||
| b4482e5ee7 | |||
| 4757b5ae49 | |||
| 0070441243 | |||
| 57a6340985 | |||
| 6c96fcfa43 | |||
| edac142d08 | |||
| fd33b714e3 | |||
| c81a8a56e8 |
@@ -173,6 +173,10 @@ v0.10.0 introduced the **Tool Gateway** — paid Nous Portal subscribers route w
|
||||
|
||||
**Keep `ModelCatalogService.overlayOnlyProviders` in sync** with `HERMES_OVERLAYS` in `~/.hermes/hermes-agent/hermes_cli/providers.py`. When Hermes adds a new overlay-only provider, mirror the entry (display name, base URL, auth type, subscription-gated flag, doc URL) or the picker won't reach it.
|
||||
|
||||
**Keep `ModelCatalogService.modelAliases` in sync** with Hermes's deprecated-model-ID map (currently release-notes-only upstream; the canonical successor lives in `hermes_cli/providers.py` if/when upstream tracks it in code). Drift here means a user's old model ID stops resolving in the picker even though Hermes still accepts it at runtime.
|
||||
|
||||
**Keep `ModelCatalogService.demotedProviders` in sync** with the deprioritized-provider list in `hermes-agent/hermes_cli/providers.py`. Drift means Vercel AI Gateway (or any future demoted provider) sorts in the wrong position in Scarf's picker.
|
||||
|
||||
## Kanban v3: drag-and-drop board + per-project tenants (v2.7.5)
|
||||
|
||||
Scarf v2.7.5 promotes Kanban from a read-only list to a full board with drag-and-drop, every Hermes write verb wired up, and per-project boards bound to a Scarf-minted tenant slug. The list view is preserved as a `Board | List` toggle for accessibility / narrow-window fallback.
|
||||
|
||||
@@ -0,0 +1,34 @@
|
||||
import Foundation
|
||||
|
||||
/// Errors thrown by `CuratorService`. Each case carries enough detail
|
||||
/// to render a user-actionable message — the view model surfaces these
|
||||
/// inline as a banner above the leaderboard rather than blocking with a
|
||||
/// modal alert.
|
||||
public enum CuratorError: Error, LocalizedError, Sendable {
|
||||
/// `hermes` binary couldn't be located.
|
||||
case cliMissing
|
||||
/// Subprocess returned non-zero exit. `stderr` may carry a synthetic
|
||||
/// message when the transport itself failed.
|
||||
case nonZeroExit(verb: String, code: Int32, stderr: String)
|
||||
/// JSON decoding failed. Underlying message wrapped for diagnostics.
|
||||
case decoding(verb: String, message: String)
|
||||
/// Generic transport error — process couldn't start, IO failed, etc.
|
||||
case transport(message: String)
|
||||
|
||||
public var errorDescription: String? {
|
||||
switch self {
|
||||
case .cliMissing:
|
||||
return "Hermes CLI couldn't be found. Install Hermes v0.13+ and ensure it's on your PATH."
|
||||
case .nonZeroExit(let verb, let code, let stderr):
|
||||
let trimmed = stderr.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if trimmed.isEmpty {
|
||||
return "`hermes curator \(verb)` exited with code \(code)."
|
||||
}
|
||||
return trimmed
|
||||
case .decoding(let verb, let message):
|
||||
return "Couldn't decode `hermes curator \(verb)` output: \(message)"
|
||||
case .transport(let message):
|
||||
return message
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,76 @@
|
||||
import Foundation
|
||||
|
||||
/// Hermes v0.13 added cross-platform recipient allowlists to the Messaging
|
||||
/// Gateway. Each platform stores the list under a different YAML key
|
||||
/// depending on the platform's primary noun for "addressable destination":
|
||||
///
|
||||
/// - **`allowed_channels`** — Slack, Mattermost, Google Chat
|
||||
/// - **`allowed_chats`** — Telegram, WhatsApp
|
||||
/// - **`allowed_rooms`** — Matrix, DingTalk
|
||||
///
|
||||
/// `GatewayAllowlistKind` encodes the (platform → key) mapping plus a few
|
||||
/// presentation hints (placeholder strings, singular noun) so the allowlist
|
||||
/// editor can render the right copy without the per-platform setup view
|
||||
/// needing to know the YAML shape.
|
||||
public enum GatewayAllowlistKind: String, Sendable, Equatable {
|
||||
case channels // -> allowed_channels
|
||||
case chats // -> allowed_chats
|
||||
case rooms // -> allowed_rooms
|
||||
|
||||
/// YAML scalar key segment under `gateway.platforms.<platform>.<key>`.
|
||||
public var yamlKey: String {
|
||||
switch self {
|
||||
case .channels: return "allowed_channels"
|
||||
case .chats: return "allowed_chats"
|
||||
case .rooms: return "allowed_rooms"
|
||||
}
|
||||
}
|
||||
|
||||
/// Placeholder copy for the editor's "add row" text field. Picks the
|
||||
/// most common identifier shape per platform family — Slack channel IDs
|
||||
/// for `channels`, Telegram username/numeric for `chats`, Matrix room
|
||||
/// IDs for `rooms`. Users can paste in any platform-specific format the
|
||||
/// gateway accepts; this is a hint, not validation.
|
||||
public var inputPlaceholder: String {
|
||||
switch self {
|
||||
case .channels: return "C0123ABCD or #channel-name"
|
||||
case .chats: return "@username or 12345678"
|
||||
case .rooms: return "!RoomId:matrix.org"
|
||||
}
|
||||
}
|
||||
|
||||
/// Singular noun for prose surfaces ("Add a channel", "1 chat allowed",
|
||||
/// "0 rooms"). Capitalization is the caller's responsibility.
|
||||
public var noun: String {
|
||||
switch self {
|
||||
case .channels: return "channel"
|
||||
case .chats: return "chat"
|
||||
case .rooms: return "room"
|
||||
}
|
||||
}
|
||||
|
||||
/// Plural noun for headings + counts.
|
||||
public var pluralNoun: String {
|
||||
switch self {
|
||||
case .channels: return "channels"
|
||||
case .chats: return "chats"
|
||||
case .rooms: return "rooms"
|
||||
}
|
||||
}
|
||||
|
||||
/// Map a Hermes platform identifier to the allowlist kind it supports.
|
||||
/// Returns `nil` for platforms without v0.13 allowlist support
|
||||
/// (`cli`, `signal`, `email`, `imessage`, `homeassistant`, `webhook`,
|
||||
/// `yuanbao`, `microsoft-teams`, `feishu`, `discord`).
|
||||
///
|
||||
/// `googlechat` and `google-chat` both map to `.channels` so we round-trip
|
||||
/// regardless of which spelling Hermes lands on. // TODO(WS-5-Q1)
|
||||
public static func kind(for platform: String) -> GatewayAllowlistKind? {
|
||||
switch platform {
|
||||
case "slack", "mattermost", "google-chat", "googlechat": return .channels
|
||||
case "telegram", "whatsapp": return .chats
|
||||
case "matrix", "dingtalk": return .rooms
|
||||
default: return nil
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,71 @@
|
||||
import Foundation
|
||||
|
||||
/// Per-platform Messaging Gateway settings introduced in Hermes v0.13. Bundles
|
||||
/// the allowlist (the platform-appropriate flavor of `allowed_channels` /
|
||||
/// `allowed_chats` / `allowed_rooms`) and three behavior toggles
|
||||
/// (`busy_ack_enabled`, `gateway_restart_notification`,
|
||||
/// `slash_command_notice_ttl_seconds`).
|
||||
///
|
||||
/// The struct carries all three list fields so a single shape fits every
|
||||
/// platform; only the field matching `GatewayAllowlistKind.kind(for:)` is
|
||||
/// surfaced in the editor for a given platform. The other two stay empty
|
||||
/// and round-trip through the YAML parser unchanged.
|
||||
///
|
||||
/// **Defaults track Hermes v0.13.** `busyAckEnabled = true`,
|
||||
/// `gatewayRestartNotification = false`, `slashCommandNoticeTTLSeconds = 0`
|
||||
/// (disabled). An "all-default" instance therefore produces no `gateway:`
|
||||
/// block in YAML — see `HermesConfig+YAML` parsing logic which only inserts
|
||||
/// an entry into `gatewayPlatforms` when at least one v0.13 key is present
|
||||
/// in the file.
|
||||
public struct GatewayPlatformSettings: Sendable, Equatable {
|
||||
/// `gateway.platforms.<platform>.allowed_channels` — Slack, Mattermost,
|
||||
/// Google Chat. Empty when the platform doesn't use channels.
|
||||
public var allowedChannels: [String]
|
||||
/// `gateway.platforms.<platform>.allowed_chats` — Telegram, WhatsApp.
|
||||
/// Empty when the platform doesn't use chats.
|
||||
public var allowedChats: [String]
|
||||
/// `gateway.platforms.<platform>.allowed_rooms` — Matrix, DingTalk.
|
||||
/// Empty when the platform doesn't use rooms.
|
||||
public var allowedRooms: [String]
|
||||
/// `gateway.platforms.<platform>.busy_ack_enabled`. Default `true` — set
|
||||
/// to `false` to suppress per-message "agent is working…" acks.
|
||||
public var busyAckEnabled: Bool
|
||||
/// `gateway.platforms.<platform>.gateway_restart_notification`. Default
|
||||
/// `false` — set to `true` to post a "Gateway restarted" notice on boot.
|
||||
public var gatewayRestartNotification: Bool
|
||||
/// `gateway.platforms.<platform>.slash_command_notice_ttl_seconds`.
|
||||
/// Default `0` (disabled). Positive values auto-delete slash-command
|
||||
/// notices after N seconds.
|
||||
public var slashCommandNoticeTTLSeconds: Int
|
||||
|
||||
public init(
|
||||
allowedChannels: [String] = [],
|
||||
allowedChats: [String] = [],
|
||||
allowedRooms: [String] = [],
|
||||
busyAckEnabled: Bool = true,
|
||||
gatewayRestartNotification: Bool = false,
|
||||
slashCommandNoticeTTLSeconds: Int = 0
|
||||
) {
|
||||
self.allowedChannels = allowedChannels
|
||||
self.allowedChats = allowedChats
|
||||
self.allowedRooms = allowedRooms
|
||||
self.busyAckEnabled = busyAckEnabled
|
||||
self.gatewayRestartNotification = gatewayRestartNotification
|
||||
self.slashCommandNoticeTTLSeconds = slashCommandNoticeTTLSeconds
|
||||
}
|
||||
|
||||
/// All-default instance. `HermesConfig.empty` initializes
|
||||
/// `gatewayPlatforms: [:]` so this is rarely used directly; provided
|
||||
/// for symmetry with the other settings types.
|
||||
public static let empty = GatewayPlatformSettings()
|
||||
|
||||
/// The list field matching this allowlist kind, or `nil` for
|
||||
/// platforms without an allowlist surface.
|
||||
public func items(for kind: GatewayAllowlistKind) -> [String] {
|
||||
switch kind {
|
||||
case .channels: return allowedChannels
|
||||
case .chats: return allowedChats
|
||||
case .rooms: return allowedRooms
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,26 @@
|
||||
import Foundation
|
||||
|
||||
/// Optimistic local mirror of the agent's currently-locked goal (set via
|
||||
/// the `/goal <text>` slash command, Hermes v0.13+). Scarf records this
|
||||
/// the moment the user sends `/goal …` so the chat header pill appears
|
||||
/// synchronously, without waiting for a server round-trip. There is no
|
||||
/// authoritative read-back path in v2.8.0 — see WS-2 plan Q1.
|
||||
///
|
||||
/// Plain value type, no mutation API. Drives the goal pill in
|
||||
/// `SessionInfoBar` and the inspector contextual menu.
|
||||
public struct HermesActiveGoal: Sendable, Equatable, Identifiable {
|
||||
/// The user's verbatim goal text (post-trim).
|
||||
public let text: String
|
||||
/// When Scarf observed the `/goal` send. Local clock — not the
|
||||
/// server's authoritative timestamp.
|
||||
public let setAt: Date
|
||||
|
||||
public var id: String {
|
||||
text + "@" + ISO8601DateFormatter().string(from: setAt)
|
||||
}
|
||||
|
||||
public init(text: String, setAt: Date) {
|
||||
self.text = text
|
||||
self.setAt = setAt
|
||||
}
|
||||
}
|
||||
@@ -691,6 +691,48 @@ public struct HermesConfig: Sendable {
|
||||
/// final reply (provider/model/cost/turn count). Off by default;
|
||||
/// useful for cost auditing and screen-recording demos.
|
||||
public var runtimeMetadataFooter: Bool
|
||||
/// Pre-v0.13: single combined Web Tools backend at `web_tools.backend`.
|
||||
/// v0.13 split this into per-capability keys (see below). Kept readable
|
||||
/// for round-trip compatibility on hosts that never migrated; v0.13+
|
||||
/// hosts ignore this scalar and read the split keys instead.
|
||||
public var webToolsBackend: String
|
||||
/// v0.13+: `web_tools.search.backend`. SearXNG is search-only and
|
||||
/// can land here. Pre-v0.13 hosts default to the same value as the
|
||||
/// combined backend.
|
||||
public var webToolsSearchBackend: String
|
||||
/// v0.13+: `web_tools.extract.backend`. Pre-v0.13 hosts default to
|
||||
/// the same value as the combined backend.
|
||||
public var webToolsExtractBackend: String
|
||||
|
||||
// -- Hermes v0.13 additions ----------------------------------------
|
||||
// Per-platform Messaging Gateway settings dictionary keyed by Hermes
|
||||
// platform identifier (`slack`, `telegram`, `matrix`, `mattermost`,
|
||||
// `whatsapp`, `dingtalk`, `google-chat`). Populated only for platforms
|
||||
// whose `gateway.platforms.<platform>.*` block exists in config.yaml —
|
||||
// platforms without an explicit block don't appear in the dictionary.
|
||||
// Editing surfaces (per-platform setup forms) read with a `?? .empty`
|
||||
// fallback so a missing entry behaves identically to an all-default
|
||||
// entry.
|
||||
public var gatewayPlatforms: [String: GatewayPlatformSettings]
|
||||
|
||||
/// `image_gen.model` (v0.13+) — overrides the per-provider default
|
||||
/// image-gen model. Empty string means "let Hermes pick the
|
||||
/// provider default". Hermes v0.12 advertised this key but ignored
|
||||
/// it; Scarf's `AuxiliaryTab` only renders the picker when
|
||||
/// `HermesCapabilities.hasImageGenModel` is `true`.
|
||||
public var imageGenModel: String
|
||||
|
||||
/// `openrouter.response_cache.enabled` (v0.13+) — when true, Hermes
|
||||
/// asks OpenRouter to cache responses for repeat prompts within a
|
||||
/// session. Off by default in Scarf's parser per WS-6 plan
|
||||
/// recommendation. UI gated on
|
||||
/// `HermesCapabilities.hasOpenRouterResponseCache`.
|
||||
// TODO(WS-6-Q1): the exact YAML key shape is provisional. Verify
|
||||
// against a v0.13 host's `hermes config check` output before
|
||||
// shipping (see WS-6-plan §Open Questions #1). Candidate alternative
|
||||
// shapes: `providers.openrouter.response_cache_enabled` or
|
||||
// `prompt_caching.openrouter.enabled`.
|
||||
public var openrouterResponseCacheEnabled: Bool
|
||||
|
||||
// Grouped blocks
|
||||
public var display: DisplaySettings
|
||||
@@ -772,11 +814,23 @@ public struct HermesConfig: Sendable {
|
||||
homeAssistant: HomeAssistantSettings,
|
||||
cacheTTL: String = "5m",
|
||||
redactionEnabled: Bool = false,
|
||||
runtimeMetadataFooter: Bool = false
|
||||
runtimeMetadataFooter: Bool = false,
|
||||
gatewayPlatforms: [String: GatewayPlatformSettings] = [:],
|
||||
imageGenModel: String = "",
|
||||
openrouterResponseCacheEnabled: Bool = false,
|
||||
webToolsBackend: String = "duckduckgo",
|
||||
webToolsSearchBackend: String = "duckduckgo",
|
||||
webToolsExtractBackend: String = "reader"
|
||||
) {
|
||||
self.cacheTTL = cacheTTL
|
||||
self.redactionEnabled = redactionEnabled
|
||||
self.runtimeMetadataFooter = runtimeMetadataFooter
|
||||
self.gatewayPlatforms = gatewayPlatforms
|
||||
self.imageGenModel = imageGenModel
|
||||
self.openrouterResponseCacheEnabled = openrouterResponseCacheEnabled
|
||||
self.webToolsBackend = webToolsBackend
|
||||
self.webToolsSearchBackend = webToolsSearchBackend
|
||||
self.webToolsExtractBackend = webToolsExtractBackend
|
||||
self.model = model
|
||||
self.provider = provider
|
||||
self.maxTurns = maxTurns
|
||||
|
||||
@@ -28,6 +28,12 @@ public struct HermesCronJob: Identifiable, Sendable, Codable {
|
||||
/// job's prompt. YAML-only field today (no `--context-from` CLI
|
||||
/// flag yet) — Scarf displays it but doesn't write it.
|
||||
public nonisolated let contextFrom: [String]?
|
||||
/// Hermes v0.13+ — script-only watchdog mode. When `true` the
|
||||
/// pre-run script runs but the AI turn is skipped. `nil` means the
|
||||
/// jobs.json file is pre-v0.13 (treat as `false`); `false` is the
|
||||
/// explicit v0.13+ default. Capability-gated on `hasCronNoAgent`
|
||||
/// at all write call sites.
|
||||
public nonisolated let noAgent: Bool?
|
||||
|
||||
public enum CodingKeys: String, CodingKey {
|
||||
case id, name, prompt, skills, model, schedule, enabled, state, deliver, silent
|
||||
@@ -41,6 +47,7 @@ public struct HermesCronJob: Identifiable, Sendable, Codable {
|
||||
case timeoutSeconds = "timeout_seconds"
|
||||
case workdir
|
||||
case contextFrom = "context_from"
|
||||
case noAgent = "no_agent"
|
||||
}
|
||||
|
||||
/// Memberwise init. Swift doesn't synthesize one for us because
|
||||
@@ -66,7 +73,8 @@ public struct HermesCronJob: Identifiable, Sendable, Codable {
|
||||
timeoutSeconds: Int? = nil,
|
||||
silent: Bool? = nil,
|
||||
workdir: String? = nil,
|
||||
contextFrom: [String]? = nil
|
||||
contextFrom: [String]? = nil,
|
||||
noAgent: Bool? = nil
|
||||
) {
|
||||
self.id = id
|
||||
self.name = name
|
||||
@@ -88,6 +96,7 @@ public struct HermesCronJob: Identifiable, Sendable, Codable {
|
||||
self.silent = silent
|
||||
self.workdir = workdir
|
||||
self.contextFrom = contextFrom
|
||||
self.noAgent = noAgent
|
||||
}
|
||||
|
||||
public nonisolated init(from decoder: any Decoder) throws {
|
||||
@@ -112,6 +121,7 @@ public struct HermesCronJob: Identifiable, Sendable, Codable {
|
||||
self.silent = try c.decodeIfPresent(Bool.self, forKey: .silent)
|
||||
self.workdir = try c.decodeIfPresent(String.self, forKey: .workdir)
|
||||
self.contextFrom = try c.decodeIfPresent([String].self, forKey: .contextFrom)
|
||||
self.noAgent = try c.decodeIfPresent(Bool.self, forKey: .noAgent)
|
||||
}
|
||||
|
||||
public nonisolated func encode(to encoder: any Encoder) throws {
|
||||
@@ -136,6 +146,7 @@ public struct HermesCronJob: Identifiable, Sendable, Codable {
|
||||
try c.encodeIfPresent(silent, forKey: .silent)
|
||||
try c.encodeIfPresent(workdir, forKey: .workdir)
|
||||
try c.encodeIfPresent(contextFrom, forKey: .contextFrom)
|
||||
try c.encodeIfPresent(noAgent, forKey: .noAgent)
|
||||
}
|
||||
|
||||
public nonisolated var stateIcon: String {
|
||||
|
||||
@@ -0,0 +1,124 @@
|
||||
import Foundation
|
||||
|
||||
/// One entry in the `hermes curator list-archived` output. Decoded
|
||||
/// tolerantly via `decodeIfPresent` so a stripped-down host (or a future
|
||||
/// Hermes that drops one of the optional columns) doesn't crash the view.
|
||||
///
|
||||
/// Only `name` is required — every other field is optional and the
|
||||
/// computed `*Label` accessors render `"—"` for missing values.
|
||||
public struct HermesCuratorArchivedSkill: Sendable, Equatable, Identifiable, Codable {
|
||||
public var id: String { name }
|
||||
public let name: String
|
||||
public let category: String?
|
||||
public let archivedAt: String?
|
||||
public let reason: String?
|
||||
public let sizeBytes: Int?
|
||||
public let path: String?
|
||||
|
||||
public init(
|
||||
name: String,
|
||||
category: String? = nil,
|
||||
archivedAt: String? = nil,
|
||||
reason: String? = nil,
|
||||
sizeBytes: Int? = nil,
|
||||
path: String? = nil
|
||||
) {
|
||||
self.name = name
|
||||
self.category = category
|
||||
self.archivedAt = archivedAt
|
||||
self.reason = reason
|
||||
self.sizeBytes = sizeBytes
|
||||
self.path = path
|
||||
}
|
||||
|
||||
private enum CodingKeys: String, CodingKey {
|
||||
case name
|
||||
case category
|
||||
case archivedAt = "archived_at"
|
||||
case reason
|
||||
case sizeBytes = "size_bytes"
|
||||
case path
|
||||
}
|
||||
|
||||
public init(from decoder: Decoder) throws {
|
||||
let c = try decoder.container(keyedBy: CodingKeys.self)
|
||||
self.name = try c.decode(String.self, forKey: .name)
|
||||
self.category = try c.decodeIfPresent(String.self, forKey: .category)
|
||||
self.archivedAt = try c.decodeIfPresent(String.self, forKey: .archivedAt)
|
||||
self.reason = try c.decodeIfPresent(String.self, forKey: .reason)
|
||||
self.sizeBytes = try c.decodeIfPresent(Int.self, forKey: .sizeBytes)
|
||||
self.path = try c.decodeIfPresent(String.self, forKey: .path)
|
||||
}
|
||||
|
||||
public func encode(to encoder: Encoder) throws {
|
||||
var c = encoder.container(keyedBy: CodingKeys.self)
|
||||
try c.encode(name, forKey: .name)
|
||||
try c.encodeIfPresent(category, forKey: .category)
|
||||
try c.encodeIfPresent(archivedAt, forKey: .archivedAt)
|
||||
try c.encodeIfPresent(reason, forKey: .reason)
|
||||
try c.encodeIfPresent(sizeBytes, forKey: .sizeBytes)
|
||||
try c.encodeIfPresent(path, forKey: .path)
|
||||
}
|
||||
|
||||
/// "4.4 KB" / "1.2 MB" / "—" for nil. Uses the SI byte formatter so
|
||||
/// the labels match what Finder shows.
|
||||
public var sizeLabel: String {
|
||||
guard let bytes = sizeBytes else { return "—" }
|
||||
let formatter = ByteCountFormatter()
|
||||
formatter.allowedUnits = [.useAll]
|
||||
formatter.countStyle = .file
|
||||
return formatter.string(fromByteCount: Int64(bytes))
|
||||
}
|
||||
|
||||
/// `2026-04-22` (ISO date prefix) / "—". Hermes returns full ISO
|
||||
/// timestamps with seconds + Z; the date prefix is what the user
|
||||
/// actually wants in the archived list.
|
||||
public var archivedAtLabel: String {
|
||||
guard let iso = archivedAt, !iso.isEmpty else { return "—" }
|
||||
// Trim to date prefix if it looks like a full ISO timestamp.
|
||||
if let tIdx = iso.firstIndex(of: "T") {
|
||||
return String(iso[..<tIdx])
|
||||
}
|
||||
return iso
|
||||
}
|
||||
}
|
||||
|
||||
/// Result of `hermes curator prune --dry-run` — what would be removed
|
||||
/// if the user confirms. The view derives `totalCount` from
|
||||
/// `wouldRemove.count` so the wire shape stays flat.
|
||||
public struct CuratorPruneSummary: Sendable, Equatable, Codable {
|
||||
public let wouldRemove: [HermesCuratorArchivedSkill]
|
||||
public let totalBytes: Int
|
||||
public var totalCount: Int { wouldRemove.count }
|
||||
|
||||
public init(wouldRemove: [HermesCuratorArchivedSkill], totalBytes: Int) {
|
||||
self.wouldRemove = wouldRemove
|
||||
self.totalBytes = totalBytes
|
||||
}
|
||||
|
||||
private enum CodingKeys: String, CodingKey {
|
||||
case wouldRemove = "would_remove"
|
||||
case totalBytes = "total_bytes"
|
||||
}
|
||||
|
||||
public init(from decoder: Decoder) throws {
|
||||
let c = try decoder.container(keyedBy: CodingKeys.self)
|
||||
self.wouldRemove = try c.decodeIfPresent([HermesCuratorArchivedSkill].self, forKey: .wouldRemove) ?? []
|
||||
self.totalBytes = try c.decodeIfPresent(Int.self, forKey: .totalBytes) ?? 0
|
||||
}
|
||||
|
||||
public func encode(to encoder: Encoder) throws {
|
||||
var c = encoder.container(keyedBy: CodingKeys.self)
|
||||
try c.encode(wouldRemove, forKey: .wouldRemove)
|
||||
try c.encode(totalBytes, forKey: .totalBytes)
|
||||
}
|
||||
|
||||
/// "12.3 KB" / "—" for empty. Convenience for the confirm sheet header.
|
||||
public var totalBytesLabel: String {
|
||||
guard totalBytes > 0 else { return "—" }
|
||||
let formatter = ByteCountFormatter()
|
||||
formatter.allowedUnits = [.useAll]
|
||||
formatter.countStyle = .file
|
||||
return formatter.string(fromByteCount: Int64(totalBytes))
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,158 @@
|
||||
import Foundation
|
||||
|
||||
/// A structured signal Hermes emits when it observes worker / task
|
||||
/// distress. Hermes v0.13 introduced a generic diagnostics engine that
|
||||
/// attaches these to a task (cross-run signals) and/or a run (per-attempt
|
||||
/// signals). Pre-v0.13 hosts never emit diagnostics so the array decodes
|
||||
/// empty and downstream UI no-ops.
|
||||
///
|
||||
/// **Wire shape (best inference from release notes — verify against live
|
||||
/// JSON during integration):** an array of objects with `kind`, optional
|
||||
/// `message`, optional `detected_at` (ISO-8601 string OR Unix integer,
|
||||
/// matching the rest of `HermesKanbanTask`'s timestamp tolerance).
|
||||
///
|
||||
/// **Forward compat:** `kind` stays a `String` so a future Hermes can
|
||||
/// add new diagnostic kinds without a Scarf release. `KanbanDiagnosticKind`
|
||||
/// is the typed mirror — it falls back to `.unknown` for unrecognized
|
||||
/// kinds and renders the raw string verbatim.
|
||||
public struct HermesKanbanDiagnostic: Sendable, Equatable, Identifiable, Codable {
|
||||
/// Synthetic id — not on the wire. Lets SwiftUI `ForEach` over a
|
||||
/// diagnostic array without forcing a deterministic id from the
|
||||
/// server (Hermes doesn't currently mint one).
|
||||
public let id: UUID
|
||||
/// Wire-side `kind` string. Compared case-insensitively via
|
||||
/// `KanbanDiagnosticKind.from(_:)`.
|
||||
public let kind: String
|
||||
/// Human-friendly elaboration ("no heartbeat for 4m20s", "exit code
|
||||
/// 0 with no complete call", etc.). May be nil; render the raw
|
||||
/// `kind` then.
|
||||
public let message: String?
|
||||
/// ISO-8601 string. Decoder accepts Unix integer seconds (Hermes's
|
||||
/// SQLite-backed shape) and converts to ISO-8601 so consumers see
|
||||
/// one type — same pattern as `HermesKanbanTask.decodeFlexibleTimestamp`.
|
||||
public let detectedAt: String?
|
||||
|
||||
public init(
|
||||
kind: String,
|
||||
message: String? = nil,
|
||||
detectedAt: String? = nil
|
||||
) {
|
||||
self.id = UUID()
|
||||
self.kind = kind
|
||||
self.message = message
|
||||
self.detectedAt = detectedAt
|
||||
}
|
||||
|
||||
enum CodingKeys: String, CodingKey {
|
||||
case kind
|
||||
case message
|
||||
case detectedAt = "detected_at"
|
||||
}
|
||||
|
||||
public init(from decoder: any Decoder) throws {
|
||||
let c = try decoder.container(keyedBy: CodingKeys.self)
|
||||
self.id = UUID()
|
||||
self.kind = try c.decodeIfPresent(String.self, forKey: .kind) ?? "unknown"
|
||||
self.message = try c.decodeIfPresent(String.self, forKey: .message)
|
||||
// Flexible timestamp decode mirrors HermesKanbanTask's pattern.
|
||||
if !c.contains(.detectedAt) {
|
||||
self.detectedAt = nil
|
||||
} else if let unix = try? c.decodeIfPresent(Double.self, forKey: .detectedAt) {
|
||||
let date = Date(timeIntervalSince1970: unix)
|
||||
self.detectedAt = Self.isoFormatter.string(from: date)
|
||||
} else {
|
||||
self.detectedAt = try c.decodeIfPresent(String.self, forKey: .detectedAt)
|
||||
}
|
||||
}
|
||||
|
||||
public func encode(to encoder: any Encoder) throws {
|
||||
var c = encoder.container(keyedBy: CodingKeys.self)
|
||||
try c.encode(kind, forKey: .kind)
|
||||
try c.encodeIfPresent(message, forKey: .message)
|
||||
try c.encodeIfPresent(detectedAt, forKey: .detectedAt)
|
||||
}
|
||||
|
||||
public static func == (lhs: HermesKanbanDiagnostic, rhs: HermesKanbanDiagnostic) -> Bool {
|
||||
// Compare on wire fields, not synthetic id — round-trip decoding
|
||||
// mints fresh ids.
|
||||
lhs.kind == rhs.kind
|
||||
&& lhs.message == rhs.message
|
||||
&& lhs.detectedAt == rhs.detectedAt
|
||||
}
|
||||
|
||||
private static let isoFormatter: ISO8601DateFormatter = {
|
||||
let f = ISO8601DateFormatter()
|
||||
f.formatOptions = [.withInternetDateTime]
|
||||
return f
|
||||
}()
|
||||
}
|
||||
|
||||
// MARK: - Typed mirror
|
||||
|
||||
/// Typed view of `HermesKanbanDiagnostic.kind`. Models keep the raw
|
||||
/// string for forward compatibility; UI helpers read this enum to pick
|
||||
/// the right glyph + tint without string-matching at every callsite.
|
||||
///
|
||||
/// `unknown` is the fallback for any kind a future Hermes adds that
|
||||
/// Scarf doesn't recognize. Views render the raw string verbatim in
|
||||
/// that case so the user still sees what Hermes flagged.
|
||||
// TODO(WS-3-Q5): The exact `kind` string for darwin-zombie detection is
|
||||
// inferred from the v0.13 release notes ("Detect darwin zombie workers");
|
||||
// confirm against live `hermes kanban show --json` output during
|
||||
// integration. Same for `worker_exit_no_complete` and the heartbeat-stalled
|
||||
// kinds — typed mirror falls through to `.unknown` if the wire string
|
||||
// drifts, and the raw string is still rendered.
|
||||
public enum KanbanDiagnosticKind: String, Sendable, CaseIterable {
|
||||
case heartbeatStalled = "heartbeat_stalled"
|
||||
case toolErrorLoop = "tool_error_loop"
|
||||
case retryCapHit = "retry_cap_hit"
|
||||
case unboundedRetry = "unbounded_retry"
|
||||
case darwinZombieDetected = "darwin_zombie_detected"
|
||||
case spawnFailure = "spawn_failure"
|
||||
case workerExitNoComplete = "worker_exit_no_complete"
|
||||
case unknown
|
||||
|
||||
/// Map a wire string (case-insensitive) to a typed kind. Unknown
|
||||
/// values fall through to `.unknown` so callers can still surface
|
||||
/// the raw string.
|
||||
public static func from(_ raw: String) -> KanbanDiagnosticKind {
|
||||
KanbanDiagnosticKind(rawValue: raw.lowercased()) ?? .unknown
|
||||
}
|
||||
|
||||
/// SF Symbol name to render alongside the diagnostic. View code
|
||||
/// reaches through the typed enum so glyph choices live in one
|
||||
/// place.
|
||||
public var glyphName: String {
|
||||
switch self {
|
||||
case .heartbeatStalled: return "waveform.path.badge.minus"
|
||||
case .toolErrorLoop: return "arrow.triangle.2.circlepath.exclamationmark"
|
||||
case .retryCapHit: return "nosign"
|
||||
case .unboundedRetry: return "arrow.clockwise.circle.fill"
|
||||
case .darwinZombieDetected: return "apple.logo"
|
||||
case .spawnFailure: return "bolt.slash"
|
||||
case .workerExitNoComplete: return "figure.walk.departure"
|
||||
case .unknown: return "stethoscope"
|
||||
}
|
||||
}
|
||||
|
||||
/// Severity tier for this kind — drives badge tint. `.danger` for
|
||||
/// terminal-class signals (retry cap hit, zombie, spawn failure);
|
||||
/// `.warning` for recoverable signals (heartbeat stalled, tool
|
||||
/// error loop); `.neutral` only for unknown / forward-compat kinds.
|
||||
public var severity: DiagnosticSeverity {
|
||||
switch self {
|
||||
case .retryCapHit, .darwinZombieDetected, .spawnFailure:
|
||||
return .danger
|
||||
case .heartbeatStalled, .toolErrorLoop, .unboundedRetry, .workerExitNoComplete:
|
||||
return .warning
|
||||
case .unknown:
|
||||
return .neutral
|
||||
}
|
||||
}
|
||||
|
||||
public enum DiagnosticSeverity: Sendable {
|
||||
case warning
|
||||
case danger
|
||||
case neutral
|
||||
}
|
||||
}
|
||||
@@ -24,6 +24,19 @@ public struct HermesKanbanRun: Sendable, Equatable, Identifiable, Codable {
|
||||
/// raw string so we don't lock the typed shape.
|
||||
public let metadataJSON: String?
|
||||
|
||||
// v0.13 (v2026.5.7) fields. Both Optional / empty-default so a v0.12
|
||||
// host's run row decodes without error.
|
||||
/// Per-attempt distress signals. Cross-run signals (retry cap hit,
|
||||
/// etc.) hang off `HermesKanbanTask.diagnostics`; in-flight signals
|
||||
/// (heartbeat stalled, darwin zombie detected) attach here.
|
||||
public let diagnostics: [HermesKanbanDiagnostic]
|
||||
/// Server-side unified failure counter (renamed from three separate
|
||||
/// spawn / timeout / crash counters in v0.13). Optional — when nil,
|
||||
/// callers fall back to counting failed runs in the runs array.
|
||||
// TODO(WS-3-Q4): Verify whether v0.13 exposes this field on the per-run
|
||||
// shape OR only at the task level. Tolerant decode handles either.
|
||||
public let failureCount: Int?
|
||||
|
||||
public init(
|
||||
id: Int,
|
||||
taskId: String,
|
||||
@@ -40,7 +53,9 @@ public struct HermesKanbanRun: Sendable, Equatable, Identifiable, Codable {
|
||||
outcome: String? = nil,
|
||||
summary: String? = nil,
|
||||
error: String? = nil,
|
||||
metadataJSON: String? = nil
|
||||
metadataJSON: String? = nil,
|
||||
diagnostics: [HermesKanbanDiagnostic] = [],
|
||||
failureCount: Int? = nil
|
||||
) {
|
||||
self.id = id
|
||||
self.taskId = taskId
|
||||
@@ -58,6 +73,8 @@ public struct HermesKanbanRun: Sendable, Equatable, Identifiable, Codable {
|
||||
self.summary = summary
|
||||
self.error = error
|
||||
self.metadataJSON = metadataJSON
|
||||
self.diagnostics = diagnostics
|
||||
self.failureCount = failureCount
|
||||
}
|
||||
|
||||
enum CodingKeys: String, CodingKey {
|
||||
@@ -77,6 +94,8 @@ public struct HermesKanbanRun: Sendable, Equatable, Identifiable, Codable {
|
||||
case summary
|
||||
case error
|
||||
case metadata
|
||||
case diagnostics
|
||||
case failureCount = "failure_count"
|
||||
}
|
||||
|
||||
public init(from decoder: any Decoder) throws {
|
||||
@@ -120,6 +139,11 @@ public struct HermesKanbanRun: Sendable, Equatable, Identifiable, Codable {
|
||||
} else {
|
||||
self.metadataJSON = nil
|
||||
}
|
||||
|
||||
// v0.13 diagnostics array — `try?` so a malformed entry doesn't
|
||||
// poison the whole run row. Empty default for pre-v0.13 hosts.
|
||||
self.diagnostics = (try? c.decodeIfPresent([HermesKanbanDiagnostic].self, forKey: .diagnostics)) ?? []
|
||||
self.failureCount = try c.decodeIfPresent(Int.self, forKey: .failureCount)
|
||||
}
|
||||
|
||||
public func encode(to encoder: any Encoder) throws {
|
||||
@@ -140,5 +164,7 @@ public struct HermesKanbanRun: Sendable, Equatable, Identifiable, Codable {
|
||||
try c.encodeIfPresent(summary, forKey: .summary)
|
||||
try c.encodeIfPresent(error, forKey: .error)
|
||||
try c.encodeIfPresent(metadataJSON, forKey: .metadata)
|
||||
try c.encode(diagnostics, forKey: .diagnostics)
|
||||
try c.encodeIfPresent(failureCount, forKey: .failureCount)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -9,8 +9,9 @@ import Foundation
|
||||
/// `link`/`unlink`, `comment`, `dispatch`).
|
||||
///
|
||||
/// Hermes has no `update` verb — `priority` / `title` / `body` /
|
||||
/// `tenant` are write-once at create time. Mutations after that are
|
||||
/// expressed as state transitions (status, assignee) or new comments.
|
||||
/// `tenant` / `max_retries` are write-once at create time. Mutations
|
||||
/// after that are expressed as state transitions (status, assignee) or
|
||||
/// new comments.
|
||||
public struct HermesKanbanTask: Sendable, Equatable, Identifiable, Codable {
|
||||
public let id: String
|
||||
public let title: String
|
||||
@@ -34,6 +35,29 @@ public struct HermesKanbanTask: Sendable, Equatable, Identifiable, Codable {
|
||||
public let maxRuntimeSeconds: Int?
|
||||
public let currentRunId: Int?
|
||||
|
||||
// v0.13 (v2026.5.7) reliability + recovery fields. All Optional with
|
||||
// `nil` decoded for pre-v0.13 hosts so the v2.7.5 surface keeps
|
||||
// rendering unchanged when the connected Hermes hasn't shipped them.
|
||||
/// Per-task retry budget set at create time via `--max-retries N`.
|
||||
/// Hermes pattern is write-once — no `set_max_retries` verb. Scarf
|
||||
/// surfaces this read-only on the inspector header.
|
||||
public let maxRetries: Int?
|
||||
/// Server-supplied reason a task was auto-blocked (e.g. "worker
|
||||
/// exited (code 0) without calling `kanban complete`"). Surfaced
|
||||
/// verbatim in the inspector banner.
|
||||
public let autoBlockedReason: String?
|
||||
/// `pending` / `verified` / `rejected` / nil. Pending means a worker
|
||||
/// claimed it created this card but Hermes hasn't confirmed the
|
||||
/// underlying work exists. Read through `KanbanHallucinationGate.from`
|
||||
/// to map to a typed mirror — kept as a String at the wire level so
|
||||
/// Hermes can add new gate states (e.g. `quarantined`) without a
|
||||
/// Scarf release.
|
||||
public let hallucinationGateStatus: String?
|
||||
/// Cross-run distress signals (retry cap hit, etc.). Per-run signals
|
||||
/// hang off `HermesKanbanRun.diagnostics`. Empty array for pre-v0.13
|
||||
/// hosts AND for tasks the diagnostics engine hasn't flagged.
|
||||
public let diagnostics: [HermesKanbanDiagnostic]
|
||||
|
||||
public init(
|
||||
id: String,
|
||||
title: String,
|
||||
@@ -53,7 +77,11 @@ public struct HermesKanbanTask: Sendable, Equatable, Identifiable, Codable {
|
||||
idempotencyKey: String? = nil,
|
||||
lastHeartbeatAt: String? = nil,
|
||||
maxRuntimeSeconds: Int? = nil,
|
||||
currentRunId: Int? = nil
|
||||
currentRunId: Int? = nil,
|
||||
maxRetries: Int? = nil,
|
||||
autoBlockedReason: String? = nil,
|
||||
hallucinationGateStatus: String? = nil,
|
||||
diagnostics: [HermesKanbanDiagnostic] = []
|
||||
) {
|
||||
self.id = id
|
||||
self.title = title
|
||||
@@ -74,6 +102,10 @@ public struct HermesKanbanTask: Sendable, Equatable, Identifiable, Codable {
|
||||
self.lastHeartbeatAt = lastHeartbeatAt
|
||||
self.maxRuntimeSeconds = maxRuntimeSeconds
|
||||
self.currentRunId = currentRunId
|
||||
self.maxRetries = maxRetries
|
||||
self.autoBlockedReason = autoBlockedReason
|
||||
self.hallucinationGateStatus = hallucinationGateStatus
|
||||
self.diagnostics = diagnostics
|
||||
}
|
||||
|
||||
enum CodingKeys: String, CodingKey {
|
||||
@@ -89,6 +121,10 @@ public struct HermesKanbanTask: Sendable, Equatable, Identifiable, Codable {
|
||||
case lastHeartbeatAt = "last_heartbeat_at"
|
||||
case maxRuntimeSeconds = "max_runtime_seconds"
|
||||
case currentRunId = "current_run_id"
|
||||
case maxRetries = "max_retries"
|
||||
case autoBlockedReason = "auto_blocked_reason"
|
||||
case hallucinationGateStatus = "hallucination_gate_status"
|
||||
case diagnostics
|
||||
}
|
||||
|
||||
public init(from decoder: any Decoder) throws {
|
||||
@@ -117,6 +153,17 @@ public struct HermesKanbanTask: Sendable, Equatable, Identifiable, Codable {
|
||||
self.lastHeartbeatAt = try Self.decodeFlexibleTimestamp(c, forKey: .lastHeartbeatAt)
|
||||
self.maxRuntimeSeconds = try c.decodeIfPresent(Int.self, forKey: .maxRuntimeSeconds)
|
||||
self.currentRunId = try c.decodeIfPresent(Int.self, forKey: .currentRunId)
|
||||
// v0.13 fields — every one is `decodeIfPresent` so a v0.12 host's
|
||||
// task row decodes successfully with these all nil/empty. The
|
||||
// tolerant-decode contract is pinned by KanbanModelsTests.
|
||||
self.maxRetries = try c.decodeIfPresent(Int.self, forKey: .maxRetries)
|
||||
self.autoBlockedReason = try c.decodeIfPresent(String.self, forKey: .autoBlockedReason)
|
||||
self.hallucinationGateStatus = try c.decodeIfPresent(String.self, forKey: .hallucinationGateStatus)
|
||||
// Wrap diagnostics decode in `try?` so a single malformed entry
|
||||
// (or the whole array being the wrong shape) doesn't poison the
|
||||
// task row — the rest of the decoder still produces a usable
|
||||
// task. Empty default matches the `skills` pattern.
|
||||
self.diagnostics = (try? c.decodeIfPresent([HermesKanbanDiagnostic].self, forKey: .diagnostics)) ?? []
|
||||
}
|
||||
|
||||
/// Decode a timestamp that may arrive as a Unix integer or an
|
||||
@@ -209,3 +256,27 @@ public enum KanbanBoardColumn: String, Sendable, CaseIterable, Identifiable {
|
||||
.triage, .upNext, .running, .blocked, .done
|
||||
]
|
||||
}
|
||||
|
||||
// MARK: - Hallucination gate (v0.13)
|
||||
|
||||
/// Typed mirror of Hermes v0.13's hallucination-gate state. Worker-created
|
||||
/// cards land in `pending` until something verifies the underlying work
|
||||
/// exists; Scarf surfaces a Verify / Reject UX above the task body so the
|
||||
/// user can act as the verification gate.
|
||||
///
|
||||
/// Kept separate from `KanbanStatus` because hallucination state is
|
||||
/// orthogonal to the lifecycle — a card can be `ready` *and* `pending`,
|
||||
/// for example.
|
||||
public enum KanbanHallucinationGate: String, Sendable, CaseIterable {
|
||||
case pending
|
||||
case verified
|
||||
case rejected
|
||||
|
||||
/// Map a raw `hallucination_gate_status` string (case-insensitive) to
|
||||
/// a typed gate. Returns nil for empty/nil/unknown values so callers
|
||||
/// can short-circuit "no gate" branches with `if let gate = …`.
|
||||
public static func from(_ raw: String?) -> KanbanHallucinationGate? {
|
||||
guard let raw, !raw.isEmpty else { return nil }
|
||||
return KanbanHallucinationGate(rawValue: raw.lowercased())
|
||||
}
|
||||
}
|
||||
|
||||
@@ -12,17 +12,27 @@ public struct HermesKanbanTaskDetail: Sendable, Equatable, Codable {
|
||||
/// to the worker as upstream context; surfacing them in the
|
||||
/// inspector is useful for understanding why a task started.
|
||||
public let parentResults: [String: String]
|
||||
/// Envelope-level diagnostics array (sibling to `task`, not nested
|
||||
/// inside it). Defensive — Hermes v0.13's wire shape may attach
|
||||
/// diagnostics to the task itself OR to the envelope.
|
||||
/// `allDiagnostics` dedupes both sources by `(kind, detected_at)`.
|
||||
// TODO(WS-3-Q2): Confirm against live `hermes kanban show --json`
|
||||
// whether diagnostics live on the task envelope, the inner task, or
|
||||
// both. Current decode is tolerant of either.
|
||||
public let envelopeDiagnostics: [HermesKanbanDiagnostic]?
|
||||
|
||||
public init(
|
||||
task: HermesKanbanTask,
|
||||
comments: [HermesKanbanComment] = [],
|
||||
events: [HermesKanbanEvent] = [],
|
||||
parentResults: [String: String] = [:]
|
||||
parentResults: [String: String] = [:],
|
||||
envelopeDiagnostics: [HermesKanbanDiagnostic]? = nil
|
||||
) {
|
||||
self.task = task
|
||||
self.comments = comments
|
||||
self.events = events
|
||||
self.parentResults = parentResults
|
||||
self.envelopeDiagnostics = envelopeDiagnostics
|
||||
}
|
||||
|
||||
enum CodingKeys: String, CodingKey {
|
||||
@@ -30,6 +40,7 @@ public struct HermesKanbanTaskDetail: Sendable, Equatable, Codable {
|
||||
case comments
|
||||
case events
|
||||
case parentResults = "parent_results"
|
||||
case envelopeDiagnostics = "diagnostics"
|
||||
}
|
||||
|
||||
public init(from decoder: any Decoder) throws {
|
||||
@@ -48,6 +59,9 @@ public struct HermesKanbanTaskDetail: Sendable, Equatable, Codable {
|
||||
self.comments = (try? container.decodeIfPresent([HermesKanbanComment].self, forKey: .comments)) ?? []
|
||||
self.events = (try? container.decodeIfPresent([HermesKanbanEvent].self, forKey: .events)) ?? []
|
||||
self.parentResults = (try? container.decodeIfPresent([String: String].self, forKey: .parentResults)) ?? [:]
|
||||
// Same `try?` shield as the rest — a malformed envelope
|
||||
// diagnostics array shouldn't reject the whole show response.
|
||||
self.envelopeDiagnostics = try? container.decodeIfPresent([HermesKanbanDiagnostic].self, forKey: .envelopeDiagnostics)
|
||||
}
|
||||
|
||||
public func encode(to encoder: any Encoder) throws {
|
||||
@@ -56,5 +70,20 @@ public struct HermesKanbanTaskDetail: Sendable, Equatable, Codable {
|
||||
try c.encode(comments, forKey: .comments)
|
||||
try c.encode(events, forKey: .events)
|
||||
try c.encode(parentResults, forKey: .parentResults)
|
||||
try c.encodeIfPresent(envelopeDiagnostics, forKey: .envelopeDiagnostics)
|
||||
}
|
||||
|
||||
/// Unified diagnostics view for the inspector. Combines `task.diagnostics`
|
||||
/// with envelope-level diagnostics (when present) and dedupes on the
|
||||
/// `(kind, detectedAt)` tuple. Wire-side dupes are unlikely but cheap to
|
||||
/// filter. Empty for pre-v0.13 hosts.
|
||||
public var allDiagnostics: [HermesKanbanDiagnostic] {
|
||||
let onTask = task.diagnostics
|
||||
let onEnvelope = envelopeDiagnostics ?? []
|
||||
var seen = Set<String>()
|
||||
return (onTask + onEnvelope).filter { diag in
|
||||
let key = "\(diag.kind)|\(diag.detectedAt ?? "")"
|
||||
return seen.insert(key).inserted
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,6 +3,10 @@ import Foundation
|
||||
public enum MCPTransport: String, Sendable, Equatable, CaseIterable, Identifiable {
|
||||
case stdio
|
||||
case http
|
||||
/// Server-Sent Events transport. Hermes v0.13+ only.
|
||||
// TODO(WS-7-Q1): Verify Hermes uses the literal `sse` transport name
|
||||
// (vs. `streamable-http`/`http-sse`/etc.) once a v0.13 host is on hand.
|
||||
case sse
|
||||
|
||||
public var id: String { rawValue }
|
||||
|
||||
@@ -11,6 +15,7 @@ public enum MCPTransport: String, Sendable, Equatable, CaseIterable, Identifiabl
|
||||
switch self {
|
||||
case .stdio: return "Local (stdio)"
|
||||
case .http: return "Remote (HTTP)"
|
||||
case .sse: return "Remote (SSE)"
|
||||
}
|
||||
}
|
||||
#endif
|
||||
@@ -33,6 +38,12 @@ public struct HermesMCPServer: Identifiable, Sendable, Equatable {
|
||||
public let resourcesEnabled: Bool
|
||||
public let promptsEnabled: Bool
|
||||
public let hasOAuthToken: Bool
|
||||
/// Hermes-side keepalive interval (seconds) for SSE transport. `nil`
|
||||
/// when the YAML doesn't specify `sse_read_timeout` (Hermes default
|
||||
/// applies). Pre-v0.13 hosts always have this as `nil`.
|
||||
// TODO(WS-7-Q2): Default is assumed to be 300s per WS-7 plan; placeholder
|
||||
// copy uses that. Verify against `~/.hermes/hermes-agent/hermes_cli/mcp.py`.
|
||||
public let sseReadTimeout: Int?
|
||||
|
||||
|
||||
public init(
|
||||
@@ -51,7 +62,8 @@ public struct HermesMCPServer: Identifiable, Sendable, Equatable {
|
||||
toolsExclude: [String],
|
||||
resourcesEnabled: Bool,
|
||||
promptsEnabled: Bool,
|
||||
hasOAuthToken: Bool
|
||||
hasOAuthToken: Bool,
|
||||
sseReadTimeout: Int? = nil
|
||||
) {
|
||||
self.name = name
|
||||
self.transport = transport
|
||||
@@ -69,6 +81,7 @@ public struct HermesMCPServer: Identifiable, Sendable, Equatable {
|
||||
self.resourcesEnabled = resourcesEnabled
|
||||
self.promptsEnabled = promptsEnabled
|
||||
self.hasOAuthToken = hasOAuthToken
|
||||
self.sseReadTimeout = sseReadTimeout
|
||||
}
|
||||
public var id: String { name }
|
||||
|
||||
@@ -79,6 +92,8 @@ public struct HermesMCPServer: Identifiable, Sendable, Equatable {
|
||||
return (command ?? "") + argString
|
||||
case .http:
|
||||
return url ?? ""
|
||||
case .sse:
|
||||
return url ?? ""
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,23 @@
|
||||
import Foundation
|
||||
|
||||
/// One queued prompt the user has staged via `/queue <text>` (Hermes
|
||||
/// v0.13+ ACP `/queue` slash command). Hermes is the authoritative owner
|
||||
/// of the actual queue server-side — Scarf maintains this mirror so the
|
||||
/// chat header chip + popover can show "what's pending" without an
|
||||
/// extra round-trip. The mirror drains best-effort when a turn
|
||||
/// completes (`RichChatViewModel.popQueuedPrompt`).
|
||||
///
|
||||
/// `id` is a Scarf-side UUID minted at queue-time — Hermes' wire
|
||||
/// protocol does not expose a per-queue-entry id, so we never round-trip
|
||||
/// an entry-level identifier. See WS-2 plan Q5.
|
||||
public struct HermesQueuedPrompt: Sendable, Equatable, Identifiable {
|
||||
public let id: UUID
|
||||
public let text: String
|
||||
public let queuedAt: Date
|
||||
|
||||
public init(id: UUID = UUID(), text: String, queuedAt: Date = Date()) {
|
||||
self.id = id
|
||||
self.text = text
|
||||
self.queuedAt = queuedAt
|
||||
}
|
||||
}
|
||||
@@ -60,6 +60,17 @@ public enum KnownPlatforms {
|
||||
// platform identifiers.
|
||||
HermesToolPlatform(name: "yuanbao", displayName: "Yuanbao 元宝", icon: "bubble.left.and.bubble.right.fill"),
|
||||
HermesToolPlatform(name: "microsoft-teams", displayName: "Microsoft Teams", icon: "person.2.fill"),
|
||||
// -- v0.13 additions ---------------------------------------------
|
||||
// Google Chat is the 20th gateway platform. It's a generic
|
||||
// `env_enablement_fn` / `cron_deliver_env_var`-driven adapter; setup
|
||||
// runs through `hermes setup` rather than per-field forms because
|
||||
// the auth dance is OAuth-style and lives outside Scarf. Identifier
|
||||
// is `google-chat` (kebab-case, mirroring `microsoft-teams`).
|
||||
// TODO(WS-5-Q1): verify identifier against Hermes v0.13 GA — if it
|
||||
// ships as `googlechat` instead, update both this entry and
|
||||
// `KnownPlatforms.icon(for:)` below. `GatewayAllowlistKind.kind(for:)`
|
||||
// already accepts both spellings defensively.
|
||||
HermesToolPlatform(name: "google-chat", displayName: "Google Chat", icon: "bubble.left.fill"),
|
||||
]
|
||||
|
||||
public static func icon(for platform: String) -> String {
|
||||
@@ -79,6 +90,7 @@ public enum KnownPlatforms {
|
||||
case "imessage": return "message.fill"
|
||||
case "yuanbao": return "bubble.left.and.bubble.right.fill"
|
||||
case "microsoft-teams": return "person.2.fill"
|
||||
case "google-chat", "googlechat": return "bubble.left.fill"
|
||||
default: return "bubble.left"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -17,6 +17,15 @@ public struct KanbanCreateRequest: Sendable, Equatable {
|
||||
public var maxRuntimeSeconds: Int?
|
||||
public var createdBy: String?
|
||||
public var skills: [String]
|
||||
/// v0.13: per-task retry budget. `--max-retries N` is write-once at
|
||||
/// create time — no `set_max_retries` verb. Pass `nil` to let Hermes
|
||||
/// pick its built-in default (3 as of v0.13.0). Capability-gated in
|
||||
/// the create sheet on `hasKanbanDiagnostics`.
|
||||
// TODO(WS-3-Q6): Confirm Hermes's global default for `max_retries`
|
||||
// (v0.13 release notes don't enumerate it). The create sheet defaults
|
||||
// the field to 3; if Hermes config exposes a different default, mirror
|
||||
// it.
|
||||
public var maxRetries: Int?
|
||||
|
||||
public init(
|
||||
title: String,
|
||||
@@ -30,7 +39,8 @@ public struct KanbanCreateRequest: Sendable, Equatable {
|
||||
idempotencyKey: String? = nil,
|
||||
maxRuntimeSeconds: Int? = nil,
|
||||
createdBy: String? = nil,
|
||||
skills: [String] = []
|
||||
skills: [String] = [],
|
||||
maxRetries: Int? = nil
|
||||
) {
|
||||
self.title = title
|
||||
self.body = body
|
||||
@@ -44,6 +54,7 @@ public struct KanbanCreateRequest: Sendable, Equatable {
|
||||
self.maxRuntimeSeconds = maxRuntimeSeconds
|
||||
self.createdBy = createdBy
|
||||
self.skills = skills
|
||||
self.maxRetries = maxRetries
|
||||
}
|
||||
|
||||
/// Build the argv suffix this request maps to (everything after
|
||||
@@ -78,6 +89,9 @@ public struct KanbanCreateRequest: Sendable, Equatable {
|
||||
if let maxRuntimeSeconds {
|
||||
args.append(contentsOf: ["--max-runtime", "\(maxRuntimeSeconds)s"])
|
||||
}
|
||||
if let maxRetries {
|
||||
args.append(contentsOf: ["--max-retries", String(maxRetries)])
|
||||
}
|
||||
if let createdBy, !createdBy.isEmpty {
|
||||
args.append(contentsOf: ["--created-by", createdBy])
|
||||
}
|
||||
|
||||
@@ -225,6 +225,58 @@ public extension HermesConfig {
|
||||
cooldownSeconds: int("platforms.homeassistant.extra.cooldown_seconds", default: 30)
|
||||
)
|
||||
|
||||
// -- v0.13: per-platform Messaging Gateway settings --------------
|
||||
// Read `gateway.platforms.<platform>.{allowed_channels|allowed_chats|
|
||||
// allowed_rooms|busy_ack_enabled|gateway_restart_notification|
|
||||
// slash_command_notice_ttl_seconds}` and bundle each platform that
|
||||
// has at least one v0.13 key present in the file. Platforms without
|
||||
// an explicit block don't appear in the dictionary, so the
|
||||
// editor's `?? .empty` fallback hands the user the v0.13 defaults
|
||||
// without leaving stale keys littered across the YAML.
|
||||
//
|
||||
// TODO(WS-5-Q2): the `gateway.platforms.*` path is unverified —
|
||||
// Hermes v0.13 may emit allowlists under `platforms.<platform>.*`
|
||||
// (sibling to existing `platforms.slack.reply_to_mode`) instead.
|
||||
// If so, swap the `prefix` line below to `"platforms.\(platform)."`
|
||||
// and update `GatewayConfigWriter` in lockstep.
|
||||
let gatewayAllowlistPlatforms = [
|
||||
"slack", "mattermost", "google-chat",
|
||||
"telegram", "whatsapp",
|
||||
"matrix", "dingtalk",
|
||||
]
|
||||
var gatewayPlatforms: [String: GatewayPlatformSettings] = [:]
|
||||
for platform in gatewayAllowlistPlatforms {
|
||||
let prefix = "gateway.platforms.\(platform)."
|
||||
let allowedChannels = lists[prefix + "allowed_channels"] ?? []
|
||||
let allowedChats = lists[prefix + "allowed_chats"] ?? []
|
||||
let allowedRooms = lists[prefix + "allowed_rooms"] ?? []
|
||||
let busy = bool(prefix + "busy_ack_enabled", default: true)
|
||||
let restartNotice = bool(prefix + "gateway_restart_notification",
|
||||
default: false)
|
||||
let ttl = int(prefix + "slash_command_notice_ttl_seconds",
|
||||
default: 0)
|
||||
// Skip platforms with no v0.13 fields present anywhere in the
|
||||
// file. Without this guard, every supported platform would
|
||||
// round-trip an all-default block back through writes even
|
||||
// when the user never touched the new surface.
|
||||
let isEmpty = allowedChannels.isEmpty
|
||||
&& allowedChats.isEmpty
|
||||
&& allowedRooms.isEmpty
|
||||
&& values[prefix + "busy_ack_enabled"] == nil
|
||||
&& values[prefix + "gateway_restart_notification"] == nil
|
||||
&& values[prefix + "slash_command_notice_ttl_seconds"] == nil
|
||||
if !isEmpty {
|
||||
gatewayPlatforms[platform] = GatewayPlatformSettings(
|
||||
allowedChannels: allowedChannels,
|
||||
allowedChats: allowedChats,
|
||||
allowedRooms: allowedRooms,
|
||||
busyAckEnabled: busy,
|
||||
gatewayRestartNotification: restartNotice,
|
||||
slashCommandNoticeTTLSeconds: ttl
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
self.init(
|
||||
model: str("model.default", default: "unknown"),
|
||||
provider: str("model.provider", default: "unknown"),
|
||||
@@ -284,7 +336,26 @@ public extension HermesConfig {
|
||||
homeAssistant: homeAssistant,
|
||||
cacheTTL: str("prompt_caching.cache_ttl", default: "5m"),
|
||||
redactionEnabled: bool("redaction.enabled", default: false),
|
||||
runtimeMetadataFooter: bool("agent.runtime_metadata_footer", default: false)
|
||||
runtimeMetadataFooter: bool("agent.runtime_metadata_footer", default: false),
|
||||
gatewayPlatforms: gatewayPlatforms,
|
||||
// -- v0.13 additions -------------------------------------
|
||||
// TODO(WS-6-Q1): the `openrouter.response_cache.enabled`
|
||||
// key shape is provisional pending verification against a
|
||||
// v0.13 `hermes config check`. If upstream uses a different
|
||||
// path (e.g. `providers.openrouter.response_cache_enabled`
|
||||
// or nested under `prompt_caching`), update this single
|
||||
// line + the matching `setSetting` key in
|
||||
// `SettingsViewModel.setOpenRouterResponseCache`. Default
|
||||
// is `false` per WS-6-plan §Open Questions #2.
|
||||
imageGenModel: str("image_gen.model", default: ""),
|
||||
openrouterResponseCacheEnabled: bool("openrouter.response_cache.enabled", default: false),
|
||||
// Pre-v0.13 hosts wrote a single `web_tools.backend`. v0.13 split
|
||||
// it into per-capability keys. Read all three so the round-trip
|
||||
// never loses a value the user already set; the WebTools tab
|
||||
// chooses which to render based on `hasWebToolsBackendSplit`.
|
||||
webToolsBackend: str("web_tools.backend", default: "duckduckgo"),
|
||||
webToolsSearchBackend: str("web_tools.search.backend", default: "duckduckgo"),
|
||||
webToolsExtractBackend: str("web_tools.extract.backend", default: "reader")
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,358 @@
|
||||
import Foundation
|
||||
#if canImport(os)
|
||||
import os
|
||||
#endif
|
||||
|
||||
/// Async, transport-aware client for `hermes curator …`. Wraps the v0.12
|
||||
/// verbs (`status / run / pause / resume / pin / unpin / restore`) plus
|
||||
/// the v0.13 archive surface (`archive / prune / list-archived` and a
|
||||
/// synchronous-blocking `run`).
|
||||
///
|
||||
/// **Concurrency.** Pure-I/O `actor` — no UI state. View models hold a
|
||||
/// service reference and `await` methods. Each public method dispatches
|
||||
/// the underlying CLI invocation through `Task.detached(priority:
|
||||
/// .utility)` so two concurrent reads from the VM don't queue end-to-end
|
||||
/// on a single thread. Mirrors `KanbanService` shape exactly.
|
||||
///
|
||||
/// **Capability gating happens at the call site, not in the service.**
|
||||
/// `runNow(synchronous:timeout:)` takes a flag from the VM (the VM reads
|
||||
/// `HermesCapabilities.hasCuratorArchive` to decide). The service stays
|
||||
/// version-agnostic — only the timeout differs in practice.
|
||||
public actor CuratorService {
|
||||
#if canImport(os)
|
||||
private static let logger = Logger(subsystem: "com.scarf", category: "CuratorService")
|
||||
#endif
|
||||
|
||||
private let context: ServerContext
|
||||
|
||||
public init(context: ServerContext) {
|
||||
self.context = context
|
||||
}
|
||||
|
||||
// MARK: - Reads
|
||||
|
||||
/// Run `hermes curator status` and parse stdout via
|
||||
/// `HermesCuratorStatusParser`. Combines the text output with the
|
||||
/// on-disk `.curator_state` JSON for richer last-run metadata.
|
||||
/// Never throws — a transport failure resolves to `.empty` so the
|
||||
/// view always has something to render.
|
||||
public func status() async -> HermesCuratorStatus {
|
||||
let context = self.context
|
||||
return await Task.detached(priority: .utility) { () -> HermesCuratorStatus in
|
||||
let textResult = Self.runHermesSync(context: context, args: ["curator", "status"], timeout: 30)
|
||||
let stateData = context.readData(context.paths.curatorStateFile)
|
||||
return HermesCuratorStatusParser.parse(text: textResult.output, stateFileJSON: stateData)
|
||||
}.value
|
||||
}
|
||||
|
||||
/// `hermes curator list-archived [--json]`. Prefers JSON; falls back
|
||||
/// to a defensive text parser. Empty / "no archived skills" sentinel
|
||||
/// folds to `[]`.
|
||||
public func listArchived() async throws -> [HermesCuratorArchivedSkill] {
|
||||
// TODO(WS-4-Q2): confirm `--json` is supported on v0.13
|
||||
// `list-archived`. If not, drop the flag and rely on the text
|
||||
// parser path. Until then we pass `--json` and parse the output
|
||||
// tolerantly.
|
||||
let args = ["curator", "list-archived", "--json"]
|
||||
let (code, stdout, stderr) = await runHermes(args: args, timeout: 30)
|
||||
|
||||
// If --json isn't recognized, the CLI typically emits
|
||||
// "unrecognized arguments: --json" or similar to stderr and
|
||||
// exits non-zero. Retry without the flag and parse text.
|
||||
if code != 0 {
|
||||
let lower = (stderr + stdout).lowercased()
|
||||
if lower.contains("unrecognized") || lower.contains("unknown") || lower.contains("no such option") {
|
||||
let (c2, out2, err2) = await runHermes(args: ["curator", "list-archived"], timeout: 30)
|
||||
try ensureSuccess(code: c2, stdout: out2, stderr: err2, verb: "list-archived")
|
||||
return Self.parseListArchivedText(out2)
|
||||
}
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "list-archived")
|
||||
}
|
||||
|
||||
let trimmed = stdout.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if trimmed.isEmpty || trimmed.lowercased().contains("no archived skills") {
|
||||
return []
|
||||
}
|
||||
// Try JSON first — may also be a text dump if Hermes ignored `--json`.
|
||||
if let data = trimmed.data(using: .utf8),
|
||||
let arr = try? JSONDecoder().decode([HermesCuratorArchivedSkill].self, from: data) {
|
||||
return arr
|
||||
}
|
||||
// Some builds wrap in `{"archived": [...]}` envelope.
|
||||
struct Wrapper: Decodable { let archived: [HermesCuratorArchivedSkill] }
|
||||
if let data = trimmed.data(using: .utf8),
|
||||
let wrapped = try? JSONDecoder().decode(Wrapper.self, from: data) {
|
||||
return wrapped.archived
|
||||
}
|
||||
// Text fallback — defensive parse.
|
||||
return Self.parseListArchivedText(stdout)
|
||||
}
|
||||
|
||||
// MARK: - Writes (legacy v0.12 verbs; service form)
|
||||
|
||||
public func runNow(synchronous: Bool, timeout: TimeInterval) async throws {
|
||||
// TODO(WS-4-Q4): default 600s for v0.13 sync runs. No Cancel
|
||||
// button in v2.8 (transport.cancel parity not guaranteed across
|
||||
// LocalTransport / SSHTransport).
|
||||
let resolvedTimeout = synchronous ? timeout : 30
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "run"], timeout: resolvedTimeout)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "run")
|
||||
}
|
||||
|
||||
public func pause() async throws {
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "pause"], timeout: 15)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "pause")
|
||||
}
|
||||
|
||||
public func resume() async throws {
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "resume"], timeout: 15)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "resume")
|
||||
}
|
||||
|
||||
public func pin(_ name: String) async throws {
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "pin", name], timeout: 15)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "pin")
|
||||
}
|
||||
|
||||
public func unpin(_ name: String) async throws {
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "unpin", name], timeout: 15)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "unpin")
|
||||
}
|
||||
|
||||
public func restore(_ name: String) async throws {
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "restore", name], timeout: 30)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "restore")
|
||||
}
|
||||
|
||||
// MARK: - Writes (new in v0.13)
|
||||
|
||||
/// `hermes curator archive <name>` — non-destructive; moves the
|
||||
/// skill from the active set to the archived set. No `--json` is
|
||||
/// expected; the verb's success channel is the exit code.
|
||||
public func archive(_ name: String) async throws {
|
||||
let (code, stdout, stderr) = await runHermes(args: ["curator", "archive", name], timeout: 30)
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "archive")
|
||||
}
|
||||
|
||||
/// `hermes curator prune [--dry-run]`. Destructive when `dryRun`
|
||||
/// is `false` — removes everything currently archived from disk.
|
||||
/// Returns a `CuratorPruneSummary` describing what was (or would be)
|
||||
/// removed. On `dryRun=false`, the wire shape may not include the
|
||||
/// `would_remove` list — the caller should not depend on it; the
|
||||
/// archived list is empty after a successful destructive prune.
|
||||
@discardableResult
|
||||
public func prune(dryRun: Bool) async throws -> CuratorPruneSummary {
|
||||
// TODO(WS-4-Q1): confirm v0.13 ships `--dry-run`. If not, fall
|
||||
// back to enumerating via `list-archived` and treat any prune
|
||||
// call as destructive. The retry-without-flag path below covers
|
||||
// the "unrecognized argument" case automatically.
|
||||
var args = ["curator", "prune"]
|
||||
if dryRun { args.append("--dry-run") }
|
||||
// `--json` requested for the dry-run path so we can parse the
|
||||
// would-remove list. Destructive mode runs without --json since
|
||||
// we only need the exit code.
|
||||
if dryRun { args.append("--json") }
|
||||
|
||||
let (code, stdout, stderr) = await runHermes(args: args, timeout: 60)
|
||||
|
||||
// Detect "unrecognized --dry-run" / "unknown --json" gracefully.
|
||||
if code != 0 {
|
||||
let lower = (stderr + stdout).lowercased()
|
||||
let unrecognized = lower.contains("unrecognized") || lower.contains("unknown") || lower.contains("no such option")
|
||||
if dryRun && unrecognized {
|
||||
// Q1 fallback: enumerate via list-archived. Caller still
|
||||
// uses this summary for confirm-sheet display.
|
||||
let archived = try await listArchived()
|
||||
let total = archived.compactMap { $0.sizeBytes }.reduce(0, +)
|
||||
return CuratorPruneSummary(wouldRemove: archived, totalBytes: total)
|
||||
}
|
||||
try ensureSuccess(code: code, stdout: stdout, stderr: stderr, verb: "prune")
|
||||
}
|
||||
|
||||
if dryRun {
|
||||
return Self.parsePruneDryRun(stdout)
|
||||
}
|
||||
return CuratorPruneSummary(wouldRemove: [], totalBytes: 0)
|
||||
}
|
||||
|
||||
// MARK: - Pure parsers (nonisolated; safe to call from VMs without awaits)
|
||||
|
||||
/// Parse a `list-archived --json` payload. Tolerates the bare-array
|
||||
/// shape, the `{"archived": [...]}` envelope, and "no archived
|
||||
/// skills" / empty-string sentinels. Returns `[]` for any of the
|
||||
/// empty cases. Throws `CuratorError.decoding` only when the input
|
||||
/// is non-empty and clearly not JSON.
|
||||
public nonisolated static func parseListArchived(stdout: String) throws -> [HermesCuratorArchivedSkill] {
|
||||
let trimmed = stdout.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if trimmed.isEmpty || trimmed.lowercased().contains("no archived skills") {
|
||||
return []
|
||||
}
|
||||
guard let data = trimmed.data(using: .utf8) else {
|
||||
throw CuratorError.decoding(verb: "list-archived", message: "non-UTF8 stdout")
|
||||
}
|
||||
if let arr = try? JSONDecoder().decode([HermesCuratorArchivedSkill].self, from: data) {
|
||||
return arr
|
||||
}
|
||||
struct Wrapper: Decodable { let archived: [HermesCuratorArchivedSkill] }
|
||||
if let wrapped = try? JSONDecoder().decode(Wrapper.self, from: data) {
|
||||
return wrapped.archived
|
||||
}
|
||||
// Last resort: text fallback.
|
||||
let parsed = parseListArchivedText(stdout)
|
||||
if !parsed.isEmpty {
|
||||
return parsed
|
||||
}
|
||||
throw CuratorError.decoding(verb: "list-archived", message: "stdout was neither JSON nor a recognised text list")
|
||||
}
|
||||
|
||||
/// Defensive text parser for `list-archived` output when `--json`
|
||||
/// isn't supported. Format inferred from `curator status`: one row
|
||||
/// per non-blank line, leading whitespace, name in column 1, then
|
||||
/// optional `archived=YYYY-MM-DD`, `size=NNNN`, `reason=...` k/v
|
||||
/// pairs. Blank lines, header lines, and the empty-state sentinel
|
||||
/// are skipped.
|
||||
public nonisolated static func parseListArchivedText(_ text: String) -> [HermesCuratorArchivedSkill] {
|
||||
var rows: [HermesCuratorArchivedSkill] = []
|
||||
for raw in text.split(separator: "\n") {
|
||||
let line = raw.trimmingCharacters(in: .whitespaces)
|
||||
if line.isEmpty { continue }
|
||||
let lower = line.lowercased()
|
||||
// Skip header / sentinel lines.
|
||||
if lower.hasPrefix("name") && lower.contains("archived") { continue }
|
||||
if lower.contains("no archived skills") { continue }
|
||||
if line.unicodeScalars.allSatisfy({ $0.value == 0x2500 || $0.properties.isWhitespace }) {
|
||||
continue
|
||||
}
|
||||
// Skip lines that look like JSON / non-row chrome — `{`,
|
||||
// `}`, `[`, `]` at the start or quotes / colons mean we're
|
||||
// parsing a malformed JSON dump, not a row table.
|
||||
if let first = line.first, "{[}]\":,".contains(first) {
|
||||
continue
|
||||
}
|
||||
// Find the first whitespace-separated token as the name; if
|
||||
// the name carries an `=` it's a header chip we should skip.
|
||||
let parts = line.split(whereSeparator: { $0 == "\t" || $0 == " " }).map(String.init)
|
||||
guard let name = parts.first, !name.contains("=") else { continue }
|
||||
// Reject names that look like punctuation / JSON fragments.
|
||||
if name.contains("\"") || name.contains(":") || name.contains("{") || name.contains("}") || name.contains("[") || name.contains("]") {
|
||||
continue
|
||||
}
|
||||
// Pull k=v pairs from the remainder.
|
||||
var archivedAt: String?
|
||||
var sizeBytes: Int?
|
||||
var reason: String?
|
||||
var category: String?
|
||||
var path: String?
|
||||
for token in parts.dropFirst() {
|
||||
guard let eq = token.firstIndex(of: "=") else { continue }
|
||||
let key = String(token[..<eq])
|
||||
let value = String(token[token.index(after: eq)...])
|
||||
switch key {
|
||||
case "archived", "archived_at":
|
||||
archivedAt = value
|
||||
case "size", "size_bytes":
|
||||
sizeBytes = Int(value)
|
||||
case "reason":
|
||||
reason = value
|
||||
case "category":
|
||||
category = value
|
||||
case "path":
|
||||
path = value
|
||||
default:
|
||||
continue
|
||||
}
|
||||
}
|
||||
rows.append(
|
||||
HermesCuratorArchivedSkill(
|
||||
name: name,
|
||||
category: category,
|
||||
archivedAt: archivedAt,
|
||||
reason: reason,
|
||||
sizeBytes: sizeBytes,
|
||||
path: path
|
||||
)
|
||||
)
|
||||
}
|
||||
return rows
|
||||
}
|
||||
|
||||
/// Parse a `prune --dry-run --json` payload. Tolerates an empty
|
||||
/// payload (returns a zero summary) and the `{would_remove: [],
|
||||
/// total_bytes: N}` shape.
|
||||
public nonisolated static func parsePruneDryRun(_ stdout: String) -> CuratorPruneSummary {
|
||||
let trimmed = stdout.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
guard !trimmed.isEmpty else {
|
||||
return CuratorPruneSummary(wouldRemove: [], totalBytes: 0)
|
||||
}
|
||||
if let data = trimmed.data(using: .utf8),
|
||||
let summary = try? JSONDecoder().decode(CuratorPruneSummary.self, from: data) {
|
||||
return summary
|
||||
}
|
||||
// Tolerate a bare-array fallback (some Hermes builds may print
|
||||
// just the would-remove list when --json is missing the wrapper).
|
||||
if let data = trimmed.data(using: .utf8),
|
||||
let arr = try? JSONDecoder().decode([HermesCuratorArchivedSkill].self, from: data) {
|
||||
let total = arr.compactMap { $0.sizeBytes }.reduce(0, +)
|
||||
return CuratorPruneSummary(wouldRemove: arr, totalBytes: total)
|
||||
}
|
||||
// Last-resort text parse for "would remove N skills (X bytes)".
|
||||
return CuratorPruneSummary(wouldRemove: [], totalBytes: 0)
|
||||
}
|
||||
|
||||
// MARK: - CLI invocation
|
||||
|
||||
private nonisolated func runHermes(
|
||||
args: [String],
|
||||
timeout: TimeInterval
|
||||
) async -> (exitCode: Int32, stdout: String, stderr: String) {
|
||||
let context = self.context
|
||||
return await Task.detached(priority: .utility) { () -> (Int32, String, String) in
|
||||
let result = Self.runHermesSync(context: context, args: args, timeout: timeout)
|
||||
return (result.exitCode, result.output, result.stderr)
|
||||
}.value
|
||||
}
|
||||
|
||||
/// Synchronous, transport-level invocation. `output` is stdout; the
|
||||
/// caller usually only reads `output` for parser input but sometimes
|
||||
/// needs `stderr` (e.g. to detect "unrecognized argument" patterns).
|
||||
private nonisolated static func runHermesSync(
|
||||
context: ServerContext,
|
||||
args: [String],
|
||||
timeout: TimeInterval
|
||||
) -> (exitCode: Int32, output: String, stderr: String) {
|
||||
let transport = context.makeTransport()
|
||||
do {
|
||||
let result = try transport.runProcess(
|
||||
executable: context.paths.hermesBinary,
|
||||
args: args,
|
||||
stdin: nil,
|
||||
timeout: timeout
|
||||
)
|
||||
return (result.exitCode, result.stdoutString, result.stderrString)
|
||||
} catch let error as TransportError {
|
||||
let message = error.diagnosticStderr.isEmpty
|
||||
? (error.errorDescription ?? "transport error")
|
||||
: error.diagnosticStderr
|
||||
return (-1, "", message)
|
||||
} catch {
|
||||
return (-1, "", error.localizedDescription)
|
||||
}
|
||||
}
|
||||
|
||||
private nonisolated func ensureSuccess(
|
||||
code: Int32,
|
||||
stdout: String,
|
||||
stderr: String,
|
||||
verb: String
|
||||
) throws {
|
||||
guard code != 0 else { return }
|
||||
if code == -1 && stderr.lowercased().contains("hermes binary not found") {
|
||||
throw CuratorError.cliMissing
|
||||
}
|
||||
let combined = stderr.isEmpty ? stdout : stderr
|
||||
#if canImport(os)
|
||||
Self.logger.warning("curator \(verb) exit=\(code, privacy: .public) stderr=\(combined, privacy: .public)")
|
||||
#endif
|
||||
throw CuratorError.nonZeroExit(verb: verb, code: code, stderr: combined)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,396 @@
|
||||
import Foundation
|
||||
|
||||
/// Direct YAML editor for `gateway.platforms.<platform>.allowed_<kind>:` list
|
||||
/// blocks. Hermes v0.13 added these list-valued keys, but `hermes config set`
|
||||
/// stringifies arrays (the same gotcha that forced Home Assistant's watch
|
||||
/// lists to stay read-only). The Messaging Gateway editor sidesteps the CLI
|
||||
/// for these keys by editing `~/.hermes/config.yaml` directly.
|
||||
///
|
||||
/// **Pure-function `setList`** is the heart of the editor — it splits the
|
||||
/// YAML into lines, finds (or creates) the targeted block, and splices the
|
||||
/// new items in while preserving every byte outside the block. The async
|
||||
/// `saveList` wrapper wires it through `ServerContext.readText` /
|
||||
/// `writeText`, so the same code path works on `.local` and `.ssh` servers
|
||||
/// — local goes through `LocalTransport`, remote round-trips via SCP.
|
||||
///
|
||||
/// **Scalar fields don't go through here.** `busy_ack_enabled`,
|
||||
/// `gateway_restart_notification`, and `slash_command_notice_ttl_seconds`
|
||||
/// are scalars that `hermes config set` handles cleanly — `GatewayBehaviorViewModel`
|
||||
/// routes those through `PlatformSetupHelpers.saveForm` like every other
|
||||
/// platform toggle.
|
||||
///
|
||||
/// **Why not use a real YAML library?** Same answer as everywhere else in
|
||||
/// Scarf: zero external dependencies. The Hermes config flavor is a tightly
|
||||
/// scoped subset (indent-based blocks, scalar-or-list values, no anchors /
|
||||
/// aliases / flow style), and the targeted edit doesn't need to understand
|
||||
/// the full grammar — only "find this block, replace it, preserve the rest".
|
||||
public enum GatewayConfigWriter {
|
||||
|
||||
/// Insert or replace `gateway.platforms.<platform>.<key>:` block in the
|
||||
/// YAML, preserving everything else byte-for-byte.
|
||||
///
|
||||
/// - When `items` is empty, the block (and only the block — siblings
|
||||
/// stay) is removed from the YAML if present, and the function is a
|
||||
/// no-op if the block was already absent.
|
||||
/// - When the block is absent and `items` is non-empty, the function
|
||||
/// appends a `gateway:` / `platforms:` / `<platform>:` scaffold at
|
||||
/// the end of the file, creating any missing ancestors. This keeps
|
||||
/// the function idempotent on round-trip but means the new block is
|
||||
/// appended rather than spliced into an existing top-level
|
||||
/// `gateway:` section. (See WS-5 plan §Notes for the trade-off; the
|
||||
/// alternative would mean reflowing existing siblings, which is the
|
||||
/// exact opposite of "preserve the surrounding YAML byte-for-byte".)
|
||||
/// - When the block is present, its bullet rows are replaced with the
|
||||
/// new items at the same indent. Items containing YAML-special
|
||||
/// characters (`:` `#` `@` or leading whitespace) are single-quoted
|
||||
/// defensively.
|
||||
public static func setList(
|
||||
in yaml: String,
|
||||
platform: String,
|
||||
key: String,
|
||||
items: [String]
|
||||
) -> String {
|
||||
let blockIndent = 6 // `gateway:\n platforms:\n <platform>:\n <key>:`
|
||||
let itemIndent = 8
|
||||
|
||||
let lines = yaml.components(separatedBy: "\n")
|
||||
let blockHeaderText = " \(key):" // indented match for find()
|
||||
let trimmedItems = items.filter { !$0.trimmingCharacters(in: .whitespaces).isEmpty }
|
||||
|
||||
// Locate ` <key>:` whose lineage is gateway → platforms → <platform>.
|
||||
// We find the start of the gateway block, walk down the indent tree, and
|
||||
// bail out if any ancestor is missing.
|
||||
let location = locateBlock(
|
||||
in: lines,
|
||||
platform: platform,
|
||||
key: key
|
||||
)
|
||||
|
||||
switch location {
|
||||
case .found(let blockRange):
|
||||
return replaceBlock(
|
||||
in: lines,
|
||||
blockRange: blockRange,
|
||||
key: key,
|
||||
items: trimmedItems,
|
||||
blockIndent: blockIndent,
|
||||
itemIndent: itemIndent
|
||||
)
|
||||
case .platformPresentKeyMissing(let insertAfter):
|
||||
if trimmedItems.isEmpty {
|
||||
// No-op: empty target, no existing block.
|
||||
return yaml
|
||||
}
|
||||
return spliceNewKey(
|
||||
lines: lines,
|
||||
insertAfterLineIndex: insertAfter,
|
||||
key: key,
|
||||
items: trimmedItems,
|
||||
itemIndent: itemIndent
|
||||
)
|
||||
case .ancestorMissing:
|
||||
if trimmedItems.isEmpty {
|
||||
// Nothing to write, no existing block.
|
||||
return yaml
|
||||
}
|
||||
return appendScaffold(
|
||||
yaml: yaml,
|
||||
platform: platform,
|
||||
key: key,
|
||||
items: trimmedItems
|
||||
)
|
||||
}
|
||||
|
||||
// (unreachable — switch is exhaustive)
|
||||
_ = blockHeaderText
|
||||
}
|
||||
|
||||
/// Async wrapper that reads, mutates, writes via the given context.
|
||||
/// Returns `false` on read or write failure.
|
||||
///
|
||||
/// The actual I/O happens via `ServerContext.readText` / `writeText`,
|
||||
/// which are `nonisolated` — safe to call from `MainActor` for the
|
||||
/// short config.yaml writes the platform setup forms run. For remote
|
||||
/// hosts the call rounds through SCP under `Task.detached` upstream
|
||||
/// (per Swift 6 concurrency rules in `~/.claude/CLAUDE.md`).
|
||||
public static func saveList(
|
||||
context: ServerContext,
|
||||
platform: String,
|
||||
key: String,
|
||||
items: [String]
|
||||
) -> Bool {
|
||||
let path = context.paths.configYAML
|
||||
let existing = context.readText(path) ?? ""
|
||||
let updated = setList(in: existing, platform: platform, key: key, items: items)
|
||||
if updated == existing { return true } // no-op: already correct
|
||||
return context.writeText(path, content: updated)
|
||||
}
|
||||
|
||||
// MARK: - Internals
|
||||
|
||||
/// Result of locating the targeted block in the YAML line array.
|
||||
private enum BlockLocation {
|
||||
/// Block found; the closed range covers the header line + all bullet
|
||||
/// rows attributed to it. Replacing this slice with the new block
|
||||
/// completes the edit.
|
||||
case found(ClosedRange<Int>)
|
||||
/// `gateway → platforms → <platform>` exists, but the leaf `<key>:`
|
||||
/// is absent under it. The associated value is the line index after
|
||||
/// which the new key should be inserted (last line in the platform's
|
||||
/// block, or the platform header itself if the platform's body is
|
||||
/// empty).
|
||||
case platformPresentKeyMissing(insertAfter: Int)
|
||||
/// One of the ancestor section headers is missing. The whole
|
||||
/// scaffold needs to be appended.
|
||||
case ancestorMissing
|
||||
}
|
||||
|
||||
private static func locateBlock(
|
||||
in lines: [String],
|
||||
platform: String,
|
||||
key: String
|
||||
) -> BlockLocation {
|
||||
// Walk top-to-bottom looking for `gateway:` at indent 0.
|
||||
guard let gatewayIdx = firstIndex(of: lines, headerLineEqualTo: "gateway:", indent: 0) else {
|
||||
return .ancestorMissing
|
||||
}
|
||||
// Inside `gateway:`, find ` platforms:` at indent 2.
|
||||
guard let platformsIdx = firstIndex(
|
||||
of: lines,
|
||||
after: gatewayIdx,
|
||||
headerLineEqualTo: "platforms:",
|
||||
indent: 2,
|
||||
stopWhenIndentLessThan: 2
|
||||
) else {
|
||||
return .ancestorMissing
|
||||
}
|
||||
// Inside `platforms:`, find ` <platform>:` at indent 4.
|
||||
guard let platformIdx = firstIndex(
|
||||
of: lines,
|
||||
after: platformsIdx,
|
||||
headerLineEqualTo: "\(platform):",
|
||||
indent: 4,
|
||||
stopWhenIndentLessThan: 4
|
||||
) else {
|
||||
return .ancestorMissing
|
||||
}
|
||||
|
||||
// Inside the platform block, find `<key>:` at indent 6, OR the end
|
||||
// of the platform's body if the key is missing.
|
||||
var keyIdx: Int?
|
||||
var lastBodyIdx = platformIdx
|
||||
var i = platformIdx + 1
|
||||
while i < lines.count {
|
||||
let line = lines[i]
|
||||
let indent = leadingSpaces(line)
|
||||
let trimmed = line.trimmingCharacters(in: .whitespaces)
|
||||
if trimmed.isEmpty || trimmed.hasPrefix("#") {
|
||||
i += 1
|
||||
continue
|
||||
}
|
||||
if indent < 6 {
|
||||
// Out of the platform's block.
|
||||
break
|
||||
}
|
||||
if indent == 6 && trimmed == "\(key):" {
|
||||
keyIdx = i
|
||||
break
|
||||
}
|
||||
lastBodyIdx = i
|
||||
i += 1
|
||||
}
|
||||
|
||||
guard let keyIdx else {
|
||||
return .platformPresentKeyMissing(insertAfter: lastBodyIdx)
|
||||
}
|
||||
|
||||
// Walk down the bullet rows until we leave the block (indent shrinks
|
||||
// below the bullet indent OR we hit a sibling key at indent 6).
|
||||
var endIdx = keyIdx
|
||||
var j = keyIdx + 1
|
||||
while j < lines.count {
|
||||
let line = lines[j]
|
||||
let trimmed = line.trimmingCharacters(in: .whitespaces)
|
||||
if trimmed.isEmpty || trimmed.hasPrefix("#") {
|
||||
j += 1
|
||||
continue
|
||||
}
|
||||
let indent = leadingSpaces(line)
|
||||
// Block-style YAML allows bullets at the same indent as their
|
||||
// parent key; tolerate 6-space `- item` rows alongside the
|
||||
// canonical 8-space ones.
|
||||
let isBullet = trimmed.hasPrefix("- ")
|
||||
if isBullet && (indent == 8 || indent == 6) {
|
||||
endIdx = j
|
||||
j += 1
|
||||
continue
|
||||
}
|
||||
// Anything not a bullet at indent ≥ 8 ends the block.
|
||||
if indent <= 6 {
|
||||
break
|
||||
}
|
||||
// Indent > 8 with no bullet — unusual but tolerate (e.g. inline
|
||||
// continuation). Treat as still in the block and advance.
|
||||
endIdx = j
|
||||
j += 1
|
||||
}
|
||||
|
||||
return .found(keyIdx...endIdx)
|
||||
}
|
||||
|
||||
private static func replaceBlock(
|
||||
in lines: [String],
|
||||
blockRange: ClosedRange<Int>,
|
||||
key: String,
|
||||
items: [String],
|
||||
blockIndent: Int,
|
||||
itemIndent: Int
|
||||
) -> String {
|
||||
var newLines = Array(lines.prefix(blockRange.lowerBound))
|
||||
if !items.isEmpty {
|
||||
newLines.append("\(spaces(blockIndent))\(key):")
|
||||
for item in items {
|
||||
newLines.append("\(spaces(itemIndent))- \(yamlQuoteIfNeeded(item))")
|
||||
}
|
||||
}
|
||||
// Drop the old block but keep everything after it.
|
||||
let tailStart = blockRange.upperBound + 1
|
||||
if tailStart < lines.count {
|
||||
newLines.append(contentsOf: lines.suffix(from: tailStart))
|
||||
}
|
||||
return newLines.joined(separator: "\n")
|
||||
}
|
||||
|
||||
private static func spliceNewKey(
|
||||
lines: [String],
|
||||
insertAfterLineIndex: Int,
|
||||
key: String,
|
||||
items: [String],
|
||||
itemIndent: Int
|
||||
) -> String {
|
||||
var newLines = Array(lines.prefix(insertAfterLineIndex + 1))
|
||||
newLines.append(" \(key):")
|
||||
for item in items {
|
||||
newLines.append("\(spaces(itemIndent))- \(yamlQuoteIfNeeded(item))")
|
||||
}
|
||||
if insertAfterLineIndex + 1 < lines.count {
|
||||
newLines.append(contentsOf: lines.suffix(from: insertAfterLineIndex + 1))
|
||||
}
|
||||
return newLines.joined(separator: "\n")
|
||||
}
|
||||
|
||||
private static func appendScaffold(
|
||||
yaml: String,
|
||||
platform: String,
|
||||
key: String,
|
||||
items: [String]
|
||||
) -> String {
|
||||
var trimmed = yaml
|
||||
// Ensure exactly one trailing newline before the appended block,
|
||||
// so the scaffold sits on its own line cleanly.
|
||||
while trimmed.hasSuffix("\n\n") {
|
||||
trimmed.removeLast()
|
||||
}
|
||||
if !trimmed.isEmpty && !trimmed.hasSuffix("\n") {
|
||||
trimmed.append("\n")
|
||||
}
|
||||
var lines: [String] = []
|
||||
if !trimmed.isEmpty {
|
||||
lines.append("") // blank separator
|
||||
}
|
||||
lines.append("gateway:")
|
||||
lines.append(" platforms:")
|
||||
lines.append(" \(platform):")
|
||||
lines.append(" \(key):")
|
||||
for item in items {
|
||||
lines.append(" - \(yamlQuoteIfNeeded(item))")
|
||||
}
|
||||
lines.append("") // trailing newline so subsequent edits append cleanly
|
||||
return trimmed + lines.joined(separator: "\n")
|
||||
}
|
||||
|
||||
// MARK: - YAML scanning helpers
|
||||
|
||||
private static func leadingSpaces(_ line: String) -> Int {
|
||||
var n = 0
|
||||
for c in line {
|
||||
if c == " " { n += 1 } else { break }
|
||||
}
|
||||
return n
|
||||
}
|
||||
|
||||
/// Find the first line whose trimmed content equals `header` AND whose
|
||||
/// leading-space count equals `indent`. Comment-only and blank lines
|
||||
/// are skipped. Returns the line's index or `nil`.
|
||||
private static func firstIndex(
|
||||
of lines: [String],
|
||||
headerLineEqualTo header: String,
|
||||
indent: Int
|
||||
) -> Int? {
|
||||
for (i, line) in lines.enumerated() {
|
||||
let trimmed = line.trimmingCharacters(in: .whitespaces)
|
||||
if trimmed.isEmpty || trimmed.hasPrefix("#") { continue }
|
||||
if leadingSpaces(line) == indent && trimmed == header {
|
||||
return i
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
/// Scoped variant: search starts at `after + 1`, stops if a line at indent
|
||||
/// `< stopWhenIndentLessThan` is encountered (we've left the parent block).
|
||||
private static func firstIndex(
|
||||
of lines: [String],
|
||||
after: Int,
|
||||
headerLineEqualTo header: String,
|
||||
indent: Int,
|
||||
stopWhenIndentLessThan: Int
|
||||
) -> Int? {
|
||||
var i = after + 1
|
||||
while i < lines.count {
|
||||
let line = lines[i]
|
||||
let trimmed = line.trimmingCharacters(in: .whitespaces)
|
||||
if trimmed.isEmpty || trimmed.hasPrefix("#") {
|
||||
i += 1
|
||||
continue
|
||||
}
|
||||
let lineIndent = leadingSpaces(line)
|
||||
if lineIndent < stopWhenIndentLessThan {
|
||||
return nil
|
||||
}
|
||||
if lineIndent == indent && trimmed == header {
|
||||
return i
|
||||
}
|
||||
i += 1
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
private static func spaces(_ n: Int) -> String {
|
||||
String(repeating: " ", count: n)
|
||||
}
|
||||
|
||||
/// Quote a YAML scalar if it contains characters that the parser would
|
||||
/// otherwise interpret as structure (colon, hash, leading at-sign, etc.).
|
||||
/// Plain alphanumeric IDs (the common case for Slack channel IDs and
|
||||
/// Telegram numeric chat IDs) are emitted unquoted.
|
||||
private static func yamlQuoteIfNeeded(_ raw: String) -> String {
|
||||
if raw.isEmpty { return "''" }
|
||||
let needsQuoting = raw.contains(":")
|
||||
|| raw.contains("#")
|
||||
|| raw.contains("&")
|
||||
|| raw.contains("*")
|
||||
|| raw.contains(">")
|
||||
|| raw.contains("|")
|
||||
|| raw.first == "@"
|
||||
|| raw.first == "-"
|
||||
|| raw.first == " "
|
||||
|| raw.last == " "
|
||||
|| raw.first == "\""
|
||||
|| raw.first == "'"
|
||||
if !needsQuoting { return raw }
|
||||
// Single-quote, escaping any embedded single quotes by doubling.
|
||||
let escaped = raw.replacingOccurrences(of: "'", with: "''")
|
||||
return "'\(escaped)'"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,151 @@
|
||||
import Foundation
|
||||
|
||||
/// Cross-profile snapshot returned by `hermes gateway list --json` (Hermes
|
||||
/// v0.13+). Each profile is one configured Messaging Gateway instance — most
|
||||
/// users have a single `default` profile, but power users keep separate
|
||||
/// profiles for work / personal / project-specific accounts.
|
||||
public struct GatewayListSnapshot: Sendable, Equatable {
|
||||
public struct ProfileEntry: Sendable, Equatable {
|
||||
public let profile: String
|
||||
public let isRunning: Bool
|
||||
public let pid: Int?
|
||||
public let platforms: [String] // platform names connected/configured
|
||||
|
||||
public init(
|
||||
profile: String,
|
||||
isRunning: Bool,
|
||||
pid: Int?,
|
||||
platforms: [String]
|
||||
) {
|
||||
self.profile = profile
|
||||
self.isRunning = isRunning
|
||||
self.pid = pid
|
||||
self.platforms = platforms
|
||||
}
|
||||
}
|
||||
public let profiles: [ProfileEntry]
|
||||
public let detectedAt: Date
|
||||
|
||||
public init(profiles: [ProfileEntry], detectedAt: Date = Date()) {
|
||||
self.profiles = profiles
|
||||
self.detectedAt = detectedAt
|
||||
}
|
||||
|
||||
/// One-line digest for the Messaging Gateway page header. Format depends
|
||||
/// on shape:
|
||||
/// - 0 profiles: `"no profiles configured"`
|
||||
/// - 1 profile, running: `"default profile · running · slack, telegram"`
|
||||
/// - 1 profile, stopped: `"default profile · stopped"`
|
||||
/// - >1 profile: `"3 profiles (2 running) · default: slack, telegram"`
|
||||
public var headerDigest: String {
|
||||
if profiles.isEmpty { return "no profiles configured" }
|
||||
|
||||
if profiles.count == 1 {
|
||||
let p = profiles[0]
|
||||
let state = p.isRunning ? "running" : "stopped"
|
||||
if p.isRunning && !p.platforms.isEmpty {
|
||||
let plats = p.platforms.joined(separator: ", ")
|
||||
return "\(p.profile) profile · \(state) · \(plats)"
|
||||
}
|
||||
return "\(p.profile) profile · \(state)"
|
||||
}
|
||||
|
||||
let runningCount = profiles.filter(\.isRunning).count
|
||||
// Surface the platforms of the first running profile (or first profile
|
||||
// if none are running) so the digest carries one specimen of context
|
||||
// beyond just counts.
|
||||
let highlight = profiles.first(where: \.isRunning) ?? profiles[0]
|
||||
let platsClause: String
|
||||
if highlight.platforms.isEmpty {
|
||||
platsClause = ""
|
||||
} else {
|
||||
platsClause = " · \(highlight.profile): \(highlight.platforms.joined(separator: ", "))"
|
||||
}
|
||||
return "\(profiles.count) profiles (\(runningCount) running)\(platsClause)"
|
||||
}
|
||||
}
|
||||
|
||||
/// Pure parser + sync fetcher for `hermes gateway list --json`. Pre-v0.13
|
||||
/// hosts exit non-zero on the unknown subcommand; the fetcher returns `nil`
|
||||
/// in that case so the digest row hides itself.
|
||||
///
|
||||
/// The detection is **synchronous** — run from a `Task.detached` to avoid
|
||||
/// blocking MainActor on remote SSH round-trips. The pure `parse(_:)`
|
||||
/// helper has no I/O and can be used in tests against canned JSON.
|
||||
public enum HermesGatewayListService {
|
||||
|
||||
/// Parse a JSON blob from `hermes gateway list --json` into a snapshot.
|
||||
/// Tolerant of unknown keys; returns `nil` for unparseable / empty input.
|
||||
///
|
||||
/// // TODO(WS-5-Q3): the JSON shape below is the plan's best-guess.
|
||||
/// Confirm against actual Hermes v0.13 output once available. Possible
|
||||
/// alternative shapes:
|
||||
/// - root array of profile objects (no `profiles` wrapper)
|
||||
/// - `state` enum string instead of `running` bool
|
||||
/// - `connected_platforms` instead of `platforms`
|
||||
/// The parser is intentionally tolerant so a small shape change can be
|
||||
/// absorbed by tweaking field names without breaking older fixtures.
|
||||
public static func parse(_ json: Data) -> GatewayListSnapshot? {
|
||||
guard !json.isEmpty,
|
||||
let raw = try? JSONSerialization.jsonObject(with: json) else {
|
||||
return nil
|
||||
}
|
||||
|
||||
// Accept both `{"profiles": [...]}` and a bare `[...]` of profiles.
|
||||
let profilesArray: [Any]
|
||||
if let dict = raw as? [String: Any], let arr = dict["profiles"] as? [Any] {
|
||||
profilesArray = arr
|
||||
} else if let arr = raw as? [Any] {
|
||||
profilesArray = arr
|
||||
} else {
|
||||
return nil
|
||||
}
|
||||
|
||||
var entries: [GatewayListSnapshot.ProfileEntry] = []
|
||||
for raw in profilesArray {
|
||||
guard let obj = raw as? [String: Any] else { continue }
|
||||
let profile = (obj["name"] as? String)
|
||||
?? (obj["profile"] as? String)
|
||||
?? "default"
|
||||
let isRunning: Bool
|
||||
if let v = obj["running"] as? Bool {
|
||||
isRunning = v
|
||||
} else if let s = obj["state"] as? String {
|
||||
isRunning = s.lowercased() == "running"
|
||||
} else {
|
||||
isRunning = false
|
||||
}
|
||||
let pid = obj["pid"] as? Int
|
||||
let platforms = (obj["platforms"] as? [String])
|
||||
?? (obj["connected_platforms"] as? [String])
|
||||
?? []
|
||||
entries.append(GatewayListSnapshot.ProfileEntry(
|
||||
profile: profile,
|
||||
isRunning: isRunning,
|
||||
pid: pid,
|
||||
platforms: platforms
|
||||
))
|
||||
}
|
||||
return GatewayListSnapshot(profiles: entries)
|
||||
}
|
||||
|
||||
/// Synchronous fetch helper — call from a `Task.detached`. Returns
|
||||
/// `nil` when the subcommand fails (pre-v0.13 host) or when the
|
||||
/// output isn't parseable.
|
||||
public static func fetch(context: ServerContext) -> GatewayListSnapshot? {
|
||||
let transport = context.makeTransport()
|
||||
let executable = context.paths.hermesBinary
|
||||
do {
|
||||
let result = try transport.runProcess(
|
||||
executable: executable,
|
||||
args: ["gateway", "list", "--json"],
|
||||
stdin: nil,
|
||||
timeout: 10
|
||||
)
|
||||
guard result.exitCode == 0 else { return nil }
|
||||
return parse(result.stdout)
|
||||
} catch {
|
||||
return nil
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -321,6 +321,61 @@ public actor KanbanService {
|
||||
try ensureSuccess(code: code, stdout: "", stderr: stderr, verb: "unlink")
|
||||
}
|
||||
|
||||
// MARK: - Hallucination gate (v0.13)
|
||||
|
||||
/// Mark a worker-created card as user-verified — flips
|
||||
/// `hallucination_gate_status` from `pending` to `verified` so the
|
||||
/// dispatcher can pick it up. The polling loop picks up the new
|
||||
/// state on the next tick (and the VM optimistically clears the
|
||||
/// pending banner immediately on the click).
|
||||
///
|
||||
/// **Pre-v0.13 hosts:** the verb doesn't exist; callers MUST gate
|
||||
/// on `HermesCapabilities.hasKanbanDiagnostics` before invoking this.
|
||||
/// A pre-v0.13 binary will surface the failure as
|
||||
/// `KanbanError.nonZeroExit` with stderr containing "unknown command".
|
||||
// TODO(WS-3-Q1): Confirm the exact CLI verb name for the
|
||||
// hallucination-gate verify path against a v0.13 binary (`hermes
|
||||
// kanban --help`). The v0.13 release notes describe "hallucination
|
||||
// gate + recovery UX" but don't enumerate the verb name. This
|
||||
// implementation assumes `hermes kanban verify <id>`. If Hermes ships
|
||||
// it as `hermes kanban gate verify <id>`, `hermes kanban hallucination
|
||||
// verify <id>`, or another name, update the args here. The Reject
|
||||
// path does NOT depend on this verb (it routes through
|
||||
// `archive` + a comment), so the recovery UX stays functional even
|
||||
// if Verify is a stub for an early v0.13.x.
|
||||
public func verify(taskId: String) async throws {
|
||||
let args = ["kanban", "verify", taskId]
|
||||
let (code, _, stderr) = await runHermes(args: args, timeout: 15)
|
||||
try ensureSuccess(code: code, stdout: "", stderr: stderr, verb: "verify")
|
||||
}
|
||||
|
||||
/// Reject a worker-created card as a hallucinated reference. There
|
||||
/// is no dedicated `kanban reject` verb in v0.13; the right action
|
||||
/// per the v0.13 release notes is to archive the card (the work
|
||||
/// doesn't exist) with a comment recording the rejection reason for
|
||||
/// the audit trail. Routing this through the existing `comment` +
|
||||
/// `archive` verbs keeps the wire shape stable across versions.
|
||||
///
|
||||
/// If a future Hermes adds a dedicated `kanban reject` verb, swap
|
||||
/// the body here — the public surface stays "reject" returning Void.
|
||||
public func rejectHallucinated(taskId: String) async throws {
|
||||
// Best-effort comment first so the audit trail records the
|
||||
// rejection. A failure here shouldn't block the archive — log
|
||||
// and continue.
|
||||
do {
|
||||
try await comment(
|
||||
taskId: taskId,
|
||||
text: "Rejected as hallucinated (no underlying work).",
|
||||
author: nil
|
||||
)
|
||||
} catch {
|
||||
#if canImport(os)
|
||||
Self.logger.warning("kanban reject: comment failed, proceeding to archive (\(error.localizedDescription, privacy: .public))")
|
||||
#endif
|
||||
}
|
||||
try await archive(taskIds: [taskId])
|
||||
}
|
||||
|
||||
// MARK: - Drag-drop transition mapper
|
||||
|
||||
/// Map a board-level column transition to the right Hermes verb call.
|
||||
|
||||
@@ -155,9 +155,20 @@ public struct ModelCatalogService: Sendable {
|
||||
)
|
||||
}
|
||||
return byID.values.sorted { lhs, rhs in
|
||||
// Subscription-gated first (Nous Portal).
|
||||
if lhs.subscriptionGated != rhs.subscriptionGated {
|
||||
return lhs.subscriptionGated
|
||||
}
|
||||
// Demoted last (Vercel AI Gateway, per Hermes v0.13). The
|
||||
// axis is unconditional — we don't gate on the Hermes
|
||||
// version because "Vercel mid-alphabet on v0.12, bottom on
|
||||
// v0.13" would be more confusing than the consistent
|
||||
// "Vercel last" treatment for everyone.
|
||||
let lDemoted = Self.demotedProviders.contains(lhs.providerID)
|
||||
let rDemoted = Self.demotedProviders.contains(rhs.providerID)
|
||||
if lDemoted != rDemoted {
|
||||
return !lDemoted
|
||||
}
|
||||
return lhs.providerName.localizedCaseInsensitiveCompare(rhs.providerName) == .orderedAscending
|
||||
}
|
||||
}
|
||||
@@ -235,7 +246,10 @@ public struct ModelCatalogService: Sendable {
|
||||
public func provider(for modelID: String) -> HermesProviderInfo? {
|
||||
guard let catalog = loadCatalog() else { return nil }
|
||||
for (providerID, p) in catalog {
|
||||
if p.models?[modelID] != nil {
|
||||
// Resolve any model-rename alias for this provider before
|
||||
// checking the catalog — see `modelAliases` for rationale.
|
||||
let resolved = resolveModelAlias(providerID: providerID, modelID: modelID)
|
||||
if p.models?[resolved] != nil {
|
||||
return HermesProviderInfo(
|
||||
providerID: providerID,
|
||||
providerName: p.name ?? providerID,
|
||||
@@ -299,14 +313,17 @@ public struct ModelCatalogService: Sendable {
|
||||
/// Look up a specific model by provider + ID. Returns nil if not in the
|
||||
/// catalog (e.g., free-typed custom model).
|
||||
public func model(providerID: String, modelID: String) -> HermesModelInfo? {
|
||||
// Resolve any model-rename alias for this provider before
|
||||
// checking the catalog — see `modelAliases` for rationale.
|
||||
let resolved = resolveModelAlias(providerID: providerID, modelID: modelID)
|
||||
guard let catalog = loadCatalog(),
|
||||
let provider = catalog[providerID],
|
||||
let raw = provider.models?[modelID] else { return nil }
|
||||
let raw = provider.models?[resolved] else { return nil }
|
||||
return HermesModelInfo(
|
||||
providerID: providerID,
|
||||
providerName: provider.name ?? providerID,
|
||||
modelID: modelID,
|
||||
modelName: raw.name ?? modelID,
|
||||
modelID: resolved,
|
||||
modelName: raw.name ?? resolved,
|
||||
contextWindow: raw.limit?.context,
|
||||
maxOutput: raw.limit?.output,
|
||||
costInput: raw.cost?.input,
|
||||
@@ -344,10 +361,14 @@ public struct ModelCatalogService: Sendable {
|
||||
/// HTTP 404 at runtime. Catch that at save time, not 6 hours later.
|
||||
public func validateModel(_ modelID: String, for providerID: String) -> ModelValidation {
|
||||
ScarfMon.measure(.diskIO, "modelCatalog.validateModel") {
|
||||
let trimmed = modelID.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
guard !trimmed.isEmpty else {
|
||||
let raw = modelID.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
guard !raw.isEmpty else {
|
||||
return .invalid(providerName: providerID, suggestions: [])
|
||||
}
|
||||
// Resolve any model-rename alias before lookup so configs
|
||||
// referencing a deprecated ID (e.g. `x-ai/grok-4.20-beta`)
|
||||
// validate against the canonical successor.
|
||||
let trimmed = resolveModelAlias(providerID: providerID, modelID: raw)
|
||||
|
||||
// Overlay-only providers (Nous Portal, OpenAI Codex, Qwen
|
||||
// OAuth, …) serve their own catalogs that aren't mirrored to
|
||||
@@ -433,6 +454,78 @@ public struct ModelCatalogService: Sendable {
|
||||
let output: Int?
|
||||
}
|
||||
|
||||
// MARK: - Model aliases (model rename resolution)
|
||||
|
||||
/// Hermes deprecates model IDs across releases. When a stored config
|
||||
/// `model.default` references a deprecated ID, resolve to its
|
||||
/// canonical successor. Lossless — we never rewrite the user's
|
||||
/// `config.yaml`; the alias just lets `validateModel` /
|
||||
/// `model(providerID:modelID:)` / `provider(for:)` succeed against
|
||||
/// the new ID.
|
||||
///
|
||||
/// Keys are slash-joined `providerID/modelID` to disambiguate
|
||||
/// across providers — even if `vercel` later adds a `grok-4.20-beta`
|
||||
/// alias on its own, the openrouter resolution shouldn't fire.
|
||||
/// Values are the bare resolved model ID (no provider prefix).
|
||||
///
|
||||
/// **Schema is Swift-primary.** Mirror new entries into Hermes's
|
||||
/// upstream deprecation map in `hermes_cli/providers.py` if/when
|
||||
/// upstream tracks renames in code (today they're release-notes
|
||||
/// only).
|
||||
public static let modelAliases: [String: String] = [
|
||||
// v0.13: x-ai dropped the `-beta` suffix once Grok 4.20 GA'd.
|
||||
// The model is the same one served at the same OpenRouter slot;
|
||||
// only the marketing identifier changed.
|
||||
// TODO(WS-6-Q4): verify whether OpenRouter retired the
|
||||
// `x-ai/grok-4.20-beta` slot entirely. Either way the alias is
|
||||
// correct (cosmetic if old slot stays live, load-bearing if it
|
||||
// 404s).
|
||||
"openrouter/x-ai/grok-4.20-beta": "x-ai/grok-4.20",
|
||||
"xai/grok-4.20-beta": "grok-4.20",
|
||||
"vercel/xai/grok-4.20-beta": "xai/grok-4.20",
|
||||
]
|
||||
|
||||
/// Resolve a stored model identifier through the alias map. Returns
|
||||
/// the input unchanged when no alias exists. Pure function — used at
|
||||
/// read time everywhere a config'd model ID is rendered, validated,
|
||||
/// or sent to Hermes.
|
||||
public func resolveModelAlias(providerID: String, modelID: String) -> String {
|
||||
let composite = "\(providerID)/\(modelID)"
|
||||
return Self.modelAliases[composite] ?? modelID
|
||||
}
|
||||
|
||||
// MARK: - Demoted providers (sort tail)
|
||||
|
||||
/// Provider IDs that Hermes v0.13 explicitly deprioritizes in the
|
||||
/// picker. `loadProviders()` sorts these to the tail of the list,
|
||||
/// after the alphabetical group, so users who haven't manually
|
||||
/// chosen Vercel as their gateway don't end up there by default.
|
||||
/// Mirrors Hermes's deprioritized-provider list in
|
||||
/// `hermes-agent/hermes_cli/providers.py`.
|
||||
public static let demotedProviders: Set<String> = [
|
||||
"vercel",
|
||||
]
|
||||
|
||||
// MARK: - Image-generation model allowlist (curated)
|
||||
|
||||
/// Known image-generation models, used to pre-populate the
|
||||
/// `image_gen.model` picker on the Auxiliary tab. The list is
|
||||
/// curated — `models_dev_cache.json` doesn't tag image-capable
|
||||
/// models, so we maintain this by hand on Hermes version bumps.
|
||||
/// Always free-form-typeable on the picker too, so missing entries
|
||||
/// don't block users with non-listed image providers.
|
||||
///
|
||||
/// Order: most-likely-to-be-chosen first.
|
||||
public static let imageGenModels: [HermesImageGenModel] = [
|
||||
.init(modelID: "openai/gpt-image-1", display: "OpenAI · gpt-image-1", providerHint: "openai"),
|
||||
.init(modelID: "google/imagen-4", display: "Google · Imagen 4", providerHint: "google-vertex"),
|
||||
.init(modelID: "google/imagen-3", display: "Google · Imagen 3", providerHint: "google-vertex"),
|
||||
.init(modelID: "stability/stable-image-ultra", display: "Stability · Stable Image Ultra", providerHint: "stability"),
|
||||
.init(modelID: "fal-ai/flux-pro-1.1", display: "fal · FLUX 1.1 Pro", providerHint: "fal"),
|
||||
.init(modelID: "black-forest-labs/flux-1.1-pro", display: "Black Forest Labs · FLUX 1.1 Pro", providerHint: "openrouter"),
|
||||
.init(modelID: "openai/dall-e-3", display: "OpenAI · DALL·E 3", providerHint: "openai"),
|
||||
]
|
||||
|
||||
// MARK: - Hermes overlay providers
|
||||
|
||||
/// The 11 providers Hermes surfaces via `hermes model` that have no
|
||||
@@ -538,6 +631,27 @@ public struct ModelCatalogService: Sendable {
|
||||
]
|
||||
}
|
||||
|
||||
/// Curated entry for the `image_gen.model` picker on the Auxiliary
|
||||
/// tab. Hermes v0.13 honors a top-level `image_gen.model` key but the
|
||||
/// models.dev catalog has no `image: true` tag, so we maintain a
|
||||
/// short hand-curated allowlist keyed by display order. The picker
|
||||
/// always allows free-form-typing too, so any provider's model ID
|
||||
/// works regardless of whether it appears here.
|
||||
public struct HermesImageGenModel: Sendable, Identifiable, Hashable {
|
||||
public let modelID: String
|
||||
public let display: String
|
||||
/// Hint at which provider serves this model — surfaced as a
|
||||
/// "Configure provider X first" advisory but never enforced.
|
||||
public let providerHint: String?
|
||||
public var id: String { modelID }
|
||||
|
||||
public init(modelID: String, display: String, providerHint: String?) {
|
||||
self.modelID = modelID
|
||||
self.display = display
|
||||
self.providerHint = providerHint
|
||||
}
|
||||
}
|
||||
|
||||
/// Scarf-side mirror of `HermesOverlay` from hermes-agent's
|
||||
/// `hermes_cli/providers.py`. Describes a provider that isn't in the
|
||||
/// models.dev catalog.
|
||||
|
||||
@@ -4,17 +4,19 @@ import Observation
|
||||
import os
|
||||
#endif
|
||||
|
||||
/// Mac + iOS view model for the v0.12 Curator surface.
|
||||
/// Mac + iOS view model for the Curator surface (v0.12 base + v0.13
|
||||
/// archive/prune additions).
|
||||
///
|
||||
/// Drives `hermes curator status / run / pause / resume / pin / unpin /
|
||||
/// restore` plus a parsed view of `~/.hermes/skills/.curator_state`
|
||||
/// JSON. The CLI doesn't ship a `--json` flag for `status`, so we
|
||||
/// text-parse stdout (HermesCuratorStatusParser) and use the state
|
||||
/// file for richer last-run metadata.
|
||||
/// restore` plus (v0.13+) `archive`, `prune`, `list-archived`. All CLI
|
||||
/// invocations route through `CuratorService` (the actor) so polling
|
||||
/// and writes share the same concurrency model and a single error path.
|
||||
///
|
||||
/// Capability-gated: callers should construct this only when
|
||||
/// `HermesCapabilities.hasCurator` is true. The view model does not
|
||||
/// gate itself — the gate happens at sidebar/tab routing time.
|
||||
/// `HermesCapabilities.hasCurator` is true. Archive-aware UI surfaces
|
||||
/// (Archive button, Archived section, Prune…) gate independently on
|
||||
/// `hasCuratorArchive`. The view model itself doesn't gate — it exposes
|
||||
/// every method and the View decides what to render.
|
||||
@Observable
|
||||
@MainActor
|
||||
public final class CuratorViewModel {
|
||||
@@ -27,20 +29,50 @@ public final class CuratorViewModel {
|
||||
public private(set) var status: HermesCuratorStatus = .empty
|
||||
public private(set) var isLoading = false
|
||||
public private(set) var lastReportMarkdown: String?
|
||||
|
||||
// Archive state (v0.13+ only — populated by `loadArchive()` on hosts
|
||||
// where `hasCuratorArchive` is true).
|
||||
public private(set) var archivedSkills: [HermesCuratorArchivedSkill] = []
|
||||
public private(set) var isLoadingArchive = false
|
||||
|
||||
// Prune state — `pruneSummary` non-nil while the confirm sheet is
|
||||
// mid-flight; `isPruning` flips during the destructive step.
|
||||
public private(set) var pruneSummary: CuratorPruneSummary?
|
||||
public private(set) var isPruning = false
|
||||
|
||||
// Track which active-skill row is currently being archived so the
|
||||
// row chrome can show an inline spinner without blocking the rest.
|
||||
public private(set) var pendingArchiveName: String?
|
||||
|
||||
/// Happy-path success toast ("Pinned X", "Resumed", "Archived
|
||||
/// legacy-helper"). Auto-clears 3s after assignment.
|
||||
public var transientMessage: String?
|
||||
|
||||
/// Failure path — populated by every CLI verb when it throws. Shown
|
||||
/// as an inline yellow banner above the status summary so users
|
||||
/// don't have to dismiss a modal alert during a high-frequency
|
||||
/// surface like the leaderboard. Manually dismissed via the View's
|
||||
/// "x" button (sets to nil).
|
||||
public var errorMessage: String?
|
||||
|
||||
@ObservationIgnored
|
||||
private let service: CuratorService
|
||||
|
||||
public init(context: ServerContext) {
|
||||
self.context = context
|
||||
self.service = CuratorService(context: context)
|
||||
}
|
||||
|
||||
// MARK: - Loads
|
||||
|
||||
public func load() async {
|
||||
isLoading = true
|
||||
defer { isLoading = false }
|
||||
let context = self.context
|
||||
// v2.8 — instrumented. Curator load fires `hermes curator
|
||||
// status` (CLI subprocess) plus 1-2 file reads; on remote
|
||||
// each is a separate SSH RTT. Visibility lets future captures
|
||||
// show how often the report file is missing or oversized.
|
||||
// status` (CLI subprocess) plus 1-2 file reads; on remote each
|
||||
// is a separate SSH RTT. Visibility lets future captures show
|
||||
// how often the report file is missing or oversized.
|
||||
let parsed = await ScarfMon.measureAsync(.diskIO, "curator.load") {
|
||||
await Task.detached(priority: .userInitiated) { () -> (HermesCuratorStatus, String?) in
|
||||
let textResult = Self.runCuratorStatus(context: context)
|
||||
@@ -69,46 +101,156 @@ public final class CuratorViewModel {
|
||||
self.lastReportMarkdown = parsed.1
|
||||
}
|
||||
|
||||
public func runNow() async {
|
||||
await runAndReload(args: ["curator", "run"], successMessage: "Curator run started")
|
||||
/// Refresh the archived-skills list. No-op on hosts without
|
||||
/// `hasCuratorArchive` — the caller gates the call.
|
||||
public func loadArchive() async {
|
||||
isLoadingArchive = true
|
||||
defer { isLoadingArchive = false }
|
||||
do {
|
||||
archivedSkills = try await service.listArchived()
|
||||
} catch {
|
||||
archivedSkills = []
|
||||
errorMessage = (error as? LocalizedError)?.errorDescription
|
||||
?? error.localizedDescription
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Writes (v0.12)
|
||||
|
||||
/// Run the curator manually. On v0.13+ hosts this blocks for the
|
||||
/// duration of the run (default 600s timeout); pre-v0.13 returns
|
||||
/// immediately. Caller passes the capability-decided flag.
|
||||
public func runNow(synchronous: Bool, timeout: TimeInterval = 600) async {
|
||||
await runWithReload(
|
||||
verb: "run",
|
||||
successMessage: synchronous ? "Curator run complete" : "Curator run started"
|
||||
) {
|
||||
try await self.service.runNow(synchronous: synchronous, timeout: timeout)
|
||||
}
|
||||
}
|
||||
|
||||
public func pause() async {
|
||||
await runAndReload(args: ["curator", "pause"], successMessage: "Curator paused")
|
||||
await runWithReload(verb: "pause", successMessage: "Curator paused") {
|
||||
try await self.service.pause()
|
||||
}
|
||||
}
|
||||
|
||||
public func resume() async {
|
||||
await runAndReload(args: ["curator", "resume"], successMessage: "Curator resumed")
|
||||
await runWithReload(verb: "resume", successMessage: "Curator resumed") {
|
||||
try await self.service.resume()
|
||||
}
|
||||
}
|
||||
|
||||
public func pin(_ skill: String) async {
|
||||
await runAndReload(args: ["curator", "pin", skill], successMessage: "Pinned \(skill)")
|
||||
await runWithReload(verb: "pin", successMessage: "Pinned \(skill)") {
|
||||
try await self.service.pin(skill)
|
||||
}
|
||||
}
|
||||
|
||||
public func unpin(_ skill: String) async {
|
||||
await runAndReload(args: ["curator", "unpin", skill], successMessage: "Unpinned \(skill)")
|
||||
await runWithReload(verb: "unpin", successMessage: "Unpinned \(skill)") {
|
||||
try await self.service.unpin(skill)
|
||||
}
|
||||
}
|
||||
|
||||
public func restore(_ skill: String) async {
|
||||
await runAndReload(args: ["curator", "restore", skill], successMessage: "Restored \(skill)")
|
||||
await runWithReload(verb: "restore", successMessage: "Restored \(skill)") {
|
||||
try await self.service.restore(skill)
|
||||
}
|
||||
// Restore drops the entry from the archived list — refresh it
|
||||
// so the row disappears immediately.
|
||||
await loadArchive()
|
||||
}
|
||||
|
||||
private func runAndReload(args: [String], successMessage: String) async {
|
||||
let context = self.context
|
||||
let exitCode = await Task.detached(priority: .userInitiated) {
|
||||
Self.runHermes(context: context, args: args).exitCode
|
||||
}.value
|
||||
transientMessage = exitCode == 0 ? successMessage : "Command failed"
|
||||
await load()
|
||||
// Auto-clear toast after 3s.
|
||||
// MARK: - Writes (v0.13)
|
||||
|
||||
public func archive(_ skill: String) async {
|
||||
pendingArchiveName = skill
|
||||
await runWithReload(verb: "archive", successMessage: "Archived \(skill)") {
|
||||
try await self.service.archive(skill)
|
||||
}
|
||||
pendingArchiveName = nil
|
||||
await loadArchive()
|
||||
}
|
||||
|
||||
/// Stage 1 of the bulk-prune flow. Calls `prune --dry-run` and
|
||||
/// populates `pruneSummary`; the View binds its confirm sheet to
|
||||
/// the non-nil presence of this property.
|
||||
public func planPrune() async {
|
||||
do {
|
||||
pruneSummary = try await service.prune(dryRun: true)
|
||||
} catch {
|
||||
errorMessage = (error as? LocalizedError)?.errorDescription
|
||||
?? error.localizedDescription
|
||||
pruneSummary = nil
|
||||
}
|
||||
}
|
||||
|
||||
/// Stage 2 of the bulk-prune flow. Destructive — removes everything
|
||||
/// currently archived. Clears `pruneSummary` regardless of outcome
|
||||
/// so the confirm sheet dismisses.
|
||||
public func confirmPrune() async {
|
||||
isPruning = true
|
||||
do {
|
||||
_ = try await service.prune(dryRun: false)
|
||||
transientMessage = "Pruned archived skills"
|
||||
errorMessage = nil
|
||||
await loadArchive()
|
||||
await load()
|
||||
scheduleTransientClear()
|
||||
} catch {
|
||||
errorMessage = (error as? LocalizedError)?.errorDescription
|
||||
?? error.localizedDescription
|
||||
}
|
||||
isPruning = false
|
||||
pruneSummary = nil
|
||||
}
|
||||
|
||||
/// Cancel the in-flight prune-confirm flow without running.
|
||||
public func cancelPrune() {
|
||||
pruneSummary = nil
|
||||
}
|
||||
|
||||
/// User-driven dismissal of the inline error banner.
|
||||
public func dismissError() {
|
||||
errorMessage = nil
|
||||
}
|
||||
|
||||
// MARK: - Helpers
|
||||
|
||||
/// Run a service call, route success → `transientMessage`, failure
|
||||
/// → `errorMessage`, and reload `status` either way. Mirrors the
|
||||
/// previous `runAndReload` helper but goes through the typed
|
||||
/// service surface.
|
||||
private func runWithReload(
|
||||
verb: String,
|
||||
successMessage: String,
|
||||
body: @escaping @Sendable () async throws -> Void
|
||||
) async {
|
||||
do {
|
||||
try await body()
|
||||
transientMessage = successMessage
|
||||
errorMessage = nil
|
||||
await load()
|
||||
scheduleTransientClear()
|
||||
} catch {
|
||||
let message = (error as? LocalizedError)?.errorDescription
|
||||
?? error.localizedDescription
|
||||
errorMessage = message
|
||||
transientMessage = nil
|
||||
await load()
|
||||
}
|
||||
}
|
||||
|
||||
private func scheduleTransientClear() {
|
||||
Task { @MainActor [weak self] in
|
||||
try? await Task.sleep(nanoseconds: 3_000_000_000)
|
||||
self?.transientMessage = nil
|
||||
}
|
||||
}
|
||||
|
||||
/// Wrap the transport-level `runProcess` so the call sites don't
|
||||
/// have to reach for it directly. Combined stdout+stderr.
|
||||
// MARK: - Legacy sync helpers (kept for `load`'s detached path)
|
||||
|
||||
nonisolated private static func runHermes(
|
||||
context: ServerContext,
|
||||
args: [String]
|
||||
|
||||
@@ -254,15 +254,73 @@ public final class RichChatViewModel {
|
||||
/// Hermes v2026.4.23+ but listed here unconditionally so older
|
||||
/// hosts that don't advertise it still surface the trigger; the
|
||||
/// agent will respond appropriately or no-op gracefully.
|
||||
///
|
||||
/// v2.8 / Hermes v0.13 adds `/goal` (lock the agent on a target
|
||||
/// across turns) and `/queue` (queue a prompt for after the current
|
||||
/// turn). Both ride the same `.acpNonInterruptive` source — Hermes
|
||||
/// parses them server-side, the wire shape is plain
|
||||
/// `session/prompt`, and the chat UI keeps the "Agent working…"
|
||||
/// indicator off when they're sent. They're listed unconditionally
|
||||
/// here; capability filtering happens in `availableCommands` so
|
||||
/// pre-v0.13 hosts don't see `/goal` or `/queue` in the slash menu.
|
||||
// TODO(WS-2-Q7): verify against a real v0.13 ACP host that `/goal`
|
||||
// is in fact non-interruptive on the wire. If Hermes treats it as a
|
||||
// regular prompt that flips "Agent working…", drop it from this
|
||||
// list and route it through the standard send path (the pill
|
||||
// bookkeeping in `recordActiveGoal` is independent of the
|
||||
// interruptive classification).
|
||||
public static let nonInterruptiveCommands: [HermesSlashCommand] = [
|
||||
HermesSlashCommand(
|
||||
name: "steer",
|
||||
description: "Nudge the agent mid-run (applies after the next tool call)",
|
||||
argumentHint: "<guidance>",
|
||||
source: .acpNonInterruptive
|
||||
),
|
||||
HermesSlashCommand(
|
||||
name: "goal",
|
||||
description: "Lock the agent on a goal that persists across turns",
|
||||
argumentHint: "<text>",
|
||||
source: .acpNonInterruptive
|
||||
),
|
||||
HermesSlashCommand(
|
||||
name: "queue",
|
||||
description: "Queue a prompt to run after the current turn",
|
||||
argumentHint: "<text>",
|
||||
source: .acpNonInterruptive
|
||||
)
|
||||
]
|
||||
|
||||
/// Capability snapshot the chat surface uses to filter
|
||||
/// `availableCommands`. Set by the chat controller (Mac
|
||||
/// `ChatViewModel`, iOS `ChatController`) at session-start time and
|
||||
/// kept fresh via the `HermesCapabilitiesStore` env binding. Default
|
||||
/// `.empty` means "no v0.13 surfaces" — pre-v0.13 hosts and harness
|
||||
/// scenarios (Previews, smoke tests) never expose `/goal` or
|
||||
/// `/queue` until the controller publishes a real capabilities
|
||||
/// value. `@ObservationIgnored` so capability refreshes don't trash
|
||||
/// the streaming-message render budget; controllers call
|
||||
/// `publishCapabilities(_:)` once per refresh tick.
|
||||
@ObservationIgnored
|
||||
public var capabilitiesGate: HermesCapabilities = .empty
|
||||
|
||||
/// Optimistic local mirror of the agent's currently-locked goal.
|
||||
/// Set by `recordActiveGoal(text:)` the moment the user sends
|
||||
/// `/goal …`; cleared on `/goal --clear` or `reset()`. Pre-v0.13
|
||||
/// hosts can't reach this code path (the slash menu hides `/goal`),
|
||||
/// but a typed-out `/goal foo` against an older host would still
|
||||
/// land here briefly until Hermes' "unknown command" reply lands —
|
||||
/// see WS-2 plan "Inconsistency caveat".
|
||||
public private(set) var activeGoal: HermesActiveGoal?
|
||||
|
||||
/// Optimistic mirror of prompts the user has queued via `/queue …`
|
||||
/// while a turn is in flight. Hermes is the authoritative owner
|
||||
/// server-side; this list drives the chat-header chip + popover and
|
||||
/// drains FIFO via `popQueuedPrompt()` when a turn completes.
|
||||
/// Best-effort: if Hermes' server-side queue gets out of sync
|
||||
/// (deferred prompt aborted, dropped on disconnect) the user sees a
|
||||
/// stale chip until their next interaction.
|
||||
public private(set) var queuedPrompts: [HermesQueuedPrompt] = []
|
||||
|
||||
/// Transient hint shown above the composer, e.g. "Guidance queued —
|
||||
/// applies after the next tool call." for `/steer`. The chat view
|
||||
/// auto-clears it after a short delay (handled in the view); the
|
||||
@@ -324,12 +382,94 @@ public final class RichChatViewModel {
|
||||
!acpNames.contains($0.name) && !projectNames.contains($0.name)
|
||||
}
|
||||
let occupied = acpNames.union(projectNames).union(Set(quicks.map(\.name)))
|
||||
let nonInterruptive = Self.nonInterruptiveCommands.filter {
|
||||
!occupied.contains($0.name)
|
||||
// Capability gate: `/goal` and `/queue` are v0.13+ surfaces;
|
||||
// hide them when the connected host is older. `/steer` is
|
||||
// surfaced unconditionally — it works on v0.11+ during an
|
||||
// active turn; idle-session greying for pre-v0.13 hosts is
|
||||
// the input bar's concern (it reads `hasACPSteerOnIdle`).
|
||||
let supported: [HermesSlashCommand] = Self.nonInterruptiveCommands.filter { cmd in
|
||||
switch cmd.name {
|
||||
case "goal": return capabilitiesGate.hasGoals
|
||||
case "queue": return capabilitiesGate.hasACPQueue
|
||||
case "steer": return true
|
||||
default: return true
|
||||
}
|
||||
}
|
||||
let nonInterruptive = supported.filter { !occupied.contains($0.name) }
|
||||
return acpCommands + projectAsHermes + quicks + nonInterruptive
|
||||
}
|
||||
|
||||
/// Publish a fresh capabilities snapshot from the controller.
|
||||
/// Called whenever `HermesCapabilitiesStore.capabilities` changes
|
||||
/// (initial detection, post-refresh, server switch). The chat input
|
||||
/// bar's slash menu re-reads `availableCommands` lazily, so this is
|
||||
/// just a stored-value swap — no observable churn.
|
||||
public func publishCapabilities(_ caps: HermesCapabilities) {
|
||||
capabilitiesGate = caps
|
||||
}
|
||||
|
||||
/// Optimistic write triggered when the user sends `/goal <text>`.
|
||||
/// Pass `nil` (or empty) to clear (the `/goal --clear` path). The
|
||||
/// pill renders synchronously off this state; there is no
|
||||
/// authoritative server read-back in v2.8.0 — see WS-2 plan Q1.
|
||||
// TODO(WS-2-Q1): hook a Hermes-supplied goal-state read-back path
|
||||
// here once we know whether v0.13 exposes goal state via an ACP
|
||||
// session-startup notification, a session-sidecar JSON field, or a
|
||||
// `/goal --status` reply. Until then `activeGoal` is purely
|
||||
// user-set and does not survive a session resume.
|
||||
public func recordActiveGoal(text: String?) {
|
||||
if let text, !text.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty {
|
||||
activeGoal = HermesActiveGoal(
|
||||
text: text.trimmingCharacters(in: .whitespacesAndNewlines),
|
||||
setAt: Date()
|
||||
)
|
||||
} else {
|
||||
activeGoal = nil
|
||||
}
|
||||
}
|
||||
|
||||
/// Append an optimistically-queued prompt to the local mirror
|
||||
/// (driven by `/queue <text>`). No-op for empty / whitespace input.
|
||||
public func recordQueuedPrompt(text: String) {
|
||||
let trimmed = text.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
guard !trimmed.isEmpty else { return }
|
||||
queuedPrompts.append(HermesQueuedPrompt(text: trimmed))
|
||||
}
|
||||
|
||||
/// Drain the next queued prompt off the local mirror, FIFO. Called
|
||||
/// from `handlePromptComplete` once a turn settles — Hermes runs
|
||||
/// the actual queued prompt server-side; popping here keeps the
|
||||
/// header chip count honest. Returns the popped prompt for any
|
||||
/// caller that wants to log it; the chat UI ignores the return.
|
||||
@discardableResult
|
||||
public func popQueuedPrompt() -> HermesQueuedPrompt? {
|
||||
queuedPrompts.isEmpty ? nil : queuedPrompts.removeFirst()
|
||||
}
|
||||
|
||||
/// Parse the argument slug from a `/goal …` invocation. Pure
|
||||
/// function — exposed for unit tests. The chat dispatch reads this
|
||||
/// to decide whether to set, clear, or no-op the optimistic pill.
|
||||
public enum GoalCommandArgument: Equatable {
|
||||
case set(String)
|
||||
case clear
|
||||
/// User typed `/goal` with no argument — Hermes will reply
|
||||
/// with usage; Scarf shows a neutral hint and doesn't touch
|
||||
/// the pill state.
|
||||
case empty
|
||||
}
|
||||
|
||||
public static func parseGoalArgument(_ raw: String) -> GoalCommandArgument {
|
||||
let trimmed = raw.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if trimmed.isEmpty { return .empty }
|
||||
// Accept `--clear`, `clear`, and case-insensitive variants so
|
||||
// typos don't accidentally lock the goal text to literal
|
||||
// "Clear". `--clear` is the canonical form (matches Hermes
|
||||
// CLI flag style).
|
||||
let lowered = trimmed.lowercased()
|
||||
if lowered == "--clear" || lowered == "clear" { return .clear }
|
||||
return .set(trimmed)
|
||||
}
|
||||
|
||||
/// True when `text` is a non-interruptive command that should NOT
|
||||
/// flip `isAgentWorking` to true on send. Used by the Mac/iOS chat
|
||||
/// view models to skip the "agent working" overlay change for
|
||||
@@ -481,6 +621,14 @@ public final class RichChatViewModel {
|
||||
turnDurations = [:]
|
||||
transientHint = nil
|
||||
pendingPermission = nil
|
||||
// v2.8 / Hermes v0.13 — drop optimistic v0.13 surfaces on
|
||||
// session reset so a fresh chat (or a resume into a different
|
||||
// session) doesn't paint stale goal / queue state from the
|
||||
// previous one. The capabilities gate stays on whatever the
|
||||
// controller most recently published; it's a host-level value
|
||||
// that doesn't change with session boundaries.
|
||||
activeGoal = nil
|
||||
queuedPrompts = []
|
||||
loadQuickCommands()
|
||||
}
|
||||
|
||||
@@ -826,6 +974,22 @@ public final class RichChatViewModel {
|
||||
// there rather than snapping back to 0.
|
||||
acpCompressionCount = max(acpCompressionCount, response.compressionCount)
|
||||
isAgentWorking = false
|
||||
// v2.8 / Hermes v0.13 — Hermes runs the next `/queue`-deferred
|
||||
// prompt server-side now that this turn has settled. Drain the
|
||||
// local mirror FIFO so the header chip count matches what the
|
||||
// user staged. Best-effort: if Hermes' authoritative queue
|
||||
// diverged (deferred prompt aborted, dropped on disconnect),
|
||||
// the chip is one tick stale until the user's next interaction.
|
||||
if !queuedPrompts.isEmpty {
|
||||
popQueuedPrompt()
|
||||
}
|
||||
// TODO(v2.8.1): when this completes after an auto-resumed
|
||||
// checkpoint (Hermes v0.13's "Auto-resume interrupted sessions
|
||||
// after gateway restart"), surface a one-shot "Auto-resumed
|
||||
// from checkpoint" indicator. Wire-shape unknown until a v0.13
|
||||
// dogfooding pass confirms whether the resume lands as a
|
||||
// visible ACP event or is purely server-side. Deferred from
|
||||
// v2.8.0 per WS-2 plan Q3.
|
||||
buildMessageGroups()
|
||||
// Final position after the prompt settles. Catches fast responses
|
||||
// (slash commands, short replies) where `.defaultScrollAnchor(.bottom)`
|
||||
|
||||
@@ -0,0 +1,70 @@
|
||||
import Testing
|
||||
import Foundation
|
||||
@testable import ScarfCore
|
||||
|
||||
/// Pure mapping tests for `GatewayAllowlistKind`. Locks down the (platform →
|
||||
/// kind) table so a refactor doesn't accidentally drop a platform.
|
||||
@Suite struct GatewayAllowlistKindTests {
|
||||
|
||||
@Test func mapsKnownPlatformsToCorrectKind() {
|
||||
#expect(GatewayAllowlistKind.kind(for: "slack") == .channels)
|
||||
#expect(GatewayAllowlistKind.kind(for: "mattermost") == .channels)
|
||||
#expect(GatewayAllowlistKind.kind(for: "google-chat") == .channels)
|
||||
#expect(GatewayAllowlistKind.kind(for: "telegram") == .chats)
|
||||
#expect(GatewayAllowlistKind.kind(for: "whatsapp") == .chats)
|
||||
#expect(GatewayAllowlistKind.kind(for: "matrix") == .rooms)
|
||||
#expect(GatewayAllowlistKind.kind(for: "dingtalk") == .rooms)
|
||||
}
|
||||
|
||||
@Test func acceptsBothGoogleChatSpellings() {
|
||||
// // TODO(WS-5-Q1) — both spellings round-trip until Hermes confirms
|
||||
// the wire identifier.
|
||||
#expect(GatewayAllowlistKind.kind(for: "google-chat") == .channels)
|
||||
#expect(GatewayAllowlistKind.kind(for: "googlechat") == .channels)
|
||||
}
|
||||
|
||||
@Test func returnsNilForPlatformsWithoutAllowlist() {
|
||||
#expect(GatewayAllowlistKind.kind(for: "cli") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "yuanbao") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "microsoft-teams") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "discord") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "signal") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "homeassistant") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "") == nil)
|
||||
#expect(GatewayAllowlistKind.kind(for: "unknown") == nil)
|
||||
}
|
||||
|
||||
@Test func yamlKeyMatchesHermesContract() {
|
||||
#expect(GatewayAllowlistKind.channels.yamlKey == "allowed_channels")
|
||||
#expect(GatewayAllowlistKind.chats.yamlKey == "allowed_chats")
|
||||
#expect(GatewayAllowlistKind.rooms.yamlKey == "allowed_rooms")
|
||||
}
|
||||
|
||||
@Test func nounsAreUserFacingSafe() {
|
||||
#expect(GatewayAllowlistKind.channels.noun == "channel")
|
||||
#expect(GatewayAllowlistKind.chats.noun == "chat")
|
||||
#expect(GatewayAllowlistKind.rooms.noun == "room")
|
||||
#expect(GatewayAllowlistKind.channels.pluralNoun == "channels")
|
||||
#expect(GatewayAllowlistKind.chats.pluralNoun == "chats")
|
||||
#expect(GatewayAllowlistKind.rooms.pluralNoun == "rooms")
|
||||
}
|
||||
|
||||
@Test func placeholdersAreNonEmpty() {
|
||||
// Smoke test — placeholder strings are advisory; we just don't want
|
||||
// them silently emptied during a refactor.
|
||||
#expect(!GatewayAllowlistKind.channels.inputPlaceholder.isEmpty)
|
||||
#expect(!GatewayAllowlistKind.chats.inputPlaceholder.isEmpty)
|
||||
#expect(!GatewayAllowlistKind.rooms.inputPlaceholder.isEmpty)
|
||||
}
|
||||
|
||||
@Test func gatewayPlatformSettingsItemsForKind() {
|
||||
let s = GatewayPlatformSettings(
|
||||
allowedChannels: ["C01"],
|
||||
allowedChats: ["@user"],
|
||||
allowedRooms: ["!room:matrix.org"]
|
||||
)
|
||||
#expect(s.items(for: .channels) == ["C01"])
|
||||
#expect(s.items(for: .chats) == ["@user"])
|
||||
#expect(s.items(for: .rooms) == ["!room:matrix.org"])
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,276 @@
|
||||
import Testing
|
||||
import Foundation
|
||||
@testable import ScarfCore
|
||||
|
||||
/// Round-trip + idempotence tests for `GatewayConfigWriter.setList`. Pure
|
||||
/// `String` operations only — runs cleanly on Linux SwiftPM.
|
||||
@Suite struct GatewayConfigWriterTests {
|
||||
|
||||
// MARK: - Insert
|
||||
|
||||
@Test func setListInsertsBlockOnEmpty() {
|
||||
let yaml = ""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: ["C0123ABCD", "C0456EFGH"]
|
||||
)
|
||||
#expect(updated.contains("gateway:"))
|
||||
#expect(updated.contains(" platforms:"))
|
||||
#expect(updated.contains(" slack:"))
|
||||
#expect(updated.contains(" allowed_channels:"))
|
||||
#expect(updated.contains("- C0123ABCD"))
|
||||
#expect(updated.contains("- C0456EFGH"))
|
||||
}
|
||||
|
||||
@Test func setListAppendsScaffoldPreservingPriorContent() {
|
||||
let yaml = """
|
||||
model:
|
||||
default: gpt-4o
|
||||
provider: openai
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: ["C01"]
|
||||
)
|
||||
// Original content preserved verbatim at the top.
|
||||
#expect(updated.contains("model:"))
|
||||
#expect(updated.contains(" default: gpt-4o"))
|
||||
#expect(updated.contains(" provider: openai"))
|
||||
// New scaffold appended.
|
||||
#expect(updated.contains("gateway:"))
|
||||
#expect(updated.contains(" slack:"))
|
||||
#expect(updated.contains("- C01"))
|
||||
}
|
||||
|
||||
// MARK: - Replace
|
||||
|
||||
@Test func setListReplacesExistingBlock() {
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
allowed_channels:
|
||||
- C_OLD_1
|
||||
- C_OLD_2
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: ["C_NEW_1"]
|
||||
)
|
||||
#expect(updated.contains("- C_NEW_1"))
|
||||
#expect(!updated.contains("- C_OLD_1"))
|
||||
#expect(!updated.contains("- C_OLD_2"))
|
||||
}
|
||||
|
||||
@Test func setListPreservesScalarSiblings() {
|
||||
// The `busy_ack_enabled` scalar sibling of `allowed_channels` must
|
||||
// stay byte-for-byte after a list-write to the same platform.
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
allowed_channels:
|
||||
- C_OLD
|
||||
busy_ack_enabled: false
|
||||
gateway_restart_notification: true
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: ["C_NEW"]
|
||||
)
|
||||
#expect(updated.contains("- C_NEW"))
|
||||
#expect(!updated.contains("- C_OLD"))
|
||||
// Scalars at the same indent must survive.
|
||||
#expect(updated.contains("busy_ack_enabled: false"))
|
||||
#expect(updated.contains("gateway_restart_notification: true"))
|
||||
}
|
||||
|
||||
@Test func setListPreservesOtherPlatformsBlocks() {
|
||||
// Editing slack must not touch matrix.
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
allowed_channels:
|
||||
- C_SLACK
|
||||
matrix:
|
||||
allowed_rooms:
|
||||
- '!room1:matrix.org'
|
||||
- '!room2:matrix.org'
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: ["C_SLACK_NEW"]
|
||||
)
|
||||
#expect(updated.contains("- C_SLACK_NEW"))
|
||||
// Matrix block intact.
|
||||
#expect(updated.contains(" matrix:"))
|
||||
#expect(updated.contains("'!room1:matrix.org'"))
|
||||
#expect(updated.contains("'!room2:matrix.org'"))
|
||||
}
|
||||
|
||||
// MARK: - Remove
|
||||
|
||||
@Test func setListWithEmptyItemsRemovesBlock() {
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
allowed_channels:
|
||||
- C01
|
||||
- C02
|
||||
busy_ack_enabled: true
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: []
|
||||
)
|
||||
// Block removed; sibling scalar preserved.
|
||||
#expect(!updated.contains("allowed_channels:"))
|
||||
#expect(!updated.contains("- C01"))
|
||||
#expect(!updated.contains("- C02"))
|
||||
#expect(updated.contains("busy_ack_enabled: true"))
|
||||
}
|
||||
|
||||
@Test func setListWithEmptyItemsOnAbsentBlockIsNoOp() {
|
||||
let yaml = """
|
||||
model:
|
||||
default: gpt-4o
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "slack",
|
||||
key: "allowed_channels",
|
||||
items: []
|
||||
)
|
||||
#expect(updated == yaml)
|
||||
}
|
||||
|
||||
// MARK: - Idempotence
|
||||
|
||||
@Test func setListIsIdempotent() {
|
||||
let yaml = """
|
||||
model:
|
||||
default: gpt-4o
|
||||
"""
|
||||
let once = GatewayConfigWriter.setList(
|
||||
in: yaml,
|
||||
platform: "telegram",
|
||||
key: "allowed_chats",
|
||||
items: ["@alice", "@bob"]
|
||||
)
|
||||
let twice = GatewayConfigWriter.setList(
|
||||
in: once,
|
||||
platform: "telegram",
|
||||
key: "allowed_chats",
|
||||
items: ["@alice", "@bob"]
|
||||
)
|
||||
#expect(once == twice)
|
||||
}
|
||||
|
||||
@Test func setListReplaceThenReplaceIsStable() {
|
||||
let yaml = ""
|
||||
let a = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "matrix", key: "allowed_rooms",
|
||||
items: ["!a:m", "!b:m"]
|
||||
)
|
||||
let b = GatewayConfigWriter.setList(
|
||||
in: a, platform: "matrix", key: "allowed_rooms",
|
||||
items: ["!c:m"]
|
||||
)
|
||||
#expect(b.contains("- '!c:m'"))
|
||||
#expect(!b.contains("'!a:m'"))
|
||||
#expect(!b.contains("'!b:m'"))
|
||||
}
|
||||
|
||||
// MARK: - Quoting
|
||||
|
||||
@Test func setListQuotesItemsContainingColons() {
|
||||
// Matrix room IDs contain `:` — must be single-quoted.
|
||||
let yaml = ""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "matrix", key: "allowed_rooms",
|
||||
items: ["!RoomId:matrix.org"]
|
||||
)
|
||||
#expect(updated.contains("'!RoomId:matrix.org'"))
|
||||
}
|
||||
|
||||
@Test func setListQuotesItemsStartingWithAt() {
|
||||
// Telegram usernames `@alice`.
|
||||
let yaml = ""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "telegram", key: "allowed_chats",
|
||||
items: ["@alice"]
|
||||
)
|
||||
#expect(updated.contains("'@alice'"))
|
||||
}
|
||||
|
||||
@Test func setListLeavesPlainAlphanumericUnquoted() {
|
||||
// Slack channel IDs are A-Z0-9 — emit unquoted for readability.
|
||||
let yaml = ""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "slack", key: "allowed_channels",
|
||||
items: ["C0123ABCD"]
|
||||
)
|
||||
#expect(updated.contains("- C0123ABCD"))
|
||||
#expect(!updated.contains("'C0123ABCD'"))
|
||||
}
|
||||
|
||||
@Test func setListEscapesEmbeddedSingleQuotes() {
|
||||
let yaml = ""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "slack", key: "allowed_channels",
|
||||
items: ["weird:'name"]
|
||||
)
|
||||
// Embedded single quote doubled per YAML spec.
|
||||
#expect(updated.contains("'weird:''name'"))
|
||||
}
|
||||
|
||||
// MARK: - Insertion when ancestors exist but key is absent
|
||||
|
||||
@Test func setListInsertsKeyUnderExistingPlatformBlock() {
|
||||
// `gateway → platforms → slack` exists with a busy_ack_enabled
|
||||
// scalar; `allowed_channels` is missing. Add it without disturbing
|
||||
// the scalar sibling.
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
busy_ack_enabled: false
|
||||
"""
|
||||
let updated = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "slack", key: "allowed_channels",
|
||||
items: ["C42"]
|
||||
)
|
||||
#expect(updated.contains("busy_ack_enabled: false"))
|
||||
#expect(updated.contains("allowed_channels:"))
|
||||
#expect(updated.contains("- C42"))
|
||||
}
|
||||
|
||||
// MARK: - Round-trip with the YAML loader
|
||||
|
||||
@Test func roundTripsThroughHermesConfigYAMLLoader() {
|
||||
// Write a list, then parse the result through HermesConfig+YAML and
|
||||
// confirm we read back what we wrote.
|
||||
var yaml = ""
|
||||
yaml = GatewayConfigWriter.setList(
|
||||
in: yaml, platform: "slack", key: "allowed_channels",
|
||||
items: ["C01", "C02"]
|
||||
)
|
||||
let cfg = HermesConfig(yaml: yaml)
|
||||
let block = cfg.gatewayPlatforms["slack"]
|
||||
#expect(block?.allowedChannels == ["C01", "C02"])
|
||||
}
|
||||
}
|
||||
@@ -151,4 +151,169 @@ import Foundation
|
||||
#expect(parsed?.patchCount == 2)
|
||||
#expect(parsed?.lastActivityLabel == "2026-04-25")
|
||||
}
|
||||
|
||||
// MARK: - v0.13 list-archived / prune fixtures (WS-4)
|
||||
|
||||
/// Empty JSON array → `[]`. Locks in the happy-path no-archives shape.
|
||||
@Test func listArchivedEmpty() throws {
|
||||
let result = try CuratorService.parseListArchived(stdout: "[]")
|
||||
#expect(result.isEmpty)
|
||||
}
|
||||
|
||||
/// Three archives with full optional fields. Asserts each
|
||||
/// optional value decodes through `decodeIfPresent` and that
|
||||
/// the computed labels resolve.
|
||||
@Test func listArchivedThreeSkills() throws {
|
||||
let json = """
|
||||
[
|
||||
{
|
||||
"name": "legacy-helper",
|
||||
"category": "templates",
|
||||
"archived_at": "2026-04-22T03:14:09Z",
|
||||
"reason": "stale: 91d unused",
|
||||
"size_bytes": 4521,
|
||||
"path": "/Users/u/.hermes/skills/.archived/legacy-helper"
|
||||
},
|
||||
{
|
||||
"name": "old-translator",
|
||||
"category": "user",
|
||||
"archived_at": "2026-04-23T10:00:00Z",
|
||||
"reason": "consolidated with translator",
|
||||
"size_bytes": 8192
|
||||
},
|
||||
{
|
||||
"name": "minimal"
|
||||
}
|
||||
]
|
||||
"""
|
||||
let result = try CuratorService.parseListArchived(stdout: json)
|
||||
#expect(result.count == 3)
|
||||
#expect(result[0].name == "legacy-helper")
|
||||
#expect(result[0].category == "templates")
|
||||
#expect(result[0].reason == "stale: 91d unused")
|
||||
#expect(result[0].sizeBytes == 4521)
|
||||
#expect(result[0].archivedAtLabel == "2026-04-22")
|
||||
#expect(result[0].path == "/Users/u/.hermes/skills/.archived/legacy-helper")
|
||||
|
||||
// Tolerant: only `name` set on the third row.
|
||||
#expect(result[2].name == "minimal")
|
||||
#expect(result[2].category == nil)
|
||||
#expect(result[2].reason == nil)
|
||||
#expect(result[2].archivedAtLabel == "—")
|
||||
#expect(result[2].sizeLabel == "—")
|
||||
}
|
||||
|
||||
/// `{"archived": [...]}` envelope is also accepted.
|
||||
@Test func listArchivedEnvelope() throws {
|
||||
let json = """
|
||||
{"archived": [
|
||||
{"name": "envelope-skill", "size_bytes": 1024}
|
||||
]}
|
||||
"""
|
||||
let result = try CuratorService.parseListArchived(stdout: json)
|
||||
#expect(result.count == 1)
|
||||
#expect(result[0].name == "envelope-skill")
|
||||
}
|
||||
|
||||
/// Text fallback when `--json` isn't supported. Each row carries
|
||||
/// the name in column 1 plus k=v chips for the optional fields.
|
||||
@Test func listArchivedTextFallback() {
|
||||
let text = """
|
||||
legacy-helper archived=2026-04-22 size=4521 reason=stale
|
||||
old-translator archived=2026-04-23 size=8192
|
||||
minimal-row
|
||||
"""
|
||||
let result = CuratorService.parseListArchivedText(text)
|
||||
#expect(result.count == 3)
|
||||
#expect(result[0].name == "legacy-helper")
|
||||
#expect(result[0].archivedAt == "2026-04-22")
|
||||
#expect(result[0].sizeBytes == 4521)
|
||||
#expect(result[0].reason == "stale")
|
||||
#expect(result[2].name == "minimal-row")
|
||||
#expect(result[2].sizeBytes == nil)
|
||||
}
|
||||
|
||||
/// Empty-state sentinel folds to `[]` (parallel to KanbanService's
|
||||
/// `"no matching tasks"` handling).
|
||||
@Test func listArchivedNoArchivedSentinel() throws {
|
||||
let result = try CuratorService.parseListArchived(stdout: "no archived skills\n")
|
||||
#expect(result.isEmpty)
|
||||
}
|
||||
|
||||
/// Whitespace-only stdout also folds to empty.
|
||||
@Test func listArchivedWhitespaceFoldsToEmpty() throws {
|
||||
let result = try CuratorService.parseListArchived(stdout: " \n\n")
|
||||
#expect(result.isEmpty)
|
||||
}
|
||||
|
||||
/// Decode failure (clearly non-JSON, non-text) throws. We accept
|
||||
/// JSON, the envelope, the empty sentinel, or text rows; anything
|
||||
/// else surfaces as a `CuratorError.decoding`.
|
||||
@Test func listArchivedNonsenseThrows() throws {
|
||||
do {
|
||||
_ = try CuratorService.parseListArchived(stdout: "{garbage")
|
||||
Issue.record("expected decoding throw")
|
||||
} catch let error as CuratorError {
|
||||
if case .decoding = error {
|
||||
// expected
|
||||
} else {
|
||||
Issue.record("unexpected error \(error)")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Prune-dry-run JSON with `would_remove` + `total_bytes`.
|
||||
@Test func pruneDryRunHappyPath() {
|
||||
let json = """
|
||||
{
|
||||
"would_remove": [
|
||||
{"name": "stale-a", "size_bytes": 1000},
|
||||
{"name": "stale-b", "size_bytes": 2000}
|
||||
],
|
||||
"total_bytes": 3000
|
||||
}
|
||||
"""
|
||||
let summary = CuratorService.parsePruneDryRun(json)
|
||||
#expect(summary.totalCount == 2)
|
||||
#expect(summary.totalBytes == 3000)
|
||||
#expect(summary.wouldRemove.first?.name == "stale-a")
|
||||
}
|
||||
|
||||
/// Zero-skill prune is a valid dry-run (no archives).
|
||||
@Test func pruneDryRunZeroSkills() {
|
||||
let json = """
|
||||
{"would_remove": [], "total_bytes": 0}
|
||||
"""
|
||||
let summary = CuratorService.parsePruneDryRun(json)
|
||||
#expect(summary.totalCount == 0)
|
||||
#expect(summary.totalBytes == 0)
|
||||
#expect(summary.totalBytesLabel == "—")
|
||||
}
|
||||
|
||||
/// Bare-array fallback: some Hermes builds may print just the
|
||||
/// would-remove list when the wrapper is missing.
|
||||
@Test func pruneDryRunBareArrayFallback() {
|
||||
let json = """
|
||||
[{"name": "lonely", "size_bytes": 500}]
|
||||
"""
|
||||
let summary = CuratorService.parsePruneDryRun(json)
|
||||
#expect(summary.totalCount == 1)
|
||||
#expect(summary.totalBytes == 500)
|
||||
}
|
||||
|
||||
/// Empty / whitespace stdout → zero summary (no decoding throw).
|
||||
@Test func pruneDryRunEmptyStaysSafe() {
|
||||
let summary = CuratorService.parsePruneDryRun(" \n")
|
||||
#expect(summary.totalCount == 0)
|
||||
#expect(summary.totalBytes == 0)
|
||||
}
|
||||
|
||||
/// Verify the size label uses the byte formatter (not raw bytes).
|
||||
@Test func archivedSkillSizeLabelFormats() {
|
||||
let big = HermesCuratorArchivedSkill(name: "x", sizeBytes: 1_500_000)
|
||||
// ByteCountFormatter produces a localized label; just verify
|
||||
// it's non-empty and not raw "1500000".
|
||||
#expect(!big.sizeLabel.isEmpty)
|
||||
#expect(big.sizeLabel != "1500000")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,131 @@
|
||||
import Testing
|
||||
import Foundation
|
||||
@testable import ScarfCore
|
||||
|
||||
/// Parser tests for `hermes gateway list --json`. Pure — no transport, no
|
||||
/// process calls.
|
||||
@Suite struct HermesGatewayListServiceTests {
|
||||
|
||||
private func data(_ s: String) -> Data { s.data(using: .utf8)! }
|
||||
|
||||
@Test func parsesSingleProfileSinglePlatform() {
|
||||
let json = data(#"""
|
||||
{"profiles":[{"name":"default","running":true,"pid":1234,
|
||||
"platforms":["slack","telegram"]}]}
|
||||
"""#)
|
||||
let snap = HermesGatewayListService.parse(json)
|
||||
#expect(snap?.profiles.count == 1)
|
||||
#expect(snap?.profiles[0].profile == "default")
|
||||
#expect(snap?.profiles[0].pid == 1234)
|
||||
#expect(snap?.profiles[0].isRunning == true)
|
||||
#expect(snap?.profiles[0].platforms == ["slack", "telegram"])
|
||||
}
|
||||
|
||||
@Test func parsesMultipleProfiles() {
|
||||
let json = data(#"""
|
||||
{"profiles":[
|
||||
{"name":"work","running":true,"pid":2001,"platforms":["slack"]},
|
||||
{"name":"personal","running":false,"platforms":["telegram"]}
|
||||
]}
|
||||
"""#)
|
||||
let snap = HermesGatewayListService.parse(json)
|
||||
#expect(snap?.profiles.count == 2)
|
||||
#expect(snap?.profiles[0].profile == "work")
|
||||
#expect(snap?.profiles[0].isRunning == true)
|
||||
#expect(snap?.profiles[1].profile == "personal")
|
||||
#expect(snap?.profiles[1].isRunning == false)
|
||||
#expect(snap?.profiles[1].pid == nil)
|
||||
}
|
||||
|
||||
@Test func parsesBareArrayShape() {
|
||||
// Tolerance for a top-level array (no `profiles` wrapper).
|
||||
let json = data(#"""
|
||||
[{"name":"default","running":true,"pid":42,"platforms":["discord"]}]
|
||||
"""#)
|
||||
let snap = HermesGatewayListService.parse(json)
|
||||
#expect(snap?.profiles.count == 1)
|
||||
#expect(snap?.profiles[0].profile == "default")
|
||||
}
|
||||
|
||||
@Test func toleratesAlternateFieldNames() {
|
||||
// `profile` instead of `name`, `state` instead of `running`,
|
||||
// `connected_platforms` instead of `platforms` — defensive defaults
|
||||
// keep the parser happy if Hermes ships any of these.
|
||||
let json = data(#"""
|
||||
{"profiles":[{"profile":"alt","state":"running","pid":7,
|
||||
"connected_platforms":["matrix"]}]}
|
||||
"""#)
|
||||
let snap = HermesGatewayListService.parse(json)
|
||||
#expect(snap?.profiles[0].profile == "alt")
|
||||
#expect(snap?.profiles[0].isRunning == true)
|
||||
#expect(snap?.profiles[0].platforms == ["matrix"])
|
||||
}
|
||||
|
||||
@Test func returnsNilOnEmptyData() {
|
||||
#expect(HermesGatewayListService.parse(Data()) == nil)
|
||||
}
|
||||
|
||||
@Test func returnsNilOnUnparseableJSON() {
|
||||
let json = data("not-json")
|
||||
#expect(HermesGatewayListService.parse(json) == nil)
|
||||
}
|
||||
|
||||
@Test func returnsEmptySnapshotOnEmptyProfilesArray() {
|
||||
let json = data(#"{"profiles":[]}"#)
|
||||
let snap = HermesGatewayListService.parse(json)
|
||||
#expect(snap?.profiles.isEmpty == true)
|
||||
}
|
||||
|
||||
@Test func toleratesUnknownKeys() {
|
||||
// Forward-compat: a future v0.13.x Hermes adds extra fields, parser
|
||||
// still works.
|
||||
let json = data(#"""
|
||||
{"profiles":[{"name":"default","running":true,"platforms":["slack"],
|
||||
"future_field":"value","another":42}]}
|
||||
"""#)
|
||||
let snap = HermesGatewayListService.parse(json)
|
||||
#expect(snap?.profiles[0].profile == "default")
|
||||
}
|
||||
|
||||
// MARK: - headerDigest
|
||||
|
||||
@Test func headerDigestEmptyProfiles() {
|
||||
let snap = GatewayListSnapshot(profiles: [])
|
||||
#expect(snap.headerDigest == "no profiles configured")
|
||||
}
|
||||
|
||||
@Test func headerDigestSingleProfileRunning() {
|
||||
let snap = GatewayListSnapshot(profiles: [
|
||||
.init(profile: "default", isRunning: true, pid: 100,
|
||||
platforms: ["slack", "telegram"])
|
||||
])
|
||||
#expect(snap.headerDigest == "default profile · running · slack, telegram")
|
||||
}
|
||||
|
||||
@Test func headerDigestSingleProfileStopped() {
|
||||
let snap = GatewayListSnapshot(profiles: [
|
||||
.init(profile: "default", isRunning: false, pid: nil, platforms: [])
|
||||
])
|
||||
#expect(snap.headerDigest == "default profile · stopped")
|
||||
}
|
||||
|
||||
@Test func headerDigestMultipleProfilesSomeRunning() {
|
||||
let snap = GatewayListSnapshot(profiles: [
|
||||
.init(profile: "work", isRunning: true, pid: 1, platforms: ["slack"]),
|
||||
.init(profile: "home", isRunning: false, pid: nil, platforms: ["matrix"]),
|
||||
.init(profile: "extra", isRunning: true, pid: 2, platforms: [])
|
||||
])
|
||||
// 3 profiles total, 2 running, surface first running profile's
|
||||
// platform list as the highlight.
|
||||
#expect(snap.headerDigest == "3 profiles (2 running) · work: slack")
|
||||
}
|
||||
|
||||
@Test func headerDigestMultipleProfilesNoneRunning() {
|
||||
let snap = GatewayListSnapshot(profiles: [
|
||||
.init(profile: "a", isRunning: false, pid: nil, platforms: ["slack"]),
|
||||
.init(profile: "b", isRunning: false, pid: nil, platforms: ["matrix"])
|
||||
])
|
||||
// No running profile — fall back to the first profile's platforms.
|
||||
#expect(snap.headerDigest == "2 profiles (0 running) · a: slack")
|
||||
}
|
||||
}
|
||||
@@ -327,4 +327,196 @@ import Foundation
|
||||
#expect(stats.glanceString.isEmpty)
|
||||
#expect(stats.activeCount == 0)
|
||||
}
|
||||
|
||||
// MARK: - v0.13 (Hermes 2026.5.7) tolerant decode
|
||||
//
|
||||
// The contract these tests pin: a v0.13 host's task / run / detail
|
||||
// JSON decodes successfully WITH the new fields populated, AND a
|
||||
// pre-v0.13 (v0.12) host's task / run / detail JSON decodes
|
||||
// successfully WITHOUT the new fields (everything resolves to nil
|
||||
// or empty). Drift from this pair = a regression that bites every
|
||||
// user not yet on Hermes v0.13.
|
||||
|
||||
@Test func decodeV013TaskFields() throws {
|
||||
let json = """
|
||||
{
|
||||
"id": "t_v013",
|
||||
"title": "v0.13 task",
|
||||
"status": "blocked",
|
||||
"max_retries": 5,
|
||||
"auto_blocked_reason": "worker exited without `kanban complete`",
|
||||
"hallucination_gate_status": "pending",
|
||||
"diagnostics": [
|
||||
{"kind": "worker_exit_no_complete", "message": "exit code 0 with no complete call", "detected_at": 1778160614},
|
||||
{"kind": "darwin_zombie_detected", "detected_at": "2026-05-09T12:00:00Z"}
|
||||
]
|
||||
}
|
||||
"""
|
||||
let task = try JSONDecoder().decode(HermesKanbanTask.self, from: Data(json.utf8))
|
||||
#expect(task.maxRetries == 5)
|
||||
#expect(task.autoBlockedReason?.contains("kanban complete") == true)
|
||||
#expect(task.hallucinationGateStatus == "pending")
|
||||
#expect(task.diagnostics.count == 2)
|
||||
#expect(task.diagnostics.first?.kind == "worker_exit_no_complete")
|
||||
#expect(task.diagnostics.last?.detectedAt?.contains("2026") == true)
|
||||
}
|
||||
|
||||
@Test func decodeV012TaskHasNoNewFields() throws {
|
||||
// The most damaging failure mode is a v0.12 user upgrading Scarf
|
||||
// and having the board stop loading because a v0.13-only field
|
||||
// is required. Pin the contract.
|
||||
let json = """
|
||||
{"id": "t_legacy", "title": "v0.12 task", "status": "ready"}
|
||||
"""
|
||||
let task = try JSONDecoder().decode(HermesKanbanTask.self, from: Data(json.utf8))
|
||||
#expect(task.maxRetries == nil)
|
||||
#expect(task.autoBlockedReason == nil)
|
||||
#expect(task.hallucinationGateStatus == nil)
|
||||
#expect(task.diagnostics.isEmpty)
|
||||
}
|
||||
|
||||
@Test func decodeMalformedDiagnosticTolerated() throws {
|
||||
// If Hermes emits a malformed diagnostics value, the rest of the
|
||||
// task should still decode. We use try? on the diagnostics decode
|
||||
// so a single bad entry doesn't reject the whole row.
|
||||
let json = """
|
||||
{
|
||||
"id": "t_x",
|
||||
"title": "x",
|
||||
"status": "ready",
|
||||
"diagnostics": "not-an-array"
|
||||
}
|
||||
"""
|
||||
let task = try JSONDecoder().decode(HermesKanbanTask.self, from: Data(json.utf8))
|
||||
#expect(task.id == "t_x")
|
||||
// Diagnostics field couldn't decode — treat as empty.
|
||||
#expect(task.diagnostics.isEmpty)
|
||||
}
|
||||
|
||||
@Test func hallucinationGateMirrorMapsKnownValues() {
|
||||
#expect(KanbanHallucinationGate.from("pending") == .pending)
|
||||
#expect(KanbanHallucinationGate.from("verified") == .verified)
|
||||
#expect(KanbanHallucinationGate.from("REJECTED") == .rejected) // case-insensitive
|
||||
#expect(KanbanHallucinationGate.from(nil) == nil)
|
||||
#expect(KanbanHallucinationGate.from("") == nil)
|
||||
// Unknown wire values fall through to nil so the banner stays
|
||||
// hidden; future Hermes versions can add `quarantined` etc.
|
||||
// without a Scarf release.
|
||||
#expect(KanbanHallucinationGate.from("quarantined") == nil)
|
||||
}
|
||||
|
||||
@Test func diagnosticKindMirrorMapsKnownValues() {
|
||||
#expect(KanbanDiagnosticKind.from("heartbeat_stalled") == .heartbeatStalled)
|
||||
#expect(KanbanDiagnosticKind.from("DARWIN_ZOMBIE_DETECTED") == .darwinZombieDetected)
|
||||
// Unknown kinds fall through to .unknown so views can render
|
||||
// the raw string verbatim.
|
||||
#expect(KanbanDiagnosticKind.from("future_kind_v014") == .unknown)
|
||||
}
|
||||
|
||||
@Test func diagnosticSeverityMapping() {
|
||||
#expect(KanbanDiagnosticKind.retryCapHit.severity == .danger)
|
||||
#expect(KanbanDiagnosticKind.darwinZombieDetected.severity == .danger)
|
||||
#expect(KanbanDiagnosticKind.heartbeatStalled.severity == .warning)
|
||||
#expect(KanbanDiagnosticKind.workerExitNoComplete.severity == .warning)
|
||||
#expect(KanbanDiagnosticKind.unknown.severity == .neutral)
|
||||
}
|
||||
|
||||
@Test func createRequestArgvIncludesMaxRetries() {
|
||||
let req = KanbanCreateRequest(title: "t", maxRetries: 5)
|
||||
let argv = req.argv()
|
||||
#expect(argv.contains("--max-retries"))
|
||||
#expect(argv.contains("5"))
|
||||
}
|
||||
|
||||
@Test func createRequestArgvOmitsMaxRetriesWhenAbsent() {
|
||||
let req = KanbanCreateRequest(title: "t")
|
||||
let argv = req.argv()
|
||||
#expect(!argv.contains("--max-retries"))
|
||||
}
|
||||
|
||||
@Test func decodeRunWithDiagnostics() throws {
|
||||
let json = """
|
||||
{
|
||||
"id": 1,
|
||||
"task_id": "t_x",
|
||||
"status": "failed",
|
||||
"started_at": 1778160000,
|
||||
"ended_at": 1778160300,
|
||||
"outcome": "crashed",
|
||||
"error": "OOM",
|
||||
"diagnostics": [
|
||||
{"kind": "retry_cap_hit", "message": "3/3 retries exhausted"}
|
||||
],
|
||||
"failure_count": 3
|
||||
}
|
||||
"""
|
||||
let run = try JSONDecoder().decode(HermesKanbanRun.self, from: Data(json.utf8))
|
||||
#expect(run.diagnostics.count == 1)
|
||||
#expect(run.diagnostics.first?.kind == "retry_cap_hit")
|
||||
#expect(run.failureCount == 3)
|
||||
}
|
||||
|
||||
@Test func decodeRunWithoutDiagnostics() throws {
|
||||
// v0.12 run row — no diagnostics, no failure_count, must still
|
||||
// decode cleanly.
|
||||
let json = """
|
||||
{"id": 1, "task_id": "t_x", "status": "running", "started_at": 1778160000}
|
||||
"""
|
||||
let run = try JSONDecoder().decode(HermesKanbanRun.self, from: Data(json.utf8))
|
||||
#expect(run.diagnostics.isEmpty)
|
||||
#expect(run.failureCount == nil)
|
||||
}
|
||||
|
||||
@Test func taskDetailMergesEnvelopeAndTaskDiagnostics() throws {
|
||||
// Hermes's wire shape may put diagnostics on the task envelope OR
|
||||
// on the inner task. `allDiagnostics` dedupes by (kind, detected_at)
|
||||
// so a server emitting both sides doesn't surface dupes.
|
||||
let json = """
|
||||
{
|
||||
"task": {
|
||||
"id": "t_y",
|
||||
"title": "y",
|
||||
"status": "blocked",
|
||||
"diagnostics": [
|
||||
{"kind": "heartbeat_stalled", "detected_at": "2026-05-09T12:00:00Z"}
|
||||
]
|
||||
},
|
||||
"comments": [],
|
||||
"events": [],
|
||||
"diagnostics": [
|
||||
{"kind": "heartbeat_stalled", "detected_at": "2026-05-09T12:00:00Z"},
|
||||
{"kind": "retry_cap_hit"}
|
||||
]
|
||||
}
|
||||
"""
|
||||
let detail = try JSONDecoder().decode(HermesKanbanTaskDetail.self, from: Data(json.utf8))
|
||||
let merged = detail.allDiagnostics
|
||||
#expect(merged.count == 2)
|
||||
#expect(merged.contains(where: { $0.kind == "heartbeat_stalled" }))
|
||||
#expect(merged.contains(where: { $0.kind == "retry_cap_hit" }))
|
||||
}
|
||||
|
||||
@Test func taskDetailWithoutEnvelopeDiagnosticsDecodes() throws {
|
||||
// Pre-v0.13 task detail — no envelope diagnostics. Must decode.
|
||||
let json = """
|
||||
{
|
||||
"task": {"id": "t_z", "title": "z", "status": "ready"},
|
||||
"comments": [],
|
||||
"events": []
|
||||
}
|
||||
"""
|
||||
let detail = try JSONDecoder().decode(HermesKanbanTaskDetail.self, from: Data(json.utf8))
|
||||
#expect(detail.envelopeDiagnostics == nil)
|
||||
#expect(detail.allDiagnostics.isEmpty)
|
||||
}
|
||||
|
||||
@Test func diagnosticDecodesUnixTimestamp() throws {
|
||||
let json = """
|
||||
{"kind": "spawn_failure", "detected_at": 1778160614}
|
||||
"""
|
||||
let diag = try JSONDecoder().decode(HermesKanbanDiagnostic.self, from: Data(json.utf8))
|
||||
#expect(diag.kind == "spawn_failure")
|
||||
// Decoder normalizes Unix int → ISO-8601 string.
|
||||
#expect(diag.detectedAt?.contains("2026") == true)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -310,6 +310,74 @@ import Foundation
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - ModelCatalogService — WS-6 (v0.13)
|
||||
|
||||
@Test func vercelAIGatewayDemotedToBottom() throws {
|
||||
// Build a minimal catalog with vercel + alphabetically-later
|
||||
// providers, then assert vercel sorts after them. Locks the
|
||||
// demoted-axis sort comparator added in WS-6.
|
||||
let json = """
|
||||
{
|
||||
"anthropic": { "name": "Anthropic", "models": {} },
|
||||
"vercel": { "name": "Vercel AI Gateway", "models": {} },
|
||||
"zonk": { "name": "Zonk Provider", "models": {} }
|
||||
}
|
||||
"""
|
||||
let tmp = FileManager.default.temporaryDirectory
|
||||
.appendingPathComponent("scarf-models-\(UUID().uuidString).json")
|
||||
try json.write(to: tmp, atomically: true, encoding: .utf8)
|
||||
defer { try? FileManager.default.removeItem(at: tmp) }
|
||||
let svc = ModelCatalogService(path: tmp.path)
|
||||
let providers = svc.loadProviders().filter { !$0.isOverlay }
|
||||
let names = providers.map(\.providerName)
|
||||
// anthropic first (alpha), zonk next (alpha), vercel last
|
||||
// (demoted) — even though `vercel` < `zonk` alphabetically.
|
||||
#expect(names.last == "Vercel AI Gateway")
|
||||
let vercelIdx = names.firstIndex(of: "Vercel AI Gateway") ?? -1
|
||||
let zonkIdx = names.firstIndex(of: "Zonk Provider") ?? -1
|
||||
#expect(vercelIdx > zonkIdx)
|
||||
}
|
||||
|
||||
@Test func grok420BetaAliasResolvesToGrok420() {
|
||||
let svc = ModelCatalogService(path: "/tmp/scarf-nonexistent-\(UUID().uuidString).json")
|
||||
// OpenRouter's old `-beta` ID resolves to the GA name.
|
||||
#expect(svc.resolveModelAlias(providerID: "openrouter", modelID: "x-ai/grok-4.20-beta")
|
||||
== "x-ai/grok-4.20")
|
||||
// xAI direct provider keeps the same shape minus prefix.
|
||||
#expect(svc.resolveModelAlias(providerID: "xai", modelID: "grok-4.20-beta")
|
||||
== "grok-4.20")
|
||||
// Non-aliased ID passes through unchanged.
|
||||
#expect(svc.resolveModelAlias(providerID: "anthropic", modelID: "claude-4.7-opus")
|
||||
== "claude-4.7-opus")
|
||||
// Cross-provider isolation: same modelID on a different
|
||||
// provider isn't aliased — composite key in `modelAliases`
|
||||
// disambiguates by providerID.
|
||||
#expect(svc.resolveModelAlias(providerID: "fictional", modelID: "x-ai/grok-4.20-beta")
|
||||
== "x-ai/grok-4.20-beta")
|
||||
}
|
||||
|
||||
@Test func imageGenModelAllowlistShape() {
|
||||
// Lock the curated list size + a few sentinel entries so
|
||||
// unintentional edits get caught in review. Free-form-typing
|
||||
// bypasses the allowlist, so additions/removals here are
|
||||
// purely UX (which models surface as picker rows).
|
||||
let models = ModelCatalogService.imageGenModels
|
||||
#expect(models.count >= 5)
|
||||
#expect(models.contains(where: { $0.modelID == "openai/gpt-image-1" }))
|
||||
#expect(models.contains(where: { $0.modelID == "google/imagen-4" }))
|
||||
// Every entry has a non-empty display + a non-empty modelID.
|
||||
for m in models {
|
||||
#expect(!m.modelID.isEmpty)
|
||||
#expect(!m.display.isEmpty)
|
||||
}
|
||||
}
|
||||
|
||||
@Test func demotedProvidersContainsVercel() {
|
||||
// Minimal lock-in for the demoted-providers static set. Mirrors
|
||||
// Hermes's deprioritized-provider list in providers.py.
|
||||
#expect(ModelCatalogService.demotedProviders.contains("vercel"))
|
||||
}
|
||||
|
||||
// MARK: - ProjectDashboardService
|
||||
|
||||
@Test func projectDashboardServiceRegistryRoundTrip() throws {
|
||||
|
||||
@@ -92,6 +92,27 @@ import Foundation
|
||||
#expect(c.security.redactSecrets == true)
|
||||
#expect(c.compression.enabled == true)
|
||||
#expect(c.voice.ttsProvider == "edge")
|
||||
// v0.13 additions default to empty / off when the YAML omits
|
||||
// them — pre-v0.13 hosts produce this exact shape.
|
||||
#expect(c.imageGenModel == "")
|
||||
#expect(c.openrouterResponseCacheEnabled == false)
|
||||
}
|
||||
|
||||
@Test func parsesImageGenAndOpenRouterCache() {
|
||||
// WS-6: round-trip the two new top-level v0.13 keys. If the
|
||||
// OpenRouter key shape changes upstream (see TODO(WS-6-Q1)),
|
||||
// this test is the single touchpoint that pins the parser
|
||||
// line + setter key + UI binding to a single shape.
|
||||
let yaml = """
|
||||
image_gen:
|
||||
model: openai/gpt-image-1
|
||||
openrouter:
|
||||
response_cache:
|
||||
enabled: true
|
||||
"""
|
||||
let c = HermesConfig(yaml: yaml)
|
||||
#expect(c.imageGenModel == "openai/gpt-image-1")
|
||||
#expect(c.openrouterResponseCacheEnabled == true)
|
||||
}
|
||||
|
||||
@Test func parsesTopLevelModel() {
|
||||
@@ -228,6 +249,87 @@ import Foundation
|
||||
#expect(c.timezone == "America/New_York")
|
||||
}
|
||||
|
||||
// MARK: - v0.13 gateway.platforms.<platform> block
|
||||
|
||||
@Test func gatewayPlatformsEmptyByDefault() {
|
||||
let c = HermesConfig(yaml: "")
|
||||
#expect(c.gatewayPlatforms.isEmpty)
|
||||
}
|
||||
|
||||
@Test func parsesGatewayAllowlistsForSlack() {
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
allowed_channels:
|
||||
- C01
|
||||
- C02
|
||||
busy_ack_enabled: false
|
||||
gateway_restart_notification: true
|
||||
slash_command_notice_ttl_seconds: 120
|
||||
"""
|
||||
let cfg = HermesConfig(yaml: yaml)
|
||||
let block = cfg.gatewayPlatforms["slack"]
|
||||
#expect(block?.allowedChannels == ["C01", "C02"])
|
||||
#expect(block?.busyAckEnabled == false)
|
||||
#expect(block?.gatewayRestartNotification == true)
|
||||
#expect(block?.slashCommandNoticeTTLSeconds == 120)
|
||||
}
|
||||
|
||||
@Test func parsesGatewayAllowlistsForTelegramAndMatrix() {
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
telegram:
|
||||
allowed_chats:
|
||||
- '@alice'
|
||||
- '12345'
|
||||
matrix:
|
||||
allowed_rooms:
|
||||
- '!room:matrix.org'
|
||||
"""
|
||||
let cfg = HermesConfig(yaml: yaml)
|
||||
#expect(cfg.gatewayPlatforms["telegram"]?.allowedChats == ["@alice", "12345"])
|
||||
#expect(cfg.gatewayPlatforms["matrix"]?.allowedRooms == ["!room:matrix.org"])
|
||||
}
|
||||
|
||||
@Test func gatewayBlockCoexistsWithLegacyPlatformBlocks() {
|
||||
// Regression: legacy `platforms.slack.reply_to_mode` and
|
||||
// `matrix.require_mention` must keep parsing when the new
|
||||
// `gateway:` block is also present — no key collisions.
|
||||
let yaml = """
|
||||
platforms:
|
||||
slack:
|
||||
reply_to_mode: all
|
||||
matrix:
|
||||
require_mention: false
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
allowed_channels:
|
||||
- C01
|
||||
"""
|
||||
let cfg = HermesConfig(yaml: yaml)
|
||||
#expect(cfg.slack.replyToMode == "all")
|
||||
#expect(cfg.matrix.requireMention == false)
|
||||
#expect(cfg.gatewayPlatforms["slack"]?.allowedChannels == ["C01"])
|
||||
}
|
||||
|
||||
@Test func gatewayPlatformsSkipsPlatformsWithoutV013Keys() {
|
||||
// The `gateway:` block exists but only Slack has a v0.13 key —
|
||||
// platforms without keys must NOT appear in `gatewayPlatforms`.
|
||||
let yaml = """
|
||||
gateway:
|
||||
platforms:
|
||||
slack:
|
||||
busy_ack_enabled: true
|
||||
"""
|
||||
let cfg = HermesConfig(yaml: yaml)
|
||||
#expect(cfg.gatewayPlatforms["slack"] != nil)
|
||||
#expect(cfg.gatewayPlatforms["mattermost"] == nil)
|
||||
#expect(cfg.gatewayPlatforms["telegram"] == nil)
|
||||
}
|
||||
|
||||
@Test func cronScheduleMemberwise() {
|
||||
let s = CronSchedule(
|
||||
kind: "cron",
|
||||
|
||||
@@ -241,6 +241,150 @@ import Foundation
|
||||
#expect(a == b)
|
||||
}
|
||||
|
||||
// MARK: - v0.13 non-interruptive commands (WS-2 / Persistent Goals + /queue)
|
||||
|
||||
@Test func nonInterruptiveListIncludesGoalAndQueue() {
|
||||
let names = RichChatViewModel.nonInterruptiveCommands.map(\.name)
|
||||
#expect(names.contains("steer"))
|
||||
#expect(names.contains("goal"))
|
||||
#expect(names.contains("queue"))
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func availableCommandsHidesGoalWhenCapabilityOff() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
vm.publishCapabilities(.empty)
|
||||
let names = vm.availableCommands.map(\.name)
|
||||
#expect(!names.contains("goal"))
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func availableCommandsHidesQueueWhenCapabilityOff() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
vm.publishCapabilities(.empty)
|
||||
let names = vm.availableCommands.map(\.name)
|
||||
#expect(!names.contains("queue"))
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func availableCommandsExposesAllThreeOnV013() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
let caps = HermesCapabilities.parseLine("Hermes Agent v0.13.0 (2026.5.7)")
|
||||
vm.publishCapabilities(caps)
|
||||
let names = vm.availableCommands.map(\.name)
|
||||
#expect(names.contains("steer"))
|
||||
#expect(names.contains("goal"))
|
||||
#expect(names.contains("queue"))
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func availableCommandsExposesSteerButHidesV013OnV012() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
let caps = HermesCapabilities.parseLine("Hermes Agent v0.12.0 (2026.4.30)")
|
||||
vm.publishCapabilities(caps)
|
||||
let names = vm.availableCommands.map(\.name)
|
||||
#expect(names.contains("steer"))
|
||||
#expect(!names.contains("goal"))
|
||||
#expect(!names.contains("queue"))
|
||||
}
|
||||
|
||||
@Test func parseGoalArgumentRecognizesClearVariants() {
|
||||
#expect(RichChatViewModel.parseGoalArgument("--clear") == .clear)
|
||||
#expect(RichChatViewModel.parseGoalArgument("clear") == .clear)
|
||||
#expect(RichChatViewModel.parseGoalArgument("Clear") == .clear)
|
||||
#expect(RichChatViewModel.parseGoalArgument(" --clear ") == .clear)
|
||||
}
|
||||
|
||||
@Test func parseGoalArgumentReturnsSetForArbitraryText() {
|
||||
#expect(
|
||||
RichChatViewModel.parseGoalArgument("finish v2.8 on time")
|
||||
== .set("finish v2.8 on time")
|
||||
)
|
||||
// Whitespace around set text is trimmed.
|
||||
#expect(
|
||||
RichChatViewModel.parseGoalArgument(" ship it ")
|
||||
== .set("ship it")
|
||||
)
|
||||
}
|
||||
|
||||
@Test func parseGoalArgumentReturnsEmptyForBlank() {
|
||||
#expect(RichChatViewModel.parseGoalArgument("") == .empty)
|
||||
#expect(RichChatViewModel.parseGoalArgument(" ") == .empty)
|
||||
#expect(RichChatViewModel.parseGoalArgument("\n\t") == .empty)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func recordActiveGoalSetsAndClears() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
#expect(vm.activeGoal == nil)
|
||||
vm.recordActiveGoal(text: "ship v2.8")
|
||||
let goal = vm.activeGoal
|
||||
#expect(goal?.text == "ship v2.8")
|
||||
vm.recordActiveGoal(text: nil)
|
||||
#expect(vm.activeGoal == nil)
|
||||
// Empty / whitespace also clears.
|
||||
vm.recordActiveGoal(text: "x")
|
||||
vm.recordActiveGoal(text: " ")
|
||||
#expect(vm.activeGoal == nil)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func recordQueuedPromptAppendsAndPopsFIFO() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
vm.recordQueuedPrompt(text: "first")
|
||||
vm.recordQueuedPrompt(text: "second")
|
||||
vm.recordQueuedPrompt(text: "third")
|
||||
#expect(vm.queuedPrompts.count == 3)
|
||||
let popped = vm.popQueuedPrompt()
|
||||
#expect(popped?.text == "first")
|
||||
#expect(vm.queuedPrompts.count == 2)
|
||||
let next = vm.popQueuedPrompt()
|
||||
#expect(next?.text == "second")
|
||||
#expect(vm.queuedPrompts.first?.text == "third")
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func recordQueuedPromptIgnoresBlank() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
vm.recordQueuedPrompt(text: "")
|
||||
vm.recordQueuedPrompt(text: " ")
|
||||
#expect(vm.queuedPrompts.isEmpty)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func popQueuedPromptOnEmptyReturnsNil() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
#expect(vm.popQueuedPrompt() == nil)
|
||||
}
|
||||
|
||||
@Test func isNonInterruptiveSlashRecognizesGoalAndQueue() {
|
||||
// Non-MainActor: the helper itself isn't MainActor-isolated;
|
||||
// construct a VM on MainActor and read through it on the test
|
||||
// actor to keep the assertion focused on classification.
|
||||
Task { @MainActor in
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
#expect(vm.isNonInterruptiveSlash("/goal finish v2.8"))
|
||||
#expect(vm.isNonInterruptiveSlash("/queue summarize"))
|
||||
#expect(vm.isNonInterruptiveSlash("/queue"))
|
||||
#expect(vm.isNonInterruptiveSlash("/steer be careful"))
|
||||
#expect(!vm.isNonInterruptiveSlash("hello"))
|
||||
#expect(!vm.isNonInterruptiveSlash("/compress"))
|
||||
}
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test func resetClearsGoalAndQueue() {
|
||||
let vm = RichChatViewModel(context: .local)
|
||||
vm.recordActiveGoal(text: "x")
|
||||
vm.recordQueuedPrompt(text: "a")
|
||||
vm.recordQueuedPrompt(text: "b")
|
||||
#expect(vm.activeGoal != nil)
|
||||
#expect(vm.queuedPrompts.count == 2)
|
||||
vm.reset()
|
||||
#expect(vm.activeGoal == nil)
|
||||
#expect(vm.queuedPrompts.isEmpty)
|
||||
}
|
||||
|
||||
// MARK: - Helpers
|
||||
|
||||
static func makeTempProject() throws -> String {
|
||||
|
||||
@@ -44,6 +44,19 @@ struct ChatView: View {
|
||||
private var supportsImagePrompts: Bool {
|
||||
capabilitiesStore?.capabilities.hasACPImagePrompts ?? false
|
||||
}
|
||||
|
||||
/// v0.13 `/goal` capability — drives the goal pill in `projectContextBar`.
|
||||
/// Read-only on iOS in v2.8.0; users send `/goal` from the Mac. The pill
|
||||
/// drops automatically when `vm.activeGoal` clears.
|
||||
private var supportsActiveGoal: Bool {
|
||||
capabilitiesStore?.capabilities.hasGoals ?? false
|
||||
}
|
||||
|
||||
/// v0.13 ACP `/queue` capability — drives the queue-count chip. Tap is a
|
||||
/// no-op in v2.8.0 (no popover); previews live on the Mac app.
|
||||
private var supportsACPQueue: Bool {
|
||||
capabilitiesStore?.capabilities.hasACPQueue ?? false
|
||||
}
|
||||
/// Drives the composer's keyboard. Bound to the TextField via
|
||||
/// `.focused(...)`; cleared by the scroll-to-dismiss gesture on
|
||||
/// the message list AND by an explicit keyboard-toolbar button.
|
||||
@@ -109,6 +122,17 @@ struct ChatView: View {
|
||||
}
|
||||
)
|
||||
}
|
||||
// Forward the env-injected capabilities snapshot into the
|
||||
// shared `RichChatViewModel` whenever it changes. Drives the
|
||||
// capability gate `RichChatViewModel.availableCommands` reads.
|
||||
// Mirrors the Mac `ChatView` plumbing — the iOS chat surface
|
||||
// doesn't render `/goal` / `/queue` UI yet (deferred to WS-9),
|
||||
// but the VM-side state has to stay aligned across platforms
|
||||
// so the Mac surface is correct after a cross-device session
|
||||
// resume.
|
||||
.task(id: capabilitiesStore?.capabilities.versionLine ?? "") {
|
||||
controller.vm.publishCapabilities(capabilitiesStore?.capabilities ?? .empty)
|
||||
}
|
||||
.task {
|
||||
// Dashboard row taps set `pendingResumeSessionID`, Project
|
||||
// Detail's "New Chat" sets `pendingProjectChat`. Both fire
|
||||
@@ -830,37 +854,47 @@ struct ChatView: View {
|
||||
/// informational.
|
||||
@ViewBuilder
|
||||
private var projectContextBar: some View {
|
||||
if let projectName = controller.currentProjectName,
|
||||
!projectName.isEmpty
|
||||
{
|
||||
// v2.8.0 (WS-9): the bar is no longer project-only — a non-empty
|
||||
// active goal OR a non-empty queue mirror also light it up. Project
|
||||
// chip, goal pill, and queue chip render independently and the bar
|
||||
// shows when ANY of them is present.
|
||||
let projectName = controller.currentProjectName ?? ""
|
||||
let hasProject = !projectName.isEmpty
|
||||
let hasGoal = supportsActiveGoal && controller.vm.activeGoal != nil
|
||||
let hasQueue = supportsACPQueue && !controller.vm.queuedPrompts.isEmpty
|
||||
if hasProject || hasGoal || hasQueue {
|
||||
HStack(spacing: 8) {
|
||||
Image(systemName: "folder.fill")
|
||||
.foregroundStyle(.tint)
|
||||
.font(.caption)
|
||||
VStack(alignment: .leading, spacing: 1) {
|
||||
Text("Project chat")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
HStack(spacing: 6) {
|
||||
Text(projectName)
|
||||
.font(.callout.weight(.medium))
|
||||
.foregroundStyle(.primary)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.tail)
|
||||
if let branch = controller.currentGitBranch, !branch.isEmpty {
|
||||
Label(branch, systemImage: "arrow.triangle.branch")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.tint)
|
||||
.labelStyle(.titleAndIcon)
|
||||
.padding(.horizontal, 5)
|
||||
.padding(.vertical, 1)
|
||||
.background(.tint.opacity(0.15), in: Capsule())
|
||||
if hasProject {
|
||||
Image(systemName: "folder.fill")
|
||||
.foregroundStyle(.tint)
|
||||
.font(.caption)
|
||||
VStack(alignment: .leading, spacing: 1) {
|
||||
Text("Project chat")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
HStack(spacing: 6) {
|
||||
Text(projectName)
|
||||
.font(.callout.weight(.medium))
|
||||
.foregroundStyle(.primary)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.tail)
|
||||
if let branch = controller.currentGitBranch, !branch.isEmpty {
|
||||
Label(branch, systemImage: "arrow.triangle.branch")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.tint)
|
||||
.labelStyle(.titleAndIcon)
|
||||
.padding(.horizontal, 5)
|
||||
.padding(.vertical, 1)
|
||||
.background(.tint.opacity(0.15), in: Capsule())
|
||||
.lineLimit(1)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if hasGoal { goalChip }
|
||||
if hasQueue { queueChip }
|
||||
Spacer()
|
||||
if !controller.vm.projectScopedCommands.isEmpty {
|
||||
if hasProject && !controller.vm.projectScopedCommands.isEmpty {
|
||||
Button {
|
||||
showSlashCommandsSheet = true
|
||||
} label: {
|
||||
@@ -882,6 +916,8 @@ struct ChatView: View {
|
||||
.padding(.vertical, 6)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.background(.tint.opacity(0.1))
|
||||
.animation(.spring(response: 0.3, dampingFraction: 0.75), value: hasGoal)
|
||||
.animation(.spring(response: 0.3, dampingFraction: 0.75), value: hasQueue)
|
||||
.sheet(isPresented: $showSlashCommandsSheet) {
|
||||
ProjectSlashCommandsBrowser(
|
||||
projectName: projectName,
|
||||
@@ -891,6 +927,55 @@ struct ChatView: View {
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 goal pill — purely informational mirror of the agent's
|
||||
/// currently-locked `/goal`. Read-only on iOS; `/goal --clear` lives on
|
||||
/// the Mac app and the pill drops on the next VM update. Semantic
|
||||
/// `.subheadline` font so the goal text scales with Dynamic Type
|
||||
/// (it's content the user reads, not chrome). VoiceOver gets the full
|
||||
/// untruncated text via the accessibility label.
|
||||
@ViewBuilder
|
||||
private var goalChip: some View {
|
||||
if let goal = controller.vm.activeGoal {
|
||||
Label(truncatedGoalText(goal.text), systemImage: "scope")
|
||||
.labelStyle(.titleAndIcon)
|
||||
.font(.subheadline)
|
||||
.foregroundStyle(ScarfColor.info)
|
||||
.padding(.horizontal, 8)
|
||||
.padding(.vertical, 3)
|
||||
.background(ScarfColor.info.opacity(0.16), in: Capsule())
|
||||
.lineLimit(1)
|
||||
.accessibilityLabel("Goal locked: \(goal.text)")
|
||||
.transition(.opacity.combined(with: .scale(scale: 0.92)))
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 queue chip — read-only count of prompts queued via `/queue`.
|
||||
/// Tap is a no-op in v2.8.0 (no popover); the source of truth lives on
|
||||
/// the Mac app. Defaults to one fixed pill regardless of count.
|
||||
@ViewBuilder
|
||||
private var queueChip: some View {
|
||||
let count = controller.vm.queuedPrompts.count
|
||||
if count > 0 {
|
||||
Label("\(count) queued", systemImage: "tray.full")
|
||||
.labelStyle(.titleAndIcon)
|
||||
.font(.caption.weight(.medium))
|
||||
.foregroundStyle(.tint)
|
||||
.padding(.horizontal, 8)
|
||||
.padding(.vertical, 3)
|
||||
.background(.tint.opacity(0.18), in: Capsule())
|
||||
.lineLimit(1)
|
||||
.accessibilityLabel("\(count) prompt\(count == 1 ? "" : "s") queued — manage on the Mac app")
|
||||
.transition(.opacity.combined(with: .scale(scale: 0.92)))
|
||||
}
|
||||
}
|
||||
|
||||
/// Trim long goal text to fit a chip beside the project name on iPhone
|
||||
/// portrait. The full text rides VoiceOver via the chip's accessibility
|
||||
/// label.
|
||||
private func truncatedGoalText(_ text: String) -> String {
|
||||
text.count <= 28 ? text : String(text.prefix(25)) + "…"
|
||||
}
|
||||
|
||||
/// Shown while we're opening the SSH exec channel + spawning
|
||||
/// `hermes acp` + creating the ACP session. Typically ~0.5–1.5 s
|
||||
/// on a warm network — silent before this overlay existed, which
|
||||
@@ -1307,18 +1392,48 @@ final class ChatController {
|
||||
// even when they didn't type any caption.
|
||||
vm.addUserMessage(text: "[image attached]")
|
||||
}
|
||||
// /steer is non-interruptive — the agent is still on its
|
||||
// current turn; the guidance applies after the next tool call.
|
||||
// Surface a transient toast confirming the guidance was
|
||||
// received. v2.5 / Hermes v2026.4.23+.
|
||||
if vm.isNonInterruptiveSlash(text) {
|
||||
vm.transientHint = "Guidance queued — applies after the next tool call."
|
||||
Task { @MainActor [weak vm] in
|
||||
try? await Task.sleep(nanoseconds: 4_000_000_000)
|
||||
if vm?.transientHint == "Guidance queued — applies after the next tool call." {
|
||||
vm?.transientHint = nil
|
||||
}
|
||||
// Non-interruptive slash commands: keep the chat working
|
||||
// indicator off and surface a transient toast confirming the
|
||||
// command was accepted. v2.5 added `/steer`; v2.8 / Hermes
|
||||
// v0.13 adds `/goal` (lock the agent on a target across
|
||||
// turns) and `/queue` (queue a prompt for after the current
|
||||
// turn). Each gets its own optimistic side-effect on the VM
|
||||
// so the (Mac-rendered) chat header pill / queue chip update
|
||||
// synchronously. iOS doesn't surface those affordances yet
|
||||
// (WS-9), but mirroring the dispatch keeps the shared VM
|
||||
// state aligned across platforms — otherwise an iOS user who
|
||||
// ran `/goal` then opened the same session on Mac would see
|
||||
// an empty pill until they typed `/goal` again.
|
||||
let parsedSlash = Self.parseSlashName(text)
|
||||
switch parsedSlash.name {
|
||||
case "goal":
|
||||
// TODO(WS-2-Q7): verify on a real v0.13 host.
|
||||
let arg = RichChatViewModel.parseGoalArgument(parsedSlash.args)
|
||||
switch arg {
|
||||
case .set(let goalText):
|
||||
vm.recordActiveGoal(text: goalText)
|
||||
vm.transientHint = "Goal locked: \(Self.truncatedToastGoal(goalText))"
|
||||
case .clear:
|
||||
vm.recordActiveGoal(text: nil)
|
||||
vm.transientHint = "Goal cleared."
|
||||
case .empty:
|
||||
vm.transientHint = "Sent /goal — see the agent reply for current goal."
|
||||
}
|
||||
scheduleTransientHintClear(snapshot: vm.transientHint)
|
||||
case "queue":
|
||||
// TODO(WS-2-Q5): verify the verbatim wire shape on a
|
||||
// real v0.13 ACP host.
|
||||
let queuedText = parsedSlash.args.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if !queuedText.isEmpty {
|
||||
vm.recordQueuedPrompt(text: queuedText)
|
||||
}
|
||||
vm.transientHint = "Queued — runs after current turn."
|
||||
scheduleTransientHintClear(snapshot: vm.transientHint)
|
||||
case "steer" where vm.isNonInterruptiveSlash(text):
|
||||
vm.transientHint = "Guidance queued — applies after the next tool call."
|
||||
scheduleTransientHintClear(snapshot: vm.transientHint)
|
||||
default:
|
||||
break
|
||||
}
|
||||
// Project-scoped slash commands expand client-side: the user
|
||||
// bubble shows the literal `/<name> args` they typed (above);
|
||||
@@ -1341,6 +1456,43 @@ final class ChatController {
|
||||
}
|
||||
}
|
||||
|
||||
/// Pull `(name, argTail)` out of a `/<name> [args]` invocation.
|
||||
/// Mirror of `ChatViewModel.parseSlashName` on Mac. Returns
|
||||
/// `(nil, "")` for non-slash input.
|
||||
static func parseSlashName(_ text: String) -> (name: String?, args: String) {
|
||||
let trimmed = text.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
guard trimmed.hasPrefix("/") else { return (nil, "") }
|
||||
let withoutSlash = trimmed.dropFirst()
|
||||
if let space = withoutSlash.firstIndex(of: " ") {
|
||||
return (
|
||||
name: String(withoutSlash[..<space]),
|
||||
args: String(withoutSlash[withoutSlash.index(after: space)...])
|
||||
)
|
||||
}
|
||||
return (name: String(withoutSlash), args: "")
|
||||
}
|
||||
|
||||
/// Cap goal text in transient toasts so a 1 KB user-typed goal
|
||||
/// doesn't blow out the hint pill. Mirror of
|
||||
/// `ChatViewModel.truncatedToastGoal`.
|
||||
static func truncatedToastGoal(_ text: String) -> String {
|
||||
text.count <= 60 ? text : String(text.prefix(57)) + "…"
|
||||
}
|
||||
|
||||
/// Auto-clear the chat composer's transient hint after 4s. Mirror
|
||||
/// of `ChatViewModel.scheduleHintClear` — uses a value snapshot
|
||||
/// rather than identity so a later toast that reuses the same
|
||||
/// string still triggers the clear once the latest value matches.
|
||||
@MainActor
|
||||
private func scheduleTransientHintClear(snapshot: String?) {
|
||||
Task { @MainActor [weak vm] in
|
||||
try? await Task.sleep(nanoseconds: 4_000_000_000)
|
||||
if vm?.transientHint == snapshot {
|
||||
vm?.transientHint = nil
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Mirror of `ChatViewModel.expandIfProjectScoped(_:)` on Mac.
|
||||
/// `/<name> args` matching a loaded project-scoped command is
|
||||
/// expanded; everything else is sent literally.
|
||||
|
||||
@@ -13,11 +13,21 @@ import ScarfDesign
|
||||
/// `HermesCapabilities.hasCurator` is true.
|
||||
struct CuratorView: View {
|
||||
@State private var viewModel: CuratorViewModel
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
init(context: ServerContext) {
|
||||
_viewModel = State(initialValue: CuratorViewModel(context: context))
|
||||
}
|
||||
|
||||
/// v0.13 capability gate. Drives both the synchronous `runNow`
|
||||
/// blocking-with-spinner behavior AND the read-only Archived
|
||||
/// section. Pre-v0.13 hosts skip the archive load entirely so we
|
||||
/// don't spam `hermes curator list-archived` against a binary that
|
||||
/// would error out.
|
||||
private var archiveAvailable: Bool {
|
||||
capabilitiesStore?.capabilities.hasCuratorArchive ?? false
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
List {
|
||||
Section {
|
||||
@@ -78,18 +88,88 @@ struct CuratorView: View {
|
||||
.textSelection(.enabled)
|
||||
}
|
||||
}
|
||||
|
||||
if archiveAvailable {
|
||||
archivedSection
|
||||
}
|
||||
}
|
||||
.navigationTitle("Curator")
|
||||
.navigationBarTitleDisplayMode(.large)
|
||||
.refreshable {
|
||||
await viewModel.load()
|
||||
if archiveAvailable {
|
||||
await viewModel.loadArchive()
|
||||
}
|
||||
}
|
||||
.overlay(alignment: .bottom) {
|
||||
if let toast = viewModel.transientMessage {
|
||||
toastView(toast)
|
||||
}
|
||||
}
|
||||
.task { await viewModel.load() }
|
||||
.task {
|
||||
await viewModel.load()
|
||||
if archiveAvailable {
|
||||
await viewModel.loadArchive()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 read-only Archived list. iOS doesn't expose Restore /
|
||||
/// Prune-this / Prune-all — that's a Mac-only surface in v2.8.0.
|
||||
/// The footer signposts the user to the Mac app when there are
|
||||
/// rows to act on.
|
||||
@ViewBuilder
|
||||
private var archivedSection: some View {
|
||||
Section {
|
||||
if viewModel.archivedSkills.isEmpty {
|
||||
Text("No archived skills — Curator will move stale skills here after the next review cycle.")
|
||||
.font(.callout)
|
||||
.foregroundStyle(.secondary)
|
||||
} else {
|
||||
ForEach(viewModel.archivedSkills) { skill in
|
||||
archivedRow(skill)
|
||||
}
|
||||
}
|
||||
} header: {
|
||||
Text("Archived")
|
||||
} footer: {
|
||||
if !viewModel.archivedSkills.isEmpty {
|
||||
Text("Restore or prune archived skills from the Mac app.")
|
||||
.font(.caption)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private func archivedRow(_ skill: HermesCuratorArchivedSkill) -> some View {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
HStack {
|
||||
Text(skill.name)
|
||||
.font(.body)
|
||||
.lineLimit(1)
|
||||
Spacer()
|
||||
if let category = skill.category, !category.isEmpty {
|
||||
ScarfBadge(category, kind: .neutral)
|
||||
}
|
||||
}
|
||||
HStack(spacing: 6) {
|
||||
if let reason = skill.reason, !reason.isEmpty {
|
||||
Text(reason)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.lineLimit(2)
|
||||
}
|
||||
Spacer()
|
||||
Text(skill.archivedAtLabel)
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.tertiary)
|
||||
}
|
||||
if let size = skill.sizeBytes, size > 0 {
|
||||
Text(skill.sizeLabel)
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.tertiary)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var statusRow: some View {
|
||||
@@ -115,7 +195,7 @@ struct CuratorView: View {
|
||||
private var actionFooter: some View {
|
||||
HStack(spacing: 8) {
|
||||
Button {
|
||||
Task { await viewModel.runNow() }
|
||||
Task { await viewModel.runNow(synchronous: archiveAvailable, timeout: 600) }
|
||||
} label: {
|
||||
Label("Run now", systemImage: "play.fill")
|
||||
}
|
||||
|
||||
@@ -0,0 +1,86 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// iOS substitute for the Mac inspector's `.help()` tooltip on a Kanban
|
||||
/// diagnostic chip. iOS doesn't have hover, so each diagnostic chip in
|
||||
/// the detail sheet is tappable; tap presents this sheet with the kind,
|
||||
/// severity, server-supplied message, and detection timestamp.
|
||||
///
|
||||
/// Read-only — there are no recovery actions on iOS in v2.8.0. The
|
||||
/// surface is deliberately small (one screen, no scroll padding) so it
|
||||
/// reads as a fast peek rather than a full editor.
|
||||
struct DiagnosticDetailSheet: View {
|
||||
let diagnostic: HermesKanbanDiagnostic
|
||||
|
||||
@Environment(\.dismiss) private var dismiss
|
||||
|
||||
var body: some View {
|
||||
NavigationStack {
|
||||
List {
|
||||
Section {
|
||||
LabeledContent("Kind") {
|
||||
Text(diagnostic.kind)
|
||||
.font(.body.monospaced())
|
||||
.foregroundStyle(.primary)
|
||||
}
|
||||
LabeledContent("Severity") {
|
||||
ScarfBadge(severityLabel, kind: severityBadgeKind)
|
||||
}
|
||||
if let detectedAt = diagnostic.detectedAt, !detectedAt.isEmpty {
|
||||
LabeledContent("Detected at") {
|
||||
Text(detectedAt)
|
||||
.font(.caption.monospaced())
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
} header: {
|
||||
Text("Diagnostic")
|
||||
}
|
||||
|
||||
if let message = diagnostic.message, !message.isEmpty {
|
||||
Section {
|
||||
Text(message)
|
||||
.font(.body)
|
||||
.textSelection(.enabled)
|
||||
} header: {
|
||||
Text("Message")
|
||||
}
|
||||
}
|
||||
|
||||
Section {
|
||||
Label("Recovery actions live on the Mac app — open this task there to verify, reject, or unblock.", systemImage: "info.circle")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
.scrollContentBackground(.hidden)
|
||||
.background(ScarfColor.backgroundPrimary)
|
||||
.navigationTitle("Diagnostic")
|
||||
.navigationBarTitleDisplayMode(.inline)
|
||||
.toolbar {
|
||||
ToolbarItem(placement: .topBarTrailing) {
|
||||
Button("Done") { dismiss() }
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var severityLabel: String {
|
||||
let kind = KanbanDiagnosticKind.from(diagnostic.kind)
|
||||
switch kind.severity {
|
||||
case .danger: return "danger"
|
||||
case .warning: return "warning"
|
||||
case .neutral: return "neutral"
|
||||
}
|
||||
}
|
||||
|
||||
private var severityBadgeKind: ScarfBadgeKind {
|
||||
let kind = KanbanDiagnosticKind.from(diagnostic.kind)
|
||||
switch kind.severity {
|
||||
case .danger: return .danger
|
||||
case .warning: return .warning
|
||||
case .neutral: return .neutral
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -15,12 +15,14 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
let context: ServerContext
|
||||
|
||||
@Environment(\.dismiss) private var dismiss
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
@State private var detail: HermesKanbanTaskDetail?
|
||||
@State private var runs: [HermesKanbanRun] = []
|
||||
@State private var isLoading = true
|
||||
@State private var error: String?
|
||||
@State private var selectedTab: DetailTab = .comments
|
||||
@State private var selectedDiagnostic: HermesKanbanDiagnostic?
|
||||
|
||||
enum DetailTab: String, CaseIterable, Identifiable {
|
||||
case comments = "Comments"
|
||||
@@ -29,6 +31,13 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
var id: String { rawValue }
|
||||
}
|
||||
|
||||
/// v0.13 capability gate. Defensive default `false` when no
|
||||
/// capabilities store is present (preview / smoke harness) so the
|
||||
/// sheet renders the v2.7.5 layout unchanged.
|
||||
private var diagnosticsAvailable: Bool {
|
||||
capabilitiesStore?.capabilities.hasKanbanDiagnostics ?? false
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
NavigationStack {
|
||||
content
|
||||
@@ -41,6 +50,9 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
}
|
||||
}
|
||||
.task(id: taskId) { await load() }
|
||||
.sheet(item: $selectedDiagnostic) { diag in
|
||||
DiagnosticDetailSheet(diagnostic: diag)
|
||||
}
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
@@ -62,6 +74,8 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: 16) {
|
||||
headerCard(detail.task)
|
||||
hallucinationBadge(detail.task)
|
||||
autoBlockedBanner(detail.task)
|
||||
if let body = detail.task.body, !body.isEmpty {
|
||||
if let attributed = try? AttributedString(markdown: body) {
|
||||
Text(attributed)
|
||||
@@ -71,6 +85,9 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
.font(.body)
|
||||
}
|
||||
}
|
||||
if diagnosticsAvailable, !detail.task.diagnostics.isEmpty {
|
||||
diagnosticsBlock(detail.task.diagnostics, label: "Diagnostics")
|
||||
}
|
||||
Picker("Section", selection: $selectedTab) {
|
||||
ForEach(DetailTab.allCases) { tab in
|
||||
Text(tab.rawValue).tag(tab)
|
||||
@@ -90,7 +107,9 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
|
||||
private func headerCard(_ task: HermesKanbanTask) -> some View {
|
||||
VStack(alignment: .leading, spacing: 8) {
|
||||
HStack(spacing: 6) {
|
||||
// Wrap chips in FlowLayout so the new v0.13 `retries` chip
|
||||
// doesn't push the row over the iPhone-portrait width budget.
|
||||
FlowLayout(spacing: 6) {
|
||||
ScarfBadge(task.status.lowercased(), kind: badgeKind(for: task.status))
|
||||
if let assignee = task.assignee, !assignee.isEmpty {
|
||||
ScarfBadge(assignee, kind: .neutral)
|
||||
@@ -101,6 +120,10 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
if let tenant = task.tenant, !tenant.isEmpty {
|
||||
ScarfBadge(tenant, kind: .brand)
|
||||
}
|
||||
if diagnosticsAvailable, let maxRetries = task.maxRetries {
|
||||
ScarfBadge("retries: \(maxRetries)", kind: .neutral)
|
||||
.accessibilityLabel("Max retries \(maxRetries)")
|
||||
}
|
||||
}
|
||||
if let priority = task.priority {
|
||||
Text("Priority \(priority)")
|
||||
@@ -110,6 +133,100 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 hallucination gate. Worker-created cards land in the
|
||||
/// `pending` state until a human verifies — Mac surfaces a Verify /
|
||||
/// Reject button pair; iOS in v2.8.0 stays read-only and points
|
||||
/// the user to the Mac app via the badge copy.
|
||||
@ViewBuilder
|
||||
private func hallucinationBadge(_ task: HermesKanbanTask) -> some View {
|
||||
if diagnosticsAvailable,
|
||||
KanbanHallucinationGate.from(task.hallucinationGateStatus) == .pending {
|
||||
HStack(spacing: 6) {
|
||||
Image(systemName: "questionmark.diamond.fill")
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
Text("Worker-created — verify on Mac")
|
||||
.font(.subheadline)
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
}
|
||||
.padding(.horizontal, 10)
|
||||
.padding(.vertical, 6)
|
||||
.background(
|
||||
ScarfColor.warning.opacity(0.10),
|
||||
in: RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
)
|
||||
.overlay(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.strokeBorder(ScarfColor.warning.opacity(0.4), lineWidth: 1)
|
||||
)
|
||||
.accessibilityHint("Open this task on the Mac app to verify or reject the worker's claim.")
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 auto-blocked banner. Surfaces `auto_blocked_reason` verbatim
|
||||
/// when Hermes auto-blocks a task (retry cap hit, repeated tool
|
||||
/// errors, etc.). Server-supplied copy — render verbatim.
|
||||
@ViewBuilder
|
||||
private func autoBlockedBanner(_ task: HermesKanbanTask) -> some View {
|
||||
if diagnosticsAvailable,
|
||||
KanbanStatus.from(task.status) == .blocked,
|
||||
let reason = task.autoBlockedReason, !reason.isEmpty {
|
||||
HStack(alignment: .top, spacing: 8) {
|
||||
Image(systemName: "exclamationmark.octagon.fill")
|
||||
.foregroundStyle(ScarfColor.danger)
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
Text("Auto-blocked")
|
||||
.font(.subheadline.weight(.semibold))
|
||||
.foregroundStyle(ScarfColor.danger)
|
||||
Text(reason)
|
||||
.font(.subheadline)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
.padding(10)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.background(
|
||||
ScarfColor.danger.opacity(0.08),
|
||||
in: RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
/// Tap-target diagnostic chip list. iOS substitute for the Mac
|
||||
/// inspector's `.help()` tooltip — chips are tappable, tap presents
|
||||
/// `DiagnosticDetailSheet` with the full message + timestamp.
|
||||
@ViewBuilder
|
||||
private func diagnosticsBlock(_ diags: [HermesKanbanDiagnostic], label: String) -> some View {
|
||||
VStack(alignment: .leading, spacing: 6) {
|
||||
Text(label)
|
||||
.font(.caption.weight(.semibold))
|
||||
.foregroundStyle(.secondary)
|
||||
FlowLayout(spacing: 6) {
|
||||
ForEach(diags) { diag in
|
||||
Button {
|
||||
selectedDiagnostic = diag
|
||||
} label: {
|
||||
ScarfBadge(diag.kind, kind: diagnosticBadgeKind(diag))
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.accessibilityLabel(diag.message ?? diag.kind)
|
||||
.accessibilityHint("Tap to see the full diagnostic message and timestamp.")
|
||||
}
|
||||
}
|
||||
}
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
}
|
||||
|
||||
/// Maps the typed `KanbanDiagnosticKind.severity` enum into the
|
||||
/// `ScarfBadgeKind` palette. Mirrors the Mac inspector's
|
||||
/// `diagnosticBadge` helper so the two surfaces tint identically.
|
||||
private func diagnosticBadgeKind(_ diag: HermesKanbanDiagnostic) -> ScarfBadgeKind {
|
||||
switch KanbanDiagnosticKind.from(diag.kind).severity {
|
||||
case .danger: return .danger
|
||||
case .warning: return .warning
|
||||
case .neutral: return .neutral
|
||||
}
|
||||
}
|
||||
|
||||
private func commentsSection(_ comments: [HermesKanbanComment]) -> some View {
|
||||
VStack(alignment: .leading, spacing: 8) {
|
||||
if comments.isEmpty {
|
||||
@@ -194,6 +311,10 @@ struct ScarfGoKanbanDetailSheet: View {
|
||||
.font(.caption)
|
||||
.foregroundStyle(.red)
|
||||
}
|
||||
if diagnosticsAvailable, !run.diagnostics.isEmpty {
|
||||
diagnosticsBlock(run.diagnostics, label: "Run diagnostics")
|
||||
.padding(.top, 4)
|
||||
}
|
||||
}
|
||||
.padding(8)
|
||||
.background(ScarfColor.backgroundSecondary.opacity(0.4))
|
||||
|
||||
@@ -13,6 +13,7 @@ struct SettingsView: View {
|
||||
@State private var vm: IOSSettingsViewModel
|
||||
@State private var showRawYAML = false
|
||||
@State private var editingSpec: SettingSpec?
|
||||
@State private var showV013FeaturesSheet = false
|
||||
/// v2.7 — Scarf-local opt-in to bulk-fetch tool result CONTENT
|
||||
/// when resuming past chats. Default off; the shared
|
||||
/// `RichChatViewModel` reads this same UserDefaults key on
|
||||
@@ -21,6 +22,16 @@ struct SettingsView: View {
|
||||
@AppStorage(RichChatViewModel.loadHistoricalToolResultsKey)
|
||||
private var loadHistoricalToolResults: Bool = false
|
||||
|
||||
/// Drives v0.13 read-only surfaces (features-active badge,
|
||||
/// platforms-section additions). Defensive `?? .empty` resolves
|
||||
/// every gate to `false` outside `ContextBoundRoot` (preview /
|
||||
/// smoke harness) so the v2.7.5 layout is the unconditional
|
||||
/// fallback.
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
private var caps: HermesCapabilities {
|
||||
capabilitiesStore?.capabilities ?? .empty
|
||||
}
|
||||
|
||||
private static let sharedContextID: ServerID = ServerID(
|
||||
uuidString: "00000000-0000-0000-0000-0000000000A1"
|
||||
)!
|
||||
@@ -40,6 +51,10 @@ struct SettingsView: View {
|
||||
}
|
||||
}
|
||||
|
||||
if caps.isV013OrLater {
|
||||
v013ActiveBadgeSection
|
||||
}
|
||||
|
||||
if !vm.isLoading || vm.config.model != "unknown" {
|
||||
quickEditsSection
|
||||
modelSection
|
||||
@@ -79,6 +94,35 @@ struct SettingsView: View {
|
||||
onDismiss: {}
|
||||
)
|
||||
}
|
||||
.sheet(isPresented: $showV013FeaturesSheet) {
|
||||
V013FeaturesSheet()
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 features-active badge. Only shown when the connected host
|
||||
/// is on the v0.13 line; tap presents `V013FeaturesSheet`. Read-only
|
||||
/// — there's no settings change behind the badge, just a
|
||||
/// what's-new affordance.
|
||||
@ViewBuilder
|
||||
private var v013ActiveBadgeSection: some View {
|
||||
Section {
|
||||
Button {
|
||||
showV013FeaturesSheet = true
|
||||
} label: {
|
||||
HStack(spacing: 8) {
|
||||
ScarfBadge("v0.13 features active", kind: .success)
|
||||
Spacer()
|
||||
Text("Learn more")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.tint)
|
||||
Image(systemName: "chevron.right")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.tertiary)
|
||||
}
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
}
|
||||
.listRowBackground(ScarfColor.success.opacity(0.06))
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
@@ -284,9 +328,119 @@ struct SettingsView: View {
|
||||
yesNoRow("Telegram: require mention", vm.config.telegram.requireMention)
|
||||
LabeledContent("Slack: reply mode", value: vm.config.slack.replyToMode)
|
||||
yesNoRow("Matrix: require mention", vm.config.matrix.requireMention)
|
||||
|
||||
// v0.13 additions: each is independently capability-gated
|
||||
// and read-only on iOS in v2.8.0. Editing lives on Mac.
|
||||
if caps.hasGoogleChatPlatform {
|
||||
LabeledContent("Google Chat", value: googleChatStatusLabel)
|
||||
}
|
||||
if caps.hasGatewayBusyAckToggle {
|
||||
gatewayBusyAckRow
|
||||
}
|
||||
if caps.hasGatewayRestartNotification {
|
||||
gatewayRestartNotificationRow
|
||||
}
|
||||
if caps.hasGatewayAllowlists {
|
||||
gatewayAllowlistsRows
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 Google Chat status. Whether the platform shows up at all
|
||||
/// is driven by whether `gateway.platforms.google-chat.*` exists in
|
||||
/// config.yaml on the remote — if absent, we render "Not configured".
|
||||
/// Hermes accepts either `google-chat` or `googlechat` as the
|
||||
/// identifier; check both spellings defensively.
|
||||
private var googleChatStatusLabel: String {
|
||||
if vm.config.gatewayPlatforms["google-chat"] != nil
|
||||
|| vm.config.gatewayPlatforms["googlechat"] != nil {
|
||||
return "configured"
|
||||
}
|
||||
return "not configured"
|
||||
}
|
||||
|
||||
/// v0.13 cross-platform busy-ack toggle. We summarize per platform
|
||||
/// so users on iOS get a faithful read of the per-platform flag —
|
||||
/// "off on slack, on elsewhere" is a real configuration shape.
|
||||
/// Empty `gatewayPlatforms` shows "default".
|
||||
@ViewBuilder
|
||||
private var gatewayBusyAckRow: some View {
|
||||
let value = summariseGatewayBool(\GatewayPlatformSettings.busyAckEnabled, defaultLabel: "on")
|
||||
LabeledContent("Gateway: busy ack", value: value)
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private var gatewayRestartNotificationRow: some View {
|
||||
let value = summariseGatewayBool(\GatewayPlatformSettings.gatewayRestartNotification, defaultLabel: "off")
|
||||
LabeledContent("Gateway: restart notification", value: value)
|
||||
}
|
||||
|
||||
/// Render a per-key summary across `gatewayPlatforms`. When all
|
||||
/// configured platforms agree on the same value we show a single
|
||||
/// "yes" / "no". When they disagree we show "mixed (N platforms)"
|
||||
/// to nudge the user to the Mac app for the per-platform detail.
|
||||
private func summariseGatewayBool(
|
||||
_ keyPath: KeyPath<GatewayPlatformSettings, Bool>,
|
||||
defaultLabel: String
|
||||
) -> String {
|
||||
let values = vm.config.gatewayPlatforms.values.map { $0[keyPath: keyPath] }
|
||||
guard !values.isEmpty else { return defaultLabel + " (default)" }
|
||||
let allTrue = values.allSatisfy { $0 }
|
||||
let allFalse = values.allSatisfy { !$0 }
|
||||
if allTrue { return "yes" }
|
||||
if allFalse { return "no" }
|
||||
return "mixed (\(values.count) platforms)"
|
||||
}
|
||||
|
||||
/// v0.13 cross-platform allowlist summaries. Each kind
|
||||
/// (channels / chats / rooms) renders as a DisclosureGroup with the
|
||||
/// total count in the label and a flat list of "platform: id" rows
|
||||
/// when expanded. iPhone-friendly: collapsed by default so the
|
||||
/// section stays compact.
|
||||
@ViewBuilder
|
||||
private var gatewayAllowlistsRows: some View {
|
||||
gatewayAllowlistDisclosure(kind: .channels)
|
||||
gatewayAllowlistDisclosure(kind: .chats)
|
||||
gatewayAllowlistDisclosure(kind: .rooms)
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private func gatewayAllowlistDisclosure(kind: GatewayAllowlistKind) -> some View {
|
||||
let entries = gatewayAllowlistEntries(kind: kind)
|
||||
if !entries.isEmpty {
|
||||
DisclosureGroup {
|
||||
ForEach(entries, id: \.self) { entry in
|
||||
Text(entry)
|
||||
.font(.caption.monospaced())
|
||||
.foregroundStyle(.secondary)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.middle)
|
||||
}
|
||||
} label: {
|
||||
LabeledContent("Allowed \(kind.pluralNoun)") {
|
||||
Text("\(entries.count)")
|
||||
.font(.callout)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Flatten the per-platform allowlists for `kind` across every
|
||||
/// configured platform. Each entry is rendered as
|
||||
/// `"platformName: id"` so the user sees which platform the id
|
||||
/// belongs to without an extra DisclosureGroup level.
|
||||
private func gatewayAllowlistEntries(kind: GatewayAllowlistKind) -> [String] {
|
||||
var out: [String] = []
|
||||
for (platform, settings) in vm.config.gatewayPlatforms.sorted(by: { $0.key < $1.key }) {
|
||||
guard GatewayAllowlistKind.kind(for: platform) == kind else { continue }
|
||||
for item in settings.items(for: kind) where !item.isEmpty {
|
||||
out.append("\(platform): \(item)")
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
/// Diagnostics → Performance entry point. Hidden from the
|
||||
/// `quickEditsSection` flow because it doesn't touch config.yaml
|
||||
/// — it controls the in-process ScarfMon backend set instead. Off
|
||||
|
||||
@@ -0,0 +1,83 @@
|
||||
import SwiftUI
|
||||
import ScarfDesign
|
||||
|
||||
/// "Learn more" sheet behind the v0.13 features-active badge in
|
||||
/// `SettingsView`. Text-only summary of what shipped in Hermes v0.13
|
||||
/// (Persistent Goals, ACP /queue, Kanban diagnostics, hallucination
|
||||
/// gate, Curator archive, Google Chat platform). Every row spells out
|
||||
/// where the editing lives — Mac for v2.8.0; iOS write surfaces are
|
||||
/// deferred to v2.8.x.
|
||||
///
|
||||
/// No deep-linking from rows in v2.8.0 — that's a v2.8.x polish.
|
||||
struct V013FeaturesSheet: View {
|
||||
@Environment(\.dismiss) private var dismiss
|
||||
|
||||
var body: some View {
|
||||
NavigationStack {
|
||||
List {
|
||||
Section {
|
||||
featureRow(
|
||||
icon: "scope",
|
||||
title: "Persistent goals",
|
||||
description: "Type /goal <text> in chat to lock the agent on a target across turns. Send and clear from the Mac app in v2.8."
|
||||
)
|
||||
featureRow(
|
||||
icon: "tray.full",
|
||||
title: "ACP /queue",
|
||||
description: "Queue prompts to run after the current turn finishes. Send and manage from the Mac app in v2.8."
|
||||
)
|
||||
featureRow(
|
||||
icon: "stethoscope",
|
||||
title: "Kanban diagnostics",
|
||||
description: "Worker distress signals (heartbeat stalls, retry caps, zombies) surface on the task detail."
|
||||
)
|
||||
featureRow(
|
||||
icon: "questionmark.diamond.fill",
|
||||
title: "Hallucination gate",
|
||||
description: "Worker-created cards are flagged for verify or reject. Verify on the Mac app."
|
||||
)
|
||||
featureRow(
|
||||
icon: "archivebox",
|
||||
title: "Curator archive",
|
||||
description: "Stale skills move to an Archived list. Restore or prune from the Mac app."
|
||||
)
|
||||
featureRow(
|
||||
icon: "bubble.left.and.bubble.right",
|
||||
title: "Google Chat platform",
|
||||
description: "New messaging-gateway target. Configure on the Mac app."
|
||||
)
|
||||
} header: {
|
||||
Text("What's new in v0.13")
|
||||
} footer: {
|
||||
Text("This iOS release surfaces v0.13 features read-only. Editing lives in the Mac app for v2.8.")
|
||||
.font(.caption)
|
||||
}
|
||||
}
|
||||
.scrollContentBackground(.hidden)
|
||||
.background(ScarfColor.backgroundPrimary)
|
||||
.navigationTitle("v0.13 features")
|
||||
.navigationBarTitleDisplayMode(.inline)
|
||||
.toolbar {
|
||||
ToolbarItem(placement: .topBarTrailing) {
|
||||
Button("Done") { dismiss() }
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private func featureRow(icon: String, title: String, description: String) -> some View {
|
||||
HStack(alignment: .top, spacing: 12) {
|
||||
Image(systemName: icon)
|
||||
.foregroundStyle(.tint)
|
||||
.font(.title3)
|
||||
.frame(width: 28)
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text(title).font(.body.weight(.semibold))
|
||||
Text(description)
|
||||
.font(.callout)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
.padding(.vertical, 4)
|
||||
}
|
||||
}
|
||||
@@ -263,6 +263,47 @@ struct HermesFileService: Sendable {
|
||||
cooldownSeconds: int("platforms.homeassistant.extra.cooldown_seconds", default: 30)
|
||||
)
|
||||
|
||||
// -- v0.13: per-platform Messaging Gateway settings --------------
|
||||
// Mirrors the canonical extractor in
|
||||
// `ScarfCore/Parsing/HermesConfig+YAML.swift`. Behaviour parity
|
||||
// matters: both parsers must populate `gatewayPlatforms` the same
|
||||
// way so iOS and Mac surfaces stay in lockstep.
|
||||
// TODO(WS-5-Q2): YAML key path unverified — see the comment in the
|
||||
// ScarfCore extractor for the resolution path.
|
||||
let gatewayAllowlistPlatforms = [
|
||||
"slack", "mattermost", "google-chat",
|
||||
"telegram", "whatsapp",
|
||||
"matrix", "dingtalk",
|
||||
]
|
||||
var gatewayPlatforms: [String: GatewayPlatformSettings] = [:]
|
||||
for platform in gatewayAllowlistPlatforms {
|
||||
let prefix = "gateway.platforms.\(platform)."
|
||||
let allowedChannels = lists[prefix + "allowed_channels"] ?? []
|
||||
let allowedChats = lists[prefix + "allowed_chats"] ?? []
|
||||
let allowedRooms = lists[prefix + "allowed_rooms"] ?? []
|
||||
let busy = bool(prefix + "busy_ack_enabled", default: true)
|
||||
let restartNotice = bool(prefix + "gateway_restart_notification",
|
||||
default: false)
|
||||
let ttl = int(prefix + "slash_command_notice_ttl_seconds",
|
||||
default: 0)
|
||||
let isEmpty = allowedChannels.isEmpty
|
||||
&& allowedChats.isEmpty
|
||||
&& allowedRooms.isEmpty
|
||||
&& values[prefix + "busy_ack_enabled"] == nil
|
||||
&& values[prefix + "gateway_restart_notification"] == nil
|
||||
&& values[prefix + "slash_command_notice_ttl_seconds"] == nil
|
||||
if !isEmpty {
|
||||
gatewayPlatforms[platform] = GatewayPlatformSettings(
|
||||
allowedChannels: allowedChannels,
|
||||
allowedChats: allowedChats,
|
||||
allowedRooms: allowedRooms,
|
||||
busyAckEnabled: busy,
|
||||
gatewayRestartNotification: restartNotice,
|
||||
slashCommandNoticeTTLSeconds: ttl
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
return HermesConfig(
|
||||
model: str("model.default", default: "unknown"),
|
||||
provider: str("model.provider", default: "unknown"),
|
||||
@@ -322,7 +363,8 @@ struct HermesFileService: Sendable {
|
||||
homeAssistant: homeAssistant,
|
||||
cacheTTL: str("prompt_caching.cache_ttl", default: "5m"),
|
||||
redactionEnabled: bool("redaction.enabled", default: false),
|
||||
runtimeMetadataFooter: bool("agent.runtime_metadata_footer", default: false)
|
||||
runtimeMetadataFooter: bool("agent.runtime_metadata_footer", default: false),
|
||||
gatewayPlatforms: gatewayPlatforms
|
||||
)
|
||||
}
|
||||
|
||||
@@ -608,7 +650,8 @@ struct HermesFileService: Sendable {
|
||||
toolsExclude: server.toolsExclude,
|
||||
resourcesEnabled: server.resourcesEnabled,
|
||||
promptsEnabled: server.promptsEnabled,
|
||||
hasOAuthToken: hasToken
|
||||
hasOAuthToken: hasToken,
|
||||
sseReadTimeout: server.sseReadTimeout
|
||||
)
|
||||
}
|
||||
}
|
||||
@@ -639,6 +682,37 @@ struct HermesFileService: Sendable {
|
||||
return runHermesCLI(args: cliArgs, timeout: 45, stdinInput: "y\ny\ny\n")
|
||||
}
|
||||
|
||||
/// Adds an SSE-transport MCP server. v0.13+ only — caller is responsible
|
||||
/// for capability-gating; pre-v0.13 hosts will reject the `--transport`
|
||||
/// flag at argparse time. The optional `sseReadTimeout` is passed via
|
||||
/// `--sse-read-timeout <int>` and persisted as `sse_read_timeout: <int>`
|
||||
/// in the YAML entry.
|
||||
// TODO(WS-7-Q3): Verify exact CLI flag spelling against `hermes mcp add --help`
|
||||
// on a v0.13 install. Plan assumes `--transport sse` + `--sse-read-timeout`;
|
||||
// alternatives could be `--sse` (boolean) + `--read-timeout`.
|
||||
@discardableResult
|
||||
nonisolated func addMCPServerSSE(name: String, url: String, sseReadTimeout: Int?) -> (exitCode: Int32, output: String) {
|
||||
var cliArgs: [String] = ["mcp", "add", name, "--url", url, "--transport", "sse"]
|
||||
if let timeout = sseReadTimeout {
|
||||
cliArgs.append(contentsOf: ["--sse-read-timeout", String(timeout)])
|
||||
}
|
||||
return runHermesCLI(args: cliArgs, timeout: 45, stdinInput: "y\ny\ny\n")
|
||||
}
|
||||
|
||||
/// Updates the `sse_read_timeout` scalar in-place via the same surgical
|
||||
/// patcher used by `setMCPServerTimeouts`. Pass `nil` to remove the
|
||||
/// scalar entirely (Hermes default applies).
|
||||
@discardableResult
|
||||
nonisolated func setMCPServerSSETimeout(name: String, sseReadTimeout: Int?) -> Bool {
|
||||
patchMCPServerField(name: name) { entryLines in
|
||||
if let timeout = sseReadTimeout {
|
||||
Self.replaceOrInsertScalar(key: "sse_read_timeout", value: String(timeout), in: &entryLines)
|
||||
} else {
|
||||
Self.removeScalar(key: "sse_read_timeout", in: &entryLines)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@discardableResult
|
||||
nonisolated func setMCPServerArgs(name: String, args: [String]) -> Bool {
|
||||
patchMCPServerField(name: name) { entryLines in
|
||||
@@ -821,11 +895,23 @@ struct HermesFileService: Sendable {
|
||||
|
||||
func flush() {
|
||||
guard let name = currentName else { return }
|
||||
let transport: MCPTransport = fields["url"] != nil ? .http : .stdio
|
||||
// 3-way transport discriminator: an explicit `transport: sse` scalar
|
||||
// wins (Hermes v0.13+ emits it for SSE servers); otherwise URL-bearing
|
||||
// entries fall back to .http (v0.12 shape) and command-bearing entries
|
||||
// to .stdio. This preserves byte-for-byte round-trip on existing files
|
||||
// — pre-v0.13 entries have no `transport:` key so they parse identically.
|
||||
// TODO(WS-7-Q1): Verify Hermes v0.13 actually emits `transport: sse`
|
||||
// (vs. inferring from the schema/url shape) once a v0.13 host is on hand.
|
||||
let transport: MCPTransport = {
|
||||
if fields["transport"]?.lowercased() == "sse" { return .sse }
|
||||
if fields["url"] != nil { return .http }
|
||||
return .stdio
|
||||
}()
|
||||
let enabledStr = fields["enabled"]?.lowercased()
|
||||
let enabled = enabledStr != "false"
|
||||
let timeout = fields["timeout"].flatMap(Int.init)
|
||||
let connectTimeout = fields["connect_timeout"].flatMap(Int.init)
|
||||
let sseReadTimeout = fields["sse_read_timeout"].flatMap(Int.init)
|
||||
let server = HermesMCPServer(
|
||||
name: name,
|
||||
transport: transport,
|
||||
@@ -842,7 +928,8 @@ struct HermesFileService: Sendable {
|
||||
toolsExclude: excludeList,
|
||||
resourcesEnabled: resources,
|
||||
promptsEnabled: prompts,
|
||||
hasOAuthToken: false
|
||||
hasOAuthToken: false,
|
||||
sseReadTimeout: sseReadTimeout
|
||||
)
|
||||
servers.append(server)
|
||||
|
||||
|
||||
@@ -77,6 +77,27 @@ final class ChatViewModel {
|
||||
let richChatViewModel: RichChatViewModel
|
||||
private var coordinator: Coordinator?
|
||||
|
||||
/// Capability store the chat surface reads from. Set by `ChatView`
|
||||
/// at body-evaluation time via `attachCapabilitiesStore(_:)` —
|
||||
/// `@ObservationIgnored` so capability refreshes don't force a
|
||||
/// full chat re-render. Forwards into
|
||||
/// `RichChatViewModel.capabilitiesGate` whenever the published
|
||||
/// snapshot changes; the slash menu reads through that. v2.8 /
|
||||
/// Hermes v0.13 — gates `/goal` + `/queue` slash menu rows.
|
||||
@ObservationIgnored
|
||||
var capabilitiesStore: HermesCapabilitiesStore?
|
||||
|
||||
/// Wire the Mac chat view's environment-injected capabilities store
|
||||
/// into both this VM and its child rich-chat VM. Idempotent on the
|
||||
/// pointer (re-attaching the same store is a no-op); always
|
||||
/// re-publishes the latest snapshot so a refresh that fired before
|
||||
/// the chat view became visible still lands.
|
||||
@MainActor
|
||||
func attachCapabilitiesStore(_ store: HermesCapabilitiesStore?) {
|
||||
capabilitiesStore = store
|
||||
richChatViewModel.publishCapabilities(store?.capabilities ?? .empty)
|
||||
}
|
||||
|
||||
/// `callId` of the tool call currently surfaced in the chat
|
||||
/// inspector pane, or nil when nothing is focused. Set by
|
||||
/// `ToolCallCard` taps in the transcript; cleared by the inspector's
|
||||
@@ -321,6 +342,47 @@ final class ChatViewModel {
|
||||
richChatViewModel.clearACPErrorState()
|
||||
}
|
||||
|
||||
/// Auto-clear the chat composer's transient hint after 4 s. Shared
|
||||
/// helper for `/steer`, `/goal`, and `/queue` so the toast lifetime
|
||||
/// stays consistent across non-interruptive commands.
|
||||
@MainActor
|
||||
private func scheduleHintClear() {
|
||||
let snapshot = richChatViewModel.transientHint
|
||||
Task { @MainActor [weak self] in
|
||||
try? await Task.sleep(nanoseconds: 4_000_000_000)
|
||||
if self?.richChatViewModel.transientHint == snapshot {
|
||||
self?.richChatViewModel.transientHint = nil
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Pull the slash command name + raw argument tail out of the
|
||||
/// composer text. Returns `(name: nil, args: "")` for non-slash
|
||||
/// input. Mirrors the parser shape `RichChatViewModel.parseGoalArgument`
|
||||
/// expects; kept on `ChatViewModel` (not promoted to ScarfCore)
|
||||
/// because the Mac and iOS chat surfaces compose this with their
|
||||
/// own per-platform send paths.
|
||||
static func parseSlashName(_ text: String) -> (name: String?, args: String) {
|
||||
let trimmed = text.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
guard trimmed.hasPrefix("/") else { return (nil, "") }
|
||||
let withoutSlash = trimmed.dropFirst()
|
||||
if let space = withoutSlash.firstIndex(of: " ") {
|
||||
return (
|
||||
name: String(withoutSlash[..<space]),
|
||||
args: String(withoutSlash[withoutSlash.index(after: space)...])
|
||||
)
|
||||
}
|
||||
return (name: String(withoutSlash), args: "")
|
||||
}
|
||||
|
||||
/// Cap goal text in transient toasts so a 1 KB user-typed goal
|
||||
/// doesn't blow out the hint pill. The header pill applies its
|
||||
/// own 33-char cap; the toast is shorter so the hint stays
|
||||
/// glanceable.
|
||||
static func truncatedToastGoal(_ text: String) -> String {
|
||||
text.count <= 60 ? text : String(text.prefix(57)) + "…"
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private func recordACPFailure(_ error: Error, client: ACPClient?, context: String) async {
|
||||
logger.error("\(context): \(error.localizedDescription)")
|
||||
@@ -575,22 +637,59 @@ final class ChatViewModel {
|
||||
// and Hermes-version-independent. v2.5.
|
||||
let wireText = expandIfProjectScoped(text)
|
||||
|
||||
// /steer is non-interruptive — the agent is still on its
|
||||
// current turn; the guidance applies after the next tool
|
||||
// call. Don't change the "Agent working..." status (it's
|
||||
// already on); show a transient toast so the user knows the
|
||||
// guidance was accepted. v2.5 / Hermes v2026.4.23+.
|
||||
let isSteer = richChatViewModel.isNonInterruptiveSlash(text)
|
||||
if isSteer {
|
||||
richChatViewModel.transientHint = "Guidance queued — applies after the next tool call."
|
||||
Task { @MainActor [weak self] in
|
||||
try? await Task.sleep(nanoseconds: 4_000_000_000)
|
||||
if self?.richChatViewModel.transientHint == "Guidance queued — applies after the next tool call." {
|
||||
self?.richChatViewModel.transientHint = nil
|
||||
}
|
||||
// Non-interruptive slash commands keep the "Agent working…"
|
||||
// indicator off and surface a transient toast confirming the
|
||||
// command was accepted. v2.5 added `/steer`; v2.8 / Hermes
|
||||
// v0.13 adds `/goal` (lock the agent on a target across turns)
|
||||
// and `/queue` (queue a prompt for after the current turn).
|
||||
// Each gets its own optimistic side-effect on RichChatViewModel
|
||||
// so the chat header pill / queue chip update synchronously
|
||||
// without waiting for a server round-trip.
|
||||
let isNonInterruptive = richChatViewModel.isNonInterruptiveSlash(text)
|
||||
let parsed = Self.parseSlashName(text)
|
||||
switch parsed.name {
|
||||
case "goal":
|
||||
// TODO(WS-2-Q7): once a v0.13 host confirms the
|
||||
// wire-shape, this branch fires only when the host
|
||||
// advertises `hasGoals`; pre-v0.13 hosts hide the menu
|
||||
// row, but a power-user typing `/goal` directly still
|
||||
// lands here. We keep the optimistic write so the pill
|
||||
// appears synchronously — the agent's "unknown command"
|
||||
// reply on a pre-v0.13 host paints the inconsistency in
|
||||
// user-visible chat content (acceptable v1 behavior;
|
||||
// see WS-2 plan "Inconsistency caveat").
|
||||
let arg = RichChatViewModel.parseGoalArgument(parsed.args)
|
||||
switch arg {
|
||||
case .set(let goalText):
|
||||
richChatViewModel.recordActiveGoal(text: goalText)
|
||||
richChatViewModel.transientHint = "Goal locked: \(Self.truncatedToastGoal(goalText))"
|
||||
case .clear:
|
||||
richChatViewModel.recordActiveGoal(text: nil)
|
||||
richChatViewModel.transientHint = "Goal cleared."
|
||||
case .empty:
|
||||
richChatViewModel.transientHint = "Sent /goal — see the agent reply for current goal."
|
||||
}
|
||||
} else {
|
||||
acpStatus = ACPPhase.agentWorking
|
||||
scheduleHintClear()
|
||||
case "queue":
|
||||
// TODO(WS-2-Q5): verify against a real v0.13 ACP host
|
||||
// that the verbatim "/queue <text>" wire shape is what
|
||||
// Hermes accepts (versus a structured arg shape). The
|
||||
// optimistic mirror logic below assumes verbatim text.
|
||||
let queuedText = parsed.args.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if !queuedText.isEmpty {
|
||||
richChatViewModel.recordQueuedPrompt(text: queuedText)
|
||||
}
|
||||
richChatViewModel.transientHint = "Queued — runs after current turn."
|
||||
scheduleHintClear()
|
||||
case "steer" where isNonInterruptive:
|
||||
richChatViewModel.transientHint = "Guidance queued — applies after the next tool call."
|
||||
scheduleHintClear()
|
||||
default:
|
||||
// Regular interruptive prompt (or an unrecognized slash).
|
||||
// Don't flip "Agent working…" for any other
|
||||
// non-interruptive command (defensive; matches the
|
||||
// legacy contract).
|
||||
if !isNonInterruptive { acpStatus = ACPPhase.agentWorking }
|
||||
}
|
||||
acpPromptTask = Task { @MainActor in
|
||||
do {
|
||||
@@ -608,7 +707,7 @@ final class ChatViewModel {
|
||||
// notifier handles the foreground/disabled gating;
|
||||
// we just hand it the latest assistant text and
|
||||
// session title for the body line.
|
||||
if !isSteer {
|
||||
if !isNonInterruptive {
|
||||
let preview = richChatViewModel.messages
|
||||
.last(where: { $0.isAssistant })?
|
||||
.content ?? ""
|
||||
|
||||
@@ -0,0 +1,95 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Header chip that surfaces prompts the user has queued via
|
||||
/// `/queue …` (Hermes v0.13). Tap → popover listing the queued
|
||||
/// prompt previews + their relative timestamps.
|
||||
///
|
||||
/// The chip is OPTIMISTIC — it's a Scarf-side mirror of what the user
|
||||
/// typed. Hermes owns the authoritative queue server-side. The popover
|
||||
/// header makes that explicit so the user understands per-entry
|
||||
/// removal isn't supported (Hermes has no remove-by-id verb), and the
|
||||
/// v2.8.0 plan removed the "Clear all" button rather than ship one
|
||||
/// that would lie about its effect on server-side state. See WS-2 plan
|
||||
/// Q2 for the wire-shape question that drove that decision.
|
||||
struct ChatQueueIndicator: View {
|
||||
let queuedPrompts: [HermesQueuedPrompt]
|
||||
@State private var isPopoverShown = false
|
||||
|
||||
var body: some View {
|
||||
if queuedPrompts.isEmpty {
|
||||
EmptyView()
|
||||
} else {
|
||||
chipButton
|
||||
.popover(isPresented: $isPopoverShown, arrowEdge: .bottom) {
|
||||
queuePopover
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var chipButton: some View {
|
||||
Button {
|
||||
isPopoverShown = true
|
||||
} label: {
|
||||
HStack(spacing: 4) {
|
||||
Image(systemName: "tray.full")
|
||||
Text("\(queuedPrompts.count) queued")
|
||||
}
|
||||
.scarfStyle(.caption)
|
||||
.padding(.horizontal, ScarfSpace.s2)
|
||||
.padding(.vertical, 2)
|
||||
.background(Capsule().fill(ScarfColor.warning.opacity(0.16)))
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.help("Prompts waiting to run after the current turn finishes")
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private var queuePopover: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
Text("Queued prompts")
|
||||
.scarfStyle(.headline)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
Text("Local view — Hermes manages the actual queue server-side. The next prompt runs automatically when the current turn finishes.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
ScarfDivider()
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
ForEach(Array(queuedPrompts.enumerated()), id: \.element.id) { index, prompt in
|
||||
queueRow(prompt, position: index + 1)
|
||||
}
|
||||
}
|
||||
.padding(.vertical, 2)
|
||||
}
|
||||
.frame(maxHeight: 220)
|
||||
}
|
||||
.padding(ScarfSpace.s4)
|
||||
.frame(width: 360)
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private func queueRow(_ prompt: HermesQueuedPrompt, position: Int) -> some View {
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
HStack(alignment: .firstTextBaseline, spacing: ScarfSpace.s2) {
|
||||
Text("#\(position)")
|
||||
.scarfStyle(.captionUppercase)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
Text(prompt.queuedAt, style: .relative)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.monospacedDigit()
|
||||
}
|
||||
Text(prompt.text)
|
||||
.scarfStyle(.body)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
.lineLimit(3)
|
||||
.truncationMode(.tail)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
.padding(.vertical, 2)
|
||||
}
|
||||
}
|
||||
@@ -24,6 +24,9 @@ struct ChatTranscriptPane: View {
|
||||
acpCompressionCount: richChat.acpCompressionCount,
|
||||
projectName: chatViewModel.currentProjectName,
|
||||
gitBranch: chatViewModel.currentGitBranch,
|
||||
activeGoal: richChat.activeGoal,
|
||||
onClearGoal: { chatViewModel.sendText("/goal --clear") },
|
||||
queuedPrompts: richChat.queuedPrompts,
|
||||
capabilities: capabilitiesStore?.capabilities ?? .empty
|
||||
)
|
||||
Divider()
|
||||
@@ -61,7 +64,8 @@ struct ChatTranscriptPane: View {
|
||||
onSend: onSend,
|
||||
isEnabled: isEnabled,
|
||||
commands: richChat.availableCommands,
|
||||
showCompressButton: richChat.supportsCompress && !richChat.hasBroaderCommandMenu
|
||||
showCompressButton: richChat.supportsCompress && !richChat.hasBroaderCommandMenu,
|
||||
isAgentWorking: richChat.isAgentWorking
|
||||
)
|
||||
.id(richChat.sessionId ?? "scarf.chat.no-session")
|
||||
}
|
||||
|
||||
@@ -5,6 +5,12 @@ struct ChatView: View {
|
||||
@Environment(ChatViewModel.self) private var viewModel
|
||||
@Environment(HermesFileWatcher.self) private var fileWatcher
|
||||
@Environment(AppCoordinator.self) private var coordinator
|
||||
/// Capabilities store for the active server (injected on
|
||||
/// `ContextBoundRoot`). Forwarded into `ChatViewModel` so the
|
||||
/// rich-chat slash menu can gate v0.13 surfaces (`/goal`, `/queue`,
|
||||
/// `/steer` on idle). Nil during harness scenarios; treated the
|
||||
/// same as `.empty` capabilities.
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
@State private var showErrorDetails = false
|
||||
|
||||
/// Side-pane visibility toggles (issue #58). Drive the new
|
||||
@@ -45,6 +51,15 @@ struct ChatView: View {
|
||||
.navigationTitle(
|
||||
viewModel.currentProjectName.map { "Chat · \($0)" } ?? "Chat"
|
||||
)
|
||||
// Forward the env-injected capabilities store into the chat VM
|
||||
// on every refresh tick so the rich-chat slash menu picks up
|
||||
// v0.13 surfaces the moment the host advertises them. The id
|
||||
// value is the capabilities-line string — a stable identity
|
||||
// that flips exactly when the detector fires. Nil store ↔
|
||||
// `.empty` capabilities, which is what the VM defaults to.
|
||||
.task(id: capabilitiesStore?.capabilities.versionLine ?? "") {
|
||||
viewModel.attachCapabilitiesStore(capabilitiesStore)
|
||||
}
|
||||
.task {
|
||||
await viewModel.loadRecentSessions()
|
||||
viewModel.refreshCredentialPreflight()
|
||||
|
||||
@@ -16,6 +16,11 @@ struct RichChatInputBar: View {
|
||||
let isEnabled: Bool
|
||||
var commands: [HermesSlashCommand] = []
|
||||
var showCompressButton: Bool = false
|
||||
/// Whether the agent is currently mid-turn. Used to grey-out
|
||||
/// `/steer` in the slash menu on idle pre-v0.13 hosts (where the
|
||||
/// command silently no-ops). v0.13+ hosts allow `/steer` on idle
|
||||
/// and the row stays interactive regardless of `isAgentWorking`.
|
||||
var isAgentWorking: Bool = false
|
||||
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
@@ -52,6 +57,8 @@ struct RichChatInputBar: View {
|
||||
SlashCommandMenu(
|
||||
commands: filteredCommands,
|
||||
agentHasCommands: !commands.isEmpty,
|
||||
disabledCommandNames: disabledMenuCommandNames,
|
||||
disabledReason: disabledMenuReason,
|
||||
selectedIndex: $selectedIndex,
|
||||
onSelect: insertCommand
|
||||
)
|
||||
@@ -392,6 +399,27 @@ struct RichChatInputBar: View {
|
||||
SlashCommandMenu.filter(commands: commands, query: menuQuery)
|
||||
}
|
||||
|
||||
/// Names of menu rows that should render greyed-out + ignore taps.
|
||||
/// v2.8 / Hermes v0.13: `/steer` is greyed only when the connected
|
||||
/// host is pre-v0.13 AND the session is idle. Pre-v0.13 hosts
|
||||
/// silently no-op `/steer` outside an active turn — surfacing the
|
||||
/// row as "use during a turn" is friendlier than letting the user
|
||||
/// click and see nothing happen. v0.13+ hosts allow steer-on-idle
|
||||
/// (the command just sends as a regular prompt) so the row stays
|
||||
/// interactive there.
|
||||
private var disabledMenuCommandNames: Set<String> {
|
||||
let hasSteerOnIdle = capabilitiesStore?.capabilities.hasACPSteerOnIdle ?? false
|
||||
if !isAgentWorking && !hasSteerOnIdle {
|
||||
return ["steer"]
|
||||
}
|
||||
return []
|
||||
}
|
||||
|
||||
private var disabledMenuReason: String? {
|
||||
guard !disabledMenuCommandNames.isEmpty else { return nil }
|
||||
return "Use `/steer` while the agent is working — your Hermes version doesn't support steering on idle sessions."
|
||||
}
|
||||
|
||||
private func updateMenuState() {
|
||||
let shouldShow = shouldShowMenu
|
||||
|
||||
|
||||
@@ -25,10 +25,20 @@ struct SessionInfoBar: View {
|
||||
/// name. Nil for non-project chats and for projects that aren't
|
||||
/// git repos.
|
||||
var gitBranch: String? = nil
|
||||
/// Active locked goal (Hermes v0.13 `/goal`). Nil hides the pill.
|
||||
/// Optimistic — set by `RichChatViewModel.recordActiveGoal(text:)`
|
||||
/// when the user sends `/goal …`.
|
||||
var activeGoal: HermesActiveGoal? = nil
|
||||
/// Invoked when the user picks "Clear goal" from the goal pill's
|
||||
/// context menu. Caller dispatches `/goal --clear` so the optimistic
|
||||
/// pill clear and the server-side authoritative state stay in sync.
|
||||
var onClearGoal: (() -> Void)? = nil
|
||||
/// Local mirror of prompts queued via `/queue …` (Hermes v0.13).
|
||||
/// Empty list hides the chip.
|
||||
var queuedPrompts: [HermesQueuedPrompt] = []
|
||||
/// Capability snapshot for v0.13+ surfaces. Defaulted so previews and
|
||||
/// pre-v0.13 hosts render the v2.7.5 layout unchanged. Coordinated
|
||||
/// with WS-2 — both WSes add `capabilities` to this view; whichever
|
||||
/// lands first establishes the prop.
|
||||
/// with WS-2 — both WSes add `capabilities` to this view.
|
||||
var capabilities: HermesCapabilities = .empty
|
||||
|
||||
/// Active Hermes profile name (issue #50). Resolved on each body
|
||||
@@ -72,6 +82,42 @@ struct SessionInfoBar: View {
|
||||
}
|
||||
}
|
||||
|
||||
// Goal pill (v2.8 / Hermes v0.13). `.info` keeps it
|
||||
// visually decodable from the rust accent (project /
|
||||
// branch) and the warning amber (queue chip). The
|
||||
// pill renders only when `activeGoal` is non-nil —
|
||||
// pre-v0.13 hosts can't reach the `/goal` send path
|
||||
// through the slash menu (it's filtered out in
|
||||
// `availableCommands`), so the pill stays absent there
|
||||
// by transitive impossibility.
|
||||
if let activeGoal {
|
||||
HStack(spacing: 4) {
|
||||
Image(systemName: "scope")
|
||||
Text(Self.truncatedGoal(activeGoal.text))
|
||||
}
|
||||
.scarfStyle(.caption)
|
||||
.padding(.horizontal, ScarfSpace.s2)
|
||||
.padding(.vertical, 2)
|
||||
.background(Capsule().fill(ScarfColor.info.opacity(0.16)))
|
||||
.foregroundStyle(ScarfColor.info)
|
||||
.help("Goal locked: \(activeGoal.text)")
|
||||
.contextMenu {
|
||||
if let onClearGoal {
|
||||
Button("Clear goal", role: .destructive, action: onClearGoal)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Queue chip (v2.8 / Hermes v0.13). Local mirror only —
|
||||
// Hermes is the authoritative owner of the actual
|
||||
// queue. Per-entry deletion isn't exposed (Hermes has
|
||||
// no remove-by-id verb), and the v2.8.0 plan drops the
|
||||
// global "Clear all" button to avoid lying about
|
||||
// server-side state. The popover is read-only.
|
||||
if !queuedPrompts.isEmpty {
|
||||
ChatQueueIndicator(queuedPrompts: queuedPrompts)
|
||||
}
|
||||
|
||||
HStack(spacing: 4) {
|
||||
Circle()
|
||||
.fill(isWorking ? ScarfColor.success : ScarfColor.foregroundFaint)
|
||||
@@ -159,4 +205,11 @@ struct SessionInfoBar: View {
|
||||
private func formatTokens(_ count: Int) -> String {
|
||||
count.formatted(.number.notation(.compactName).precision(.fractionLength(0...1)))
|
||||
}
|
||||
|
||||
/// Cap goal text in the chip to keep the SessionInfoBar from
|
||||
/// wrapping when the user locks a long goal. Full goal text is
|
||||
/// available in the tooltip via `.help(...)`.
|
||||
static func truncatedGoal(_ text: String) -> String {
|
||||
text.count <= 36 ? text : String(text.prefix(33)) + "…"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -11,6 +11,13 @@ struct SlashCommandMenu: View {
|
||||
/// Whether the agent advertised any commands at all. Lets us distinguish
|
||||
/// "agent hasn't sent commands yet" from "filter matched nothing".
|
||||
let agentHasCommands: Bool
|
||||
/// Names that render greyed-out + ignore taps. v2.8 uses this only
|
||||
/// for `/steer` on pre-v0.13 idle sessions; v0.13 hosts allow steer
|
||||
/// on idle and the set is empty.
|
||||
var disabledCommandNames: Set<String> = []
|
||||
/// Tooltip shown on disabled rows. Reused per-row in v2.8 — only
|
||||
/// one disabled case ships, so a single shared string is enough.
|
||||
var disabledReason: String? = nil
|
||||
@Binding var selectedIndex: Int
|
||||
var onSelect: (HermesSlashCommand) -> Void
|
||||
|
||||
@@ -50,13 +57,17 @@ struct SlashCommandMenu: View {
|
||||
ScrollView {
|
||||
LazyVStack(spacing: 0) {
|
||||
ForEach(Array(commands.enumerated()), id: \.element.id) { index, command in
|
||||
let isDisabled = disabledCommandNames.contains(command.name)
|
||||
SlashCommandRow(
|
||||
command: command,
|
||||
isSelected: index == selectedIndex
|
||||
isSelected: index == selectedIndex,
|
||||
isDisabled: isDisabled,
|
||||
disabledReason: isDisabled ? disabledReason : nil
|
||||
)
|
||||
.id(index)
|
||||
.contentShape(Rectangle())
|
||||
.onTapGesture {
|
||||
guard !isDisabled else { return }
|
||||
selectedIndex = index
|
||||
onSelect(command)
|
||||
}
|
||||
@@ -77,6 +88,8 @@ struct SlashCommandMenu: View {
|
||||
private struct SlashCommandRow: View {
|
||||
let command: HermesSlashCommand
|
||||
let isSelected: Bool
|
||||
var isDisabled: Bool = false
|
||||
var disabledReason: String? = nil
|
||||
|
||||
var body: some View {
|
||||
HStack(alignment: .firstTextBaseline, spacing: 8) {
|
||||
@@ -116,11 +129,19 @@ private struct SlashCommandRow: View {
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.lineLimit(2)
|
||||
}
|
||||
if isDisabled, let reason = disabledReason {
|
||||
Text(reason)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.lineLimit(2)
|
||||
}
|
||||
}
|
||||
Spacer(minLength: 0)
|
||||
}
|
||||
.padding(.horizontal, ScarfSpace.s3)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
.background(isSelected ? ScarfColor.accentTint : Color.clear)
|
||||
.opacity(isDisabled ? 0.55 : 1.0)
|
||||
.help(isDisabled ? (disabledReason ?? "") : "")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -146,7 +146,7 @@ final class CronViewModel {
|
||||
}
|
||||
}
|
||||
|
||||
func createJob(schedule: String, prompt: String, name: String, deliver: String, skills: [String], script: String, repeatCount: String, workdir: String = "") {
|
||||
func createJob(schedule: String, prompt: String, name: String, deliver: String, skills: [String], script: String, repeatCount: String, workdir: String = "", noAgent: Bool = false) {
|
||||
var args = ["cron", "create"]
|
||||
if !name.isEmpty { args += ["--name", name] }
|
||||
if !deliver.isEmpty { args += ["--deliver", deliver] }
|
||||
@@ -158,12 +158,25 @@ final class CronViewModel {
|
||||
// know the flag — argparse rejects unknown args, so the form
|
||||
// omits the flag when the field is empty.
|
||||
if !workdir.isEmpty { args += ["--workdir", workdir] }
|
||||
// v0.13+: --no-agent runs the pre-run script and skips the AI turn.
|
||||
// Caller (CronView) strips this on pre-v0.13 hosts so the flag is
|
||||
// never emitted to a Hermes that can't parse it.
|
||||
if noAgent { args.append("--no-agent") }
|
||||
args.append(schedule)
|
||||
if !prompt.isEmpty { args.append(prompt) }
|
||||
// TODO(WS-7-Q5): When --no-agent is set Hermes ignores the prompt arg,
|
||||
// but argparse still wants positional args to line up with the
|
||||
// schedule. The plan recommends passing an empty string explicitly so
|
||||
// the positional parser doesn't treat the prompt as missing — verify
|
||||
// this behaviour against `hermes cron create --help` on a v0.13 host.
|
||||
if noAgent {
|
||||
args.append("")
|
||||
} else if !prompt.isEmpty {
|
||||
args.append(prompt)
|
||||
}
|
||||
runAndReload(args, success: "Job created")
|
||||
}
|
||||
|
||||
func updateJob(id: String, schedule: String?, prompt: String?, name: String?, deliver: String?, repeatCount: String?, newSkills: [String]?, clearSkills: Bool, script: String?, workdir: String? = nil) {
|
||||
func updateJob(id: String, schedule: String?, prompt: String?, name: String?, deliver: String?, repeatCount: String?, newSkills: [String]?, clearSkills: Bool, script: String?, workdir: String? = nil, noAgent: Bool? = nil) {
|
||||
var args = ["cron", "edit", id]
|
||||
if let schedule, !schedule.isEmpty { args += ["--schedule", schedule] }
|
||||
if let prompt, !prompt.isEmpty { args += ["--prompt", prompt] }
|
||||
@@ -180,6 +193,16 @@ final class CronViewModel {
|
||||
// = user cleared an existing workdir; Hermes documents `--workdir ""`
|
||||
// on edit as the explicit clear gesture, mirroring the `--script` shape.
|
||||
if let workdir { args += ["--workdir", workdir] }
|
||||
// TODO(WS-7-Q4): The toggle-off shape of `--no-agent` on edit is
|
||||
// unverified. Plan assumes Hermes accepts `--agent` to flip the flag
|
||||
// back; if the CLI is one-way (`--no-agent` only), the edit-mode
|
||||
// toggle should disable itself with a tooltip explaining the
|
||||
// limitation. Send the flag in the assumed shape for now and adjust
|
||||
// post-integration.
|
||||
if let noAgent {
|
||||
if noAgent { args.append("--no-agent") }
|
||||
else { args.append("--agent") }
|
||||
}
|
||||
runAndReload(args, success: "Updated")
|
||||
}
|
||||
|
||||
|
||||
@@ -25,6 +25,10 @@ struct CronView: View {
|
||||
capabilitiesStore?.capabilities.hasCronWorkdir ?? false
|
||||
}
|
||||
|
||||
private var hasCronNoAgent: Bool {
|
||||
capabilitiesStore?.capabilities.hasCronNoAgent ?? false
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
VStack(spacing: 0) {
|
||||
pageHeader
|
||||
@@ -47,7 +51,7 @@ struct CronView: View {
|
||||
// polling timer. Same wiring ActivityView uses.
|
||||
.onChange(of: fileWatcher.lastChangeDate) { viewModel.load() }
|
||||
.sheet(isPresented: $viewModel.showCreateSheet) {
|
||||
CronJobEditor(mode: .create, availableSkills: viewModel.availableSkills, supportsWorkdir: hasCronWorkdir) { form in
|
||||
CronJobEditor(mode: .create, availableSkills: viewModel.availableSkills, supportsWorkdir: hasCronWorkdir, supportsNoAgent: hasCronNoAgent) { form in
|
||||
viewModel.createJob(
|
||||
schedule: form.schedule,
|
||||
prompt: form.prompt,
|
||||
@@ -56,7 +60,12 @@ struct CronView: View {
|
||||
skills: form.skills,
|
||||
script: form.script,
|
||||
repeatCount: form.repeatCount,
|
||||
workdir: hasCronWorkdir ? form.workdir : ""
|
||||
workdir: hasCronWorkdir ? form.workdir : "",
|
||||
// Mirrors the workdir strip-on-pre-version pattern: pre-v0.13
|
||||
// hosts get a hard `false`, so a stale form value (or a
|
||||
// hand-edited jobs.json round-tripped through edit-mode)
|
||||
// can't sneak `--no-agent` into a CLI that doesn't grok it.
|
||||
noAgent: hasCronNoAgent ? form.noAgent : false
|
||||
)
|
||||
viewModel.showCreateSheet = false
|
||||
} onCancel: {
|
||||
@@ -64,7 +73,7 @@ struct CronView: View {
|
||||
}
|
||||
}
|
||||
.sheet(item: $viewModel.editingJob) { job in
|
||||
CronJobEditor(mode: .edit(job), availableSkills: viewModel.availableSkills, supportsWorkdir: hasCronWorkdir) { form in
|
||||
CronJobEditor(mode: .edit(job), availableSkills: viewModel.availableSkills, supportsWorkdir: hasCronWorkdir, supportsNoAgent: hasCronNoAgent) { form in
|
||||
viewModel.updateJob(
|
||||
id: job.id,
|
||||
schedule: form.schedule,
|
||||
@@ -75,7 +84,8 @@ struct CronView: View {
|
||||
newSkills: form.skills,
|
||||
clearSkills: form.clearSkills,
|
||||
script: form.script,
|
||||
workdir: hasCronWorkdir ? form.workdir : nil
|
||||
workdir: hasCronWorkdir ? form.workdir : nil,
|
||||
noAgent: hasCronNoAgent ? form.noAgent : nil
|
||||
)
|
||||
viewModel.editingJob = nil
|
||||
} onCancel: {
|
||||
@@ -643,6 +653,9 @@ struct CronJobEditor: View {
|
||||
/// v0.12+ workdir flag — fills `--workdir <path>`. Empty string
|
||||
/// preserves the v0.11 behaviour of running with no cwd hint.
|
||||
var workdir: String = ""
|
||||
/// v0.13+ `--no-agent` flag — script-only watchdog mode. Hermes
|
||||
/// runs the pre-run script and skips the AI turn.
|
||||
var noAgent: Bool = false
|
||||
}
|
||||
|
||||
let mode: Mode
|
||||
@@ -650,6 +663,10 @@ struct CronJobEditor: View {
|
||||
/// Pass `false` on pre-v0.12 hosts; the `--workdir` field is hidden and
|
||||
/// the form's value is dropped when the parent calls `createJob`/`updateJob`.
|
||||
let supportsWorkdir: Bool
|
||||
/// Pass `false` on pre-v0.13 hosts; the `--no-agent` toggle is hidden
|
||||
/// and the parent strips the form's value before calling
|
||||
/// `createJob`/`updateJob`. Mirrors the `supportsWorkdir` pattern.
|
||||
let supportsNoAgent: Bool
|
||||
let onSave: (FormState) -> Void
|
||||
let onCancel: () -> Void
|
||||
|
||||
@@ -681,12 +698,25 @@ struct CronJobEditor: View {
|
||||
)
|
||||
.scrollContentBackground(.hidden)
|
||||
}
|
||||
.opacity(form.noAgent ? 0.4 : 1.0)
|
||||
.disabled(form.noAgent)
|
||||
formField("Deliver", text: $form.deliver, placeholder: "origin | local | discord:CHANNEL | telegram:CHAT", mono: true)
|
||||
formField("Repeat", text: $form.repeatCount, placeholder: "Optional count")
|
||||
formField("Script path", text: $form.script, placeholder: "Python script whose stdout is injected", mono: true)
|
||||
if supportsWorkdir {
|
||||
formField("Workdir", text: $form.workdir, placeholder: "Absolute path; pulls AGENTS.md/CLAUDE.md context", mono: true)
|
||||
}
|
||||
if supportsNoAgent {
|
||||
Toggle("Run script only (no agent call)", isOn: $form.noAgent)
|
||||
.scarfStyle(.body)
|
||||
.tint(ScarfColor.accent)
|
||||
if form.noAgent {
|
||||
Text("Watchdog mode — Hermes runs the pre-run script and skips the AI turn. Prompt + skills are ignored.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.padding(.leading, ScarfSpace.s3)
|
||||
}
|
||||
}
|
||||
if !availableSkills.isEmpty {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("Skills")
|
||||
@@ -723,6 +753,8 @@ struct CronJobEditor: View {
|
||||
.tint(ScarfColor.accent)
|
||||
}
|
||||
}
|
||||
.opacity(form.noAgent ? 0.4 : 1.0)
|
||||
.disabled(form.noAgent)
|
||||
}
|
||||
HStack {
|
||||
Spacer()
|
||||
@@ -746,6 +778,7 @@ struct CronJobEditor: View {
|
||||
form.skills = job.skills ?? []
|
||||
form.script = job.preRunScript ?? ""
|
||||
form.workdir = job.workdir ?? ""
|
||||
form.noAgent = job.noAgent ?? false
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,122 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Mac sub-view rendered between the active-skill leaderboards and the
|
||||
/// last-report block on Hermes v0.13+ hosts. Lists everything currently
|
||||
/// archived (`hermes curator list-archived`) with per-row Restore + a
|
||||
/// bulk Prune affordance routed through the parent's confirm sheet.
|
||||
///
|
||||
/// Empty-state copy explains what archive means — useful when the
|
||||
/// curator hasn't run yet on a fresh install (no archives ≠ a problem).
|
||||
struct CuratorArchivedSection: View {
|
||||
let archived: [HermesCuratorArchivedSkill]
|
||||
let isLoading: Bool
|
||||
let onRestore: (String) -> Void
|
||||
let onPruneAll: () -> Void
|
||||
|
||||
var body: some View {
|
||||
ScarfCard {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
header
|
||||
if isLoading && archived.isEmpty {
|
||||
loadingRow
|
||||
} else if archived.isEmpty {
|
||||
emptyState
|
||||
} else {
|
||||
rows
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var header: some View {
|
||||
HStack(alignment: .firstTextBaseline) {
|
||||
ScarfSectionHeader("Archived")
|
||||
Spacer()
|
||||
Text("\(archived.count) skill\(archived.count == 1 ? "" : "s")")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
if !archived.isEmpty {
|
||||
Button("Prune All…") {
|
||||
onPruneAll()
|
||||
}
|
||||
.buttonStyle(ScarfDestructiveButton())
|
||||
.help("Remove every archived skill from disk. Cannot be undone.")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var loadingRow: some View {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
ProgressView().controlSize(.small)
|
||||
Text("Loading archived skills…")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
Spacer()
|
||||
}
|
||||
}
|
||||
|
||||
private var emptyState: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s1) {
|
||||
Text("No archived skills.")
|
||||
.scarfStyle(.body)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
Text("The curator moves stale or redundant skills here on its weekly review. Until then, this list stays empty.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
}
|
||||
}
|
||||
|
||||
private var rows: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s1) {
|
||||
ForEach(archived) { skill in
|
||||
ArchivedSkillRow(
|
||||
skill: skill,
|
||||
onRestore: { onRestore(skill.name) }
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private struct ArchivedSkillRow: View {
|
||||
let skill: HermesCuratorArchivedSkill
|
||||
let onRestore: () -> Void
|
||||
|
||||
var body: some View {
|
||||
HStack(alignment: .center, spacing: ScarfSpace.s2) {
|
||||
Image(systemName: "archivebox.fill")
|
||||
.font(.system(size: 12))
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
Text(skill.name)
|
||||
.scarfStyle(.body)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
.lineLimit(1)
|
||||
if let reason = skill.reason, !reason.isEmpty {
|
||||
Text(reason)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.lineLimit(1)
|
||||
}
|
||||
}
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
Text(skill.archivedAtLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.frame(width: 96, alignment: .trailing)
|
||||
Text(skill.sizeLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.frame(width: 72, alignment: .trailing)
|
||||
Button("Restore") {
|
||||
onRestore()
|
||||
}
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.controlSize(.small)
|
||||
.help("Restore \(skill.name) to the active skill set")
|
||||
}
|
||||
.padding(.vertical, 2)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,123 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Destructive-confirm sheet for `hermes curator prune` (bulk).
|
||||
///
|
||||
/// Pattern matches `TemplateUninstallSheet`: enumerate every entry that
|
||||
/// will be removed, surface the total count + bytes, and require an
|
||||
/// explicit click on a red `ScarfDestructiveButton` ("Prune
|
||||
/// permanently") before kicking off the destructive call. Cancel owns
|
||||
/// the keyboard default action so an accidental Enter-press doesn't
|
||||
/// nuke the archive.
|
||||
struct CuratorPruneConfirmSheet: View {
|
||||
@Environment(\.dismiss) private var dismiss
|
||||
let summary: CuratorPruneSummary
|
||||
let isPruning: Bool
|
||||
let onConfirm: () -> Void
|
||||
let onCancel: () -> Void
|
||||
|
||||
var body: some View {
|
||||
VStack(alignment: .leading, spacing: 0) {
|
||||
header
|
||||
.padding(.bottom, ScarfSpace.s2)
|
||||
ScarfDivider()
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
ForEach(summary.wouldRemove) { skill in
|
||||
row(skill: skill)
|
||||
}
|
||||
if summary.wouldRemove.isEmpty {
|
||||
Text("Nothing currently archived. Nothing to prune.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
}
|
||||
}
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
}
|
||||
ScarfDivider()
|
||||
footer
|
||||
.padding(.top, ScarfSpace.s2)
|
||||
}
|
||||
.frame(minWidth: 520, minHeight: 380)
|
||||
.padding(ScarfSpace.s4)
|
||||
}
|
||||
|
||||
private var header: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s1) {
|
||||
HStack(alignment: .firstTextBaseline) {
|
||||
Text("Prune Archived Skills")
|
||||
.scarfStyle(.title2)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
Spacer()
|
||||
if summary.totalCount > 0 {
|
||||
ScarfBadge("\(summary.totalCount)", kind: .danger)
|
||||
}
|
||||
}
|
||||
Text("This permanently deletes every archived skill from disk. Restoring an archived skill is no longer possible after pruning.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
if summary.totalBytes > 0 {
|
||||
Text("Total to remove: \(summary.totalBytesLabel)")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private func row(skill: HermesCuratorArchivedSkill) -> some View {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
Image(systemName: "minus.circle")
|
||||
.foregroundStyle(ScarfColor.danger)
|
||||
.font(.caption)
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
Text(skill.name)
|
||||
.scarfStyle(.body)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
.lineLimit(1)
|
||||
if let reason = skill.reason, !reason.isEmpty {
|
||||
Text(reason)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.lineLimit(1)
|
||||
}
|
||||
}
|
||||
Spacer()
|
||||
Text(skill.archivedAtLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.frame(width: 96, alignment: .trailing)
|
||||
Text(skill.sizeLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.frame(width: 72, alignment: .trailing)
|
||||
}
|
||||
}
|
||||
|
||||
private var footer: some View {
|
||||
HStack {
|
||||
Button("Cancel") {
|
||||
onCancel()
|
||||
dismiss()
|
||||
}
|
||||
.buttonStyle(ScarfGhostButton())
|
||||
// Cancel owns .defaultAction so accidental Enter-presses
|
||||
// don't trigger the destructive button (template-uninstall
|
||||
// pattern recommended in the WS-4 plan).
|
||||
.keyboardShortcut(.defaultAction)
|
||||
.disabled(isPruning)
|
||||
Spacer()
|
||||
if isPruning {
|
||||
ProgressView().controlSize(.small)
|
||||
}
|
||||
Button("Prune permanently") {
|
||||
onConfirm()
|
||||
}
|
||||
.buttonStyle(ScarfDestructiveButton())
|
||||
.disabled(isPruning || summary.wouldRemove.isEmpty)
|
||||
.accessibilityIdentifier("curatorPrune.confirm")
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -2,18 +2,16 @@ import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Modal that lists archived skills (state ≠ active) and exposes a
|
||||
/// one-click "Restore" action per row. v0.12 archives are recoverable —
|
||||
/// `hermes curator restore <name>` brings the skill back into
|
||||
/// `~/.hermes/skills/<category>/<name>/` and re-marks it active.
|
||||
/// Legacy v0.12 fallback for restoring an archived skill by typed
|
||||
/// name. Hermes v0.12 didn't ship `curator list-archived`, so the only
|
||||
/// way to restore was to remember the skill name and pass it through
|
||||
/// `hermes curator restore <name>`.
|
||||
///
|
||||
/// The Curator's `status` text doesn't enumerate archived skills with
|
||||
/// names; we surface what's available (counts + pinned list) and rely
|
||||
/// on the user knowing the names. Hermes ergo does an interactive
|
||||
/// `--name` arg if missing — but Scarf prefers explicit selection so
|
||||
/// users don't have to remember names. For v2.6 we render a free-form
|
||||
/// text field; once Hermes ships a `curator list-archived` (tracked
|
||||
/// upstream), swap to a pickable list.
|
||||
/// **v0.13+ flow (preferred):** `CuratorArchivedSection` renders a
|
||||
/// per-skill list with a one-click Restore button per row — no typing
|
||||
/// required. This sheet stays reachable from the overflow menu only on
|
||||
/// pre-v0.13 hosts (gated by `!hasCuratorArchive`). Don't delete this
|
||||
/// file even after WS-4 ships; v0.12 hosts still depend on it.
|
||||
struct CuratorRestoreSheet: View {
|
||||
let viewModel: CuratorViewModel
|
||||
|
||||
|
||||
@@ -2,57 +2,52 @@ import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Mac UI for Hermes v0.12's autonomous skill curator.
|
||||
/// Mac UI for Hermes's autonomous skill curator (v0.12 base + v0.13
|
||||
/// archive/prune surface).
|
||||
///
|
||||
/// Surfaces the running state (enabled / paused / disabled), last-run
|
||||
/// metadata, agent-created skill counts, and the most/least-active /
|
||||
/// least-recently-active leaderboards. Pin-and-restore actions hit
|
||||
/// `hermes curator pin/unpin/restore` via CuratorViewModel.
|
||||
/// metadata, agent-created skill counts, the most/least-active /
|
||||
/// least-recently-active leaderboards, and on v0.13+ hosts the new
|
||||
/// archived-skills section + per-row Archive button on each leaderboard
|
||||
/// entry. Pin / unpin / restore / archive / prune route through
|
||||
/// CuratorViewModel → CuratorService.
|
||||
///
|
||||
/// Capability-gated upstream: AppCoordinator only wires the sidebar
|
||||
/// item when `HermesCapabilities.hasCurator` is true. This view assumes
|
||||
/// it's reachable on a v0.12+ host.
|
||||
/// item when `HermesCapabilities.hasCurator` is true. Archive surfaces
|
||||
/// gate independently on `hasCuratorArchive`; pre-v0.13 hosts see the
|
||||
/// v2.7.x layout unchanged (legacy `CuratorRestoreSheet` reachable from
|
||||
/// the overflow menu, no Archive section, fire-and-forget Run Now).
|
||||
struct CuratorView: View {
|
||||
@State private var viewModel: CuratorViewModel
|
||||
@State private var showRestoreSheet = false
|
||||
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
init(context: ServerContext) {
|
||||
_viewModel = State(initialValue: CuratorViewModel(context: context))
|
||||
}
|
||||
|
||||
/// Single source of truth for "v0.13 archive surface visible". Read
|
||||
/// once in `body` and threaded into sub-views. Defensive default to
|
||||
/// `false` so previews / smoke tests behave like a pre-v0.13 host.
|
||||
private var archiveAvailable: Bool {
|
||||
capabilitiesStore?.capabilities.hasCuratorArchive ?? false
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s4) {
|
||||
ScarfPageHeader(
|
||||
"Curator",
|
||||
subtitle: "Autonomous skill maintenance — Hermes v0.12+"
|
||||
subtitle: archiveAvailable
|
||||
? "Autonomous skill maintenance — archive, prune, restore"
|
||||
: "Autonomous skill maintenance — Hermes v0.12+"
|
||||
) {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
if viewModel.isLoading {
|
||||
ProgressView().controlSize(.small)
|
||||
}
|
||||
Button("Run Now") {
|
||||
Task { await viewModel.runNow() }
|
||||
}
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.disabled(viewModel.isLoading)
|
||||
Menu {
|
||||
switch viewModel.status.state {
|
||||
case .paused:
|
||||
Button("Resume") { Task { await viewModel.resume() } }
|
||||
case .enabled:
|
||||
Button("Pause") { Task { await viewModel.pause() } }
|
||||
default:
|
||||
EmptyView()
|
||||
}
|
||||
Button("Restore Archived…") {
|
||||
showRestoreSheet = true
|
||||
}
|
||||
.disabled(viewModel.status.archivedSkills == 0)
|
||||
} label: {
|
||||
Image(systemName: "ellipsis.circle")
|
||||
}
|
||||
}
|
||||
headerActions
|
||||
}
|
||||
|
||||
if let errorMessage = viewModel.errorMessage {
|
||||
errorBanner(errorMessage)
|
||||
}
|
||||
|
||||
if let toast = viewModel.transientMessage {
|
||||
@@ -64,6 +59,19 @@ struct CuratorView: View {
|
||||
pinnedSection
|
||||
activityTables
|
||||
|
||||
if archiveAvailable {
|
||||
CuratorArchivedSection(
|
||||
archived: viewModel.archivedSkills,
|
||||
isLoading: viewModel.isLoadingArchive,
|
||||
onRestore: { name in
|
||||
Task { await viewModel.restore(name) }
|
||||
},
|
||||
onPruneAll: {
|
||||
Task { await viewModel.planPrune() }
|
||||
}
|
||||
)
|
||||
}
|
||||
|
||||
if let report = viewModel.lastReportMarkdown {
|
||||
lastReportSection(markdown: report)
|
||||
}
|
||||
@@ -71,10 +79,84 @@ struct CuratorView: View {
|
||||
.padding(ScarfSpace.s4)
|
||||
}
|
||||
.background(ScarfColor.backgroundPrimary)
|
||||
.task { await viewModel.load() }
|
||||
.task {
|
||||
await viewModel.load()
|
||||
if archiveAvailable {
|
||||
await viewModel.loadArchive()
|
||||
}
|
||||
}
|
||||
.sheet(isPresented: $showRestoreSheet) {
|
||||
CuratorRestoreSheet(viewModel: viewModel)
|
||||
}
|
||||
.sheet(
|
||||
isPresented: Binding(
|
||||
get: { viewModel.pruneSummary != nil },
|
||||
set: { isShown in
|
||||
if !isShown { viewModel.cancelPrune() }
|
||||
}
|
||||
)
|
||||
) {
|
||||
if let summary = viewModel.pruneSummary {
|
||||
CuratorPruneConfirmSheet(
|
||||
summary: summary,
|
||||
isPruning: viewModel.isPruning,
|
||||
onConfirm: {
|
||||
Task { await viewModel.confirmPrune() }
|
||||
},
|
||||
onCancel: {
|
||||
viewModel.cancelPrune()
|
||||
}
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private var headerActions: some View {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
if viewModel.isLoading {
|
||||
ProgressView().controlSize(.small)
|
||||
}
|
||||
Button("Run Now") {
|
||||
Task {
|
||||
await viewModel.runNow(
|
||||
synchronous: archiveAvailable,
|
||||
timeout: 600
|
||||
)
|
||||
}
|
||||
}
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.disabled(viewModel.isLoading)
|
||||
.help(archiveAvailable
|
||||
? "Curator runs synchronously on Hermes v0.13+. Usually 10–90s."
|
||||
: "Trigger a curator run. Returns immediately on pre-v0.13 hosts.")
|
||||
|
||||
Menu {
|
||||
switch viewModel.status.state {
|
||||
case .paused:
|
||||
Button("Resume") { Task { await viewModel.resume() } }
|
||||
case .enabled:
|
||||
Button("Pause") { Task { await viewModel.pause() } }
|
||||
default:
|
||||
EmptyView()
|
||||
}
|
||||
|
||||
if archiveAvailable {
|
||||
Divider()
|
||||
Button("Prune Archived…", role: .destructive) {
|
||||
Task { await viewModel.planPrune() }
|
||||
}
|
||||
.disabled(viewModel.archivedSkills.isEmpty && !viewModel.isLoadingArchive)
|
||||
} else {
|
||||
Button("Restore Archived…") {
|
||||
showRestoreSheet = true
|
||||
}
|
||||
.disabled(viewModel.status.archivedSkills == 0)
|
||||
}
|
||||
} label: {
|
||||
Image(systemName: "ellipsis.circle")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var statusSummary: some View {
|
||||
@@ -206,6 +288,10 @@ struct CuratorView: View {
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.help(viewModel.status.pinnedNames.contains(row.name) ? "Pinned" : "Pin skill")
|
||||
|
||||
if archiveAvailable {
|
||||
archiveButton(for: row.name)
|
||||
}
|
||||
}
|
||||
.padding(.vertical, 2)
|
||||
}
|
||||
@@ -213,6 +299,25 @@ struct CuratorView: View {
|
||||
}
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private func archiveButton(for name: String) -> some View {
|
||||
if viewModel.pendingArchiveName == name {
|
||||
ProgressView()
|
||||
.controlSize(.small)
|
||||
.frame(width: 14, height: 14)
|
||||
} else {
|
||||
Button {
|
||||
Task { await viewModel.archive(name) }
|
||||
} label: {
|
||||
Image(systemName: "archivebox")
|
||||
.font(.system(size: 12))
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.help("Archive (move out of active set)")
|
||||
.disabled(viewModel.pendingArchiveName != nil)
|
||||
}
|
||||
}
|
||||
|
||||
private func counterChip(label: String, value: Int) -> some View {
|
||||
Text("\(label) \(value)")
|
||||
.font(ScarfFont.monoSmall)
|
||||
@@ -277,6 +382,35 @@ struct CuratorView: View {
|
||||
.background(ScarfColor.accentTint)
|
||||
.clipShape(RoundedRectangle(cornerRadius: ScarfRadius.md))
|
||||
}
|
||||
|
||||
/// Inline yellow banner for CLI failures. Non-blocking — sits above
|
||||
/// the status summary and dismisses with the "x" so users can keep
|
||||
/// interacting with the leaderboard. Mirrors the pattern in
|
||||
/// KanbanBoardView.
|
||||
private func errorBanner(_ message: String) -> some View {
|
||||
HStack(alignment: .top, spacing: ScarfSpace.s2) {
|
||||
Image(systemName: "exclamationmark.triangle.fill")
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
Text(message)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
Button {
|
||||
viewModel.dismissError()
|
||||
} label: {
|
||||
Image(systemName: "xmark.circle.fill")
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.help("Dismiss")
|
||||
}
|
||||
.padding(.horizontal, ScarfSpace.s3)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
.background(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md)
|
||||
.fill(ScarfColor.warning.opacity(0.12))
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
/// Simple `FlowLayout` for the pinned-skill chips. Custom layout
|
||||
|
||||
@@ -1,7 +1,13 @@
|
||||
import Foundation
|
||||
import ScarfCore
|
||||
|
||||
struct GatewayInfo {
|
||||
// **Local rename for v0.13 / WS-5.** The user-facing label is "Messaging
|
||||
// Gateway"; the type names mirror that. The `SidebarSection.gateway` enum
|
||||
// case + `gateway_state.json` / `gateway.log` paths intentionally stay
|
||||
// unchanged — those aren't user-facing strings, and renaming them would
|
||||
// churn unrelated callers without changing what users see.
|
||||
|
||||
struct MessagingGatewayInfo {
|
||||
let pid: Int?
|
||||
let state: String
|
||||
let exitReason: String?
|
||||
@@ -37,32 +43,48 @@ struct PendingPairing: Identifiable {
|
||||
}
|
||||
|
||||
@Observable
|
||||
final class GatewayViewModel {
|
||||
@MainActor
|
||||
final class MessagingGatewayViewModel {
|
||||
let context: ServerContext
|
||||
/// Capability snapshot at view-init time. Read for the v0.13 cross-
|
||||
/// profile digest (`hasGatewayList`); other v0.13 surfaces live on
|
||||
/// per-platform setup views. `.empty` is fine outside the per-server
|
||||
/// `ContextBoundRoot` (Previews, smoke tests).
|
||||
let capabilities: HermesCapabilities
|
||||
|
||||
init(context: ServerContext = .local) {
|
||||
init(context: ServerContext = .local, capabilities: HermesCapabilities = .empty) {
|
||||
self.context = context
|
||||
self.capabilities = capabilities
|
||||
}
|
||||
|
||||
var gateway = GatewayInfo(pid: nil, state: "unknown", exitReason: nil, startTime: nil, updatedAt: nil, platforms: [], isLoaded: false, isStale: false)
|
||||
var gateway = MessagingGatewayInfo(pid: nil, state: "unknown", exitReason: nil, startTime: nil, updatedAt: nil, platforms: [], isLoaded: false, isStale: false)
|
||||
var approvedUsers: [PairedUser] = []
|
||||
var pendingPairings: [PendingPairing] = []
|
||||
var isLoading = false
|
||||
var actionMessage: String?
|
||||
/// `hermes gateway list --json` snapshot. `nil` when the verb fails
|
||||
/// (pre-v0.13 host or no profiles registered yet) — the digest row
|
||||
/// hides itself in that case.
|
||||
var gatewayList: GatewayListSnapshot?
|
||||
|
||||
func load() {
|
||||
isLoading = true
|
||||
let ctx = context
|
||||
let caps = capabilities
|
||||
Task.detached { [weak self] in
|
||||
// Two sync transport calls + two CLI invocations — substantial
|
||||
// remote latency. Detach the whole load and commit at the end.
|
||||
let status = Self.fetchGatewayStatus(context: ctx)
|
||||
let pairing = Self.fetchPairing(context: ctx)
|
||||
let listSnap = caps.hasGatewayList
|
||||
? HermesGatewayListService.fetch(context: ctx)
|
||||
: nil
|
||||
await MainActor.run { [weak self] in
|
||||
guard let self else { return }
|
||||
self.gateway = status
|
||||
self.approvedUsers = pairing.approved
|
||||
self.pendingPairings = pairing.pending
|
||||
self.gatewayList = listSnap
|
||||
self.isLoading = false
|
||||
}
|
||||
}
|
||||
@@ -70,7 +92,7 @@ final class GatewayViewModel {
|
||||
|
||||
/// Static form of the gateway-status walk so the detached load can call
|
||||
/// it without bouncing back to MainActor.
|
||||
nonisolated private static func fetchGatewayStatus(context: ServerContext) -> GatewayInfo {
|
||||
nonisolated private static func fetchGatewayStatus(context: ServerContext) -> MessagingGatewayInfo {
|
||||
let stateJSON = context.readData(context.paths.gatewayStateJSON)
|
||||
var pid: Int?
|
||||
var state = "unknown"
|
||||
@@ -102,7 +124,7 @@ final class GatewayViewModel {
|
||||
let isLoaded = statusOutput.contains("service is loaded")
|
||||
let isStale = statusOutput.contains("stale")
|
||||
|
||||
return GatewayInfo(
|
||||
return MessagingGatewayInfo(
|
||||
pid: pid, state: state, exitReason: exitReason,
|
||||
startTime: startTime, updatedAt: updatedAt,
|
||||
platforms: platforms, isLoaded: isLoaded, isStale: isStale
|
||||
|
||||
@@ -2,12 +2,24 @@ import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Messaging Gateway page. Routes outbound chat to Discord / Telegram /
|
||||
/// Slack / etc. — distinct from the v0.10 **Tool Gateway** (Nous Portal
|
||||
/// subscription routing for web search / image / TTS / browser), which
|
||||
/// lives under `Features/Health/`. The user-facing label here is always
|
||||
/// "Messaging Gateway"; the SwiftUI struct stays `GatewayView` because
|
||||
/// `ContentView` references it by name (rename-on-touch invariant —
|
||||
/// avoid churning unrelated callers).
|
||||
struct GatewayView: View {
|
||||
@State private var viewModel: GatewayViewModel
|
||||
@State private var viewModel: MessagingGatewayViewModel
|
||||
@Environment(HermesFileWatcher.self) private var fileWatcher
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
init(context: ServerContext) {
|
||||
_viewModel = State(initialValue: GatewayViewModel(context: context))
|
||||
// Capabilities arrive via environment after init runs, so the VM
|
||||
// is constructed with `.empty` and refreshed on first appear via
|
||||
// `attach(capabilities:)`. Same pattern as the per-platform setup
|
||||
// views — see `MessagingGatewayViewModel.capabilities` doc comment.
|
||||
_viewModel = State(initialValue: MessagingGatewayViewModel(context: context))
|
||||
}
|
||||
|
||||
|
||||
@@ -15,10 +27,15 @@ struct GatewayView: View {
|
||||
VStack(spacing: 0) {
|
||||
ScarfPageHeader(
|
||||
"Messaging Gateway",
|
||||
subtitle: "Outbound channel bridge — Discord, Telegram, Slack, etc."
|
||||
subtitle: "Outbound channel bridge — Discord, Telegram, Slack, Google Chat, etc."
|
||||
)
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: 24) {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s4) {
|
||||
if let snap = viewModel.gatewayList,
|
||||
viewModel.capabilities.hasGatewayList,
|
||||
!snap.profiles.isEmpty {
|
||||
crossProfileDigest(snap)
|
||||
}
|
||||
serviceSection
|
||||
platformsSection
|
||||
pairingSection
|
||||
@@ -29,14 +46,58 @@ struct GatewayView: View {
|
||||
}
|
||||
.background(ScarfColor.backgroundPrimary)
|
||||
.navigationTitle("Messaging Gateway")
|
||||
.onAppear { viewModel.load() }
|
||||
.onAppear {
|
||||
attachCapabilitiesIfNeeded()
|
||||
viewModel.load()
|
||||
}
|
||||
.onChange(of: fileWatcher.lastChangeDate) { viewModel.load() }
|
||||
}
|
||||
|
||||
/// Re-create the VM with the resolved capabilities the first time the
|
||||
/// store hands us non-empty data. Same shape as `KanbanBoardView`'s
|
||||
/// `attach` helper.
|
||||
private func attachCapabilitiesIfNeeded() {
|
||||
guard let store = capabilitiesStore,
|
||||
store.capabilities.detected,
|
||||
!viewModel.capabilities.detected else { return }
|
||||
viewModel = MessagingGatewayViewModel(
|
||||
context: viewModel.context,
|
||||
capabilities: store.capabilities
|
||||
)
|
||||
}
|
||||
|
||||
// MARK: - v0.13 cross-profile digest
|
||||
|
||||
/// One-line summary above the gateway controls when the host is on
|
||||
/// v0.13+ and `hermes gateway list --json` returned at least one
|
||||
/// profile. Doubly-guarded — `hasGatewayList` AND `profiles != []`
|
||||
/// — so a v0.13 host with no registered profiles doesn't render
|
||||
/// an empty pill.
|
||||
private func crossProfileDigest(_ snap: GatewayListSnapshot) -> some View {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
Image(systemName: "dot.radiowaves.left.and.right")
|
||||
.foregroundStyle(ScarfColor.accent)
|
||||
Text(snap.headerDigest)
|
||||
.scarfStyle(.captionStrong)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
Spacer()
|
||||
}
|
||||
.padding(.horizontal, ScarfSpace.s3)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
.background(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.fill(ScarfColor.backgroundSecondary)
|
||||
)
|
||||
.overlay(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.strokeBorder(ScarfColor.border, lineWidth: 1)
|
||||
)
|
||||
}
|
||||
|
||||
// MARK: - Service
|
||||
|
||||
private var serviceSection: some View {
|
||||
VStack(alignment: .leading, spacing: 12) {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s3) {
|
||||
HStack {
|
||||
Text("Service")
|
||||
.font(.headline)
|
||||
@@ -46,15 +107,20 @@ struct GatewayView: View {
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
HStack(spacing: 8) {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
Button("Start") { viewModel.startGateway() }
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.controlSize(.small)
|
||||
Button("Stop") { viewModel.stopGateway() }
|
||||
.buttonStyle(ScarfSecondaryButton())
|
||||
.controlSize(.small)
|
||||
Button("Restart") { viewModel.restartGateway() }
|
||||
.buttonStyle(ScarfSecondaryButton())
|
||||
.controlSize(.small)
|
||||
}
|
||||
.controlSize(.small)
|
||||
}
|
||||
|
||||
HStack(spacing: 16) {
|
||||
HStack(spacing: ScarfSpace.s3) {
|
||||
StatusBadge(
|
||||
label: viewModel.gateway.state,
|
||||
isActive: viewModel.gateway.state == "running"
|
||||
@@ -97,7 +163,7 @@ struct GatewayView: View {
|
||||
// MARK: - Platforms
|
||||
|
||||
private var platformsSection: some View {
|
||||
VStack(alignment: .leading, spacing: 8) {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
Text("Platforms")
|
||||
.font(.headline)
|
||||
if viewModel.gateway.platforms.isEmpty {
|
||||
@@ -105,7 +171,7 @@ struct GatewayView: View {
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
} else {
|
||||
HStack(spacing: 12) {
|
||||
HStack(spacing: ScarfSpace.s3) {
|
||||
ForEach(viewModel.gateway.platforms) { platform in
|
||||
VStack(spacing: 6) {
|
||||
Image(systemName: platform.icon)
|
||||
@@ -119,9 +185,9 @@ struct GatewayView: View {
|
||||
)
|
||||
}
|
||||
.frame(maxWidth: .infinity)
|
||||
.padding(12)
|
||||
.padding(ScarfSpace.s3)
|
||||
.background(.quaternary.opacity(0.5))
|
||||
.clipShape(RoundedRectangle(cornerRadius: 8))
|
||||
.clipShape(RoundedRectangle(cornerRadius: ScarfRadius.md))
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -131,12 +197,12 @@ struct GatewayView: View {
|
||||
// MARK: - Pairing
|
||||
|
||||
private var pairingSection: some View {
|
||||
VStack(alignment: .leading, spacing: 12) {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s3) {
|
||||
Text("Paired Users")
|
||||
.font(.headline)
|
||||
|
||||
if !viewModel.pendingPairings.isEmpty {
|
||||
VStack(alignment: .leading, spacing: 8) {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
Label("Pending Approvals", systemImage: "clock.badge.questionmark")
|
||||
.font(.caption.bold())
|
||||
.foregroundStyle(.orange)
|
||||
@@ -150,12 +216,12 @@ struct GatewayView: View {
|
||||
viewModel.approvePairing(platform: pending.platform, code: pending.code)
|
||||
}
|
||||
.controlSize(.small)
|
||||
.buttonStyle(.borderedProminent)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
}
|
||||
.font(.caption)
|
||||
.padding(8)
|
||||
.padding(ScarfSpace.s2)
|
||||
.background(.orange.opacity(0.1))
|
||||
.clipShape(RoundedRectangle(cornerRadius: 6))
|
||||
.clipShape(RoundedRectangle(cornerRadius: ScarfRadius.sm))
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -182,9 +248,9 @@ struct GatewayView: View {
|
||||
}
|
||||
.controlSize(.small)
|
||||
}
|
||||
.padding(8)
|
||||
.padding(ScarfSpace.s2)
|
||||
.background(.quaternary.opacity(0.3))
|
||||
.clipShape(RoundedRectangle(cornerRadius: 6))
|
||||
.clipShape(RoundedRectangle(cornerRadius: ScarfRadius.sm))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -55,9 +55,22 @@ final class KanbanBoardViewModel {
|
||||
var assigneeFilter: String? // nil = all assignees
|
||||
var showArchived: Bool = false
|
||||
|
||||
/// Optimistic moves keyed by task id; cleared when the polled
|
||||
/// response includes the same status the optimistic move set.
|
||||
private var optimisticOverrides: [String: String] = [:]
|
||||
/// Optimistic in-flight overrides keyed by task id; cleared when the
|
||||
/// polled response confirms the new state.
|
||||
/// - Status side: drag-drop column moves.
|
||||
/// - Hallucination-gate side (v0.13): Verify clicks flip `pending` →
|
||||
/// `verified` locally so the banner disappears immediately.
|
||||
/// The override entry is dropped from the dictionary entirely once
|
||||
/// both sides are nil (no override needed).
|
||||
private struct OptimisticOverride {
|
||||
var status: String?
|
||||
var hallucinationGate: KanbanHallucinationGate?
|
||||
|
||||
var isEmpty: Bool {
|
||||
status == nil && hallucinationGate == nil
|
||||
}
|
||||
}
|
||||
private var optimisticOverrides: [String: OptimisticOverride] = [:]
|
||||
/// Tasks dropped into invalid columns produce a transient "denied"
|
||||
/// banner. Stored as an explicit error to support the Cmd-Z style
|
||||
/// undo we don't ship in v2.7.5 but want to leave room for.
|
||||
@@ -177,8 +190,10 @@ final class KanbanBoardViewModel {
|
||||
// Optimistic mutation — flip the local row's status to a
|
||||
// value within the destination column's range. We pick a
|
||||
// representative status per column.
|
||||
let optimisticStatus = optimisticStatus(for: destination)
|
||||
optimisticOverrides[taskId] = optimisticStatus
|
||||
let optimisticStatusValue = optimisticStatus(for: destination)
|
||||
var override = optimisticOverrides[taskId] ?? OptimisticOverride()
|
||||
override.status = optimisticStatusValue
|
||||
optimisticOverrides[taskId] = override
|
||||
|
||||
let svc = service
|
||||
Task {
|
||||
@@ -190,11 +205,11 @@ final class KanbanBoardViewModel {
|
||||
// without waiting for the 5s tick.
|
||||
await refresh()
|
||||
} catch let err as KanbanError {
|
||||
optimisticOverrides.removeValue(forKey: taskId)
|
||||
clearStatusOverride(for: taskId)
|
||||
lastError = err.errorDescription
|
||||
logger.warning("kanban move failed: \(err.errorDescription ?? "", privacy: .public)")
|
||||
} catch {
|
||||
optimisticOverrides.removeValue(forKey: taskId)
|
||||
clearStatusOverride(for: taskId)
|
||||
lastError = error.localizedDescription
|
||||
}
|
||||
}
|
||||
@@ -269,6 +284,48 @@ final class KanbanBoardViewModel {
|
||||
return task
|
||||
}
|
||||
|
||||
// MARK: - Hallucination gate (v0.13)
|
||||
|
||||
/// User confirmed the worker-created card is real. Optimistically
|
||||
/// flip the gate to `verified` so the banner disappears immediately;
|
||||
/// the polling loop confirms the new state on the next tick. On
|
||||
/// failure (e.g. the verb name is wrong on this v0.13.x build), the
|
||||
/// override is cleared and the error surfaces in `lastError`.
|
||||
func verifyHallucination(taskId: String) {
|
||||
var override = optimisticOverrides[taskId] ?? OptimisticOverride()
|
||||
override.hallucinationGate = .verified
|
||||
optimisticOverrides[taskId] = override
|
||||
Task {
|
||||
do {
|
||||
try await service.verify(taskId: taskId)
|
||||
await refresh()
|
||||
} catch let err as KanbanError {
|
||||
clearHallucinationOverride(for: taskId)
|
||||
lastError = err.errorDescription
|
||||
logger.warning("kanban verify failed: \(err.errorDescription ?? "", privacy: .public)")
|
||||
} catch {
|
||||
clearHallucinationOverride(for: taskId)
|
||||
lastError = error.localizedDescription
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// User rejected the worker-created card as a hallucinated reference.
|
||||
/// Routes through `comment` + `archive` per `KanbanService.rejectHallucinated`
|
||||
/// so there's an audit trail for why the card disappeared.
|
||||
func rejectHallucination(taskId: String) {
|
||||
Task {
|
||||
do {
|
||||
try await service.rejectHallucinated(taskId: taskId)
|
||||
await refresh()
|
||||
} catch let err as KanbanError {
|
||||
lastError = err.errorDescription
|
||||
} catch {
|
||||
lastError = error.localizedDescription
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Private helpers
|
||||
|
||||
private func mergePolledTasks(_ polled: [HermesKanbanTask]) {
|
||||
@@ -282,25 +339,75 @@ final class KanbanBoardViewModel {
|
||||
filtered = polled
|
||||
}
|
||||
let presentIds = Set(filtered.map(\.id))
|
||||
// Drop optimistic overrides for tasks Hermes confirmed.
|
||||
for (id, optimistic) in optimisticOverrides {
|
||||
if let row = filtered.first(where: { $0.id == id }) {
|
||||
if columnFromStatus(optimistic) == columnFromStatus(row.status) {
|
||||
// Drop optimistic overrides for tasks Hermes confirmed. Two
|
||||
// independent sides — clear them separately so a Verify click
|
||||
// still in-flight survives a status-side poll confirmation, and
|
||||
// vice versa.
|
||||
for (id, override) in optimisticOverrides {
|
||||
guard let row = filtered.first(where: { $0.id == id }) else {
|
||||
if !presentIds.contains(id) {
|
||||
// Task no longer in the polled set (archived, deleted,
|
||||
// or filtered out). Drop the override entirely.
|
||||
optimisticOverrides.removeValue(forKey: id)
|
||||
}
|
||||
} else if !presentIds.contains(id) {
|
||||
// Task no longer in the polled set (archived, deleted,
|
||||
// or filtered out). Drop the optimistic entry.
|
||||
continue
|
||||
}
|
||||
// Status side — optimistic move confirmed.
|
||||
if let optStatus = override.status,
|
||||
columnFromStatus(optStatus) == columnFromStatus(row.status) {
|
||||
optimisticOverrides[id]?.status = nil
|
||||
}
|
||||
// Hallucination-gate side — optimistic verify/reject confirmed.
|
||||
if let optGate = override.hallucinationGate,
|
||||
KanbanHallucinationGate.from(row.hallucinationGateStatus) == optGate {
|
||||
optimisticOverrides[id]?.hallucinationGate = nil
|
||||
}
|
||||
if optimisticOverrides[id]?.isEmpty ?? true {
|
||||
optimisticOverrides.removeValue(forKey: id)
|
||||
}
|
||||
}
|
||||
tasks = filtered
|
||||
}
|
||||
|
||||
/// Drop the status side of a task's override (preserving any
|
||||
/// in-flight hallucination-gate optimistic state).
|
||||
private func clearStatusOverride(for taskId: String) {
|
||||
guard var override = optimisticOverrides[taskId] else { return }
|
||||
override.status = nil
|
||||
if override.isEmpty {
|
||||
optimisticOverrides.removeValue(forKey: taskId)
|
||||
} else {
|
||||
optimisticOverrides[taskId] = override
|
||||
}
|
||||
}
|
||||
|
||||
/// Drop the hallucination-gate side of a task's override (preserving
|
||||
/// any in-flight status-side drag-drop).
|
||||
private func clearHallucinationOverride(for taskId: String) {
|
||||
guard var override = optimisticOverrides[taskId] else { return }
|
||||
override.hallucinationGate = nil
|
||||
if override.isEmpty {
|
||||
optimisticOverrides.removeValue(forKey: taskId)
|
||||
} else {
|
||||
optimisticOverrides[taskId] = override
|
||||
}
|
||||
}
|
||||
|
||||
/// Effective hallucination gate for a task — the optimistic override
|
||||
/// wins if one is in flight; otherwise the polled value. View code
|
||||
/// reads through this so the banner / dim state matches the moment-
|
||||
/// after-click experience.
|
||||
func effectiveHallucinationGate(_ task: HermesKanbanTask) -> KanbanHallucinationGate? {
|
||||
if let override = optimisticOverrides[task.id]?.hallucinationGate {
|
||||
return override
|
||||
}
|
||||
return KanbanHallucinationGate.from(task.hallucinationGateStatus)
|
||||
}
|
||||
|
||||
/// Return the effective board column for a task — the optimistic
|
||||
/// override wins if one is in flight; otherwise the polled status.
|
||||
private func effectiveColumn(_ task: HermesKanbanTask) -> KanbanBoardColumn {
|
||||
if let overrideStatus = optimisticOverrides[task.id] {
|
||||
if let overrideStatus = optimisticOverrides[task.id]?.status {
|
||||
return columnFromStatus(overrideStatus)
|
||||
}
|
||||
return columnFromStatus(task.status)
|
||||
|
||||
@@ -13,6 +13,7 @@ import ScarfDesign
|
||||
/// tenant.
|
||||
struct KanbanBoardView: View {
|
||||
@State private var viewModel: KanbanBoardViewModel
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
/// When non-nil, a project board hosts this view. Drives header
|
||||
/// chrome (subtitle, hidden tenant filter) and create-sheet
|
||||
@@ -33,6 +34,15 @@ struct KanbanBoardView: View {
|
||||
self.projectName = projectName
|
||||
}
|
||||
|
||||
/// Convenience read for the v0.13 diagnostics flag — gates the
|
||||
/// max_retries field, hallucination banner, diagnostics rendering,
|
||||
/// and the auto-blocked reason banner. Pre-v0.13 hosts get the
|
||||
/// v2.7.5 surface unchanged. Treats a missing store as "off" so
|
||||
/// harness contexts (Previews) don't accidentally surface gated UI.
|
||||
private var supportsKanbanDiagnostics: Bool {
|
||||
capabilitiesStore?.capabilities.hasKanbanDiagnostics ?? false
|
||||
}
|
||||
|
||||
@State private var inspectorTaskId: String?
|
||||
@State private var showingCreateSheet = false
|
||||
@State private var blockSheetTaskId: String?
|
||||
@@ -71,7 +81,8 @@ struct KanbanBoardView: View {
|
||||
KanbanCreateSheet(
|
||||
assignees: viewModel.assignees,
|
||||
tenantPrefill: viewModel.tenantFilter,
|
||||
projectWorkspacePath: viewModel.projectPath
|
||||
projectWorkspacePath: viewModel.projectPath,
|
||||
supportsKanbanDiagnostics: supportsKanbanDiagnostics
|
||||
) { request in
|
||||
_ = try await viewModel.createTask(request)
|
||||
}
|
||||
@@ -188,7 +199,9 @@ struct KanbanBoardView: View {
|
||||
onDrop: { ref in
|
||||
handleDrop(ref.id, on: column)
|
||||
},
|
||||
canCreate: column == .upNext || column == .triage
|
||||
canCreate: column == .upNext || column == .triage,
|
||||
supportsKanbanDiagnostics: supportsKanbanDiagnostics,
|
||||
effectiveHallucinationGate: { viewModel.effectiveHallucinationGate($0) }
|
||||
)
|
||||
}
|
||||
Spacer(minLength: ScarfSpace.s4)
|
||||
@@ -208,6 +221,8 @@ struct KanbanBoardView: View {
|
||||
service: viewModel.service,
|
||||
taskId: taskId,
|
||||
availableAssignees: viewModel.assignees,
|
||||
supportsKanbanDiagnostics: supportsKanbanDiagnostics,
|
||||
effectiveHallucinationGate: { viewModel.effectiveHallucinationGate($0) },
|
||||
onClose: { inspectorTaskId = nil },
|
||||
onClaim: {
|
||||
viewModel.attemptMove(taskId: taskId, to: .running)
|
||||
@@ -232,6 +247,15 @@ struct KanbanBoardView: View {
|
||||
},
|
||||
onReassign: { profile in
|
||||
viewModel.reassignTask(taskId: taskId, to: profile)
|
||||
},
|
||||
onVerifyHallucination: {
|
||||
viewModel.verifyHallucination(taskId: taskId)
|
||||
},
|
||||
onRejectHallucination: {
|
||||
viewModel.rejectHallucination(taskId: taskId)
|
||||
// Card vanishes from active board after archive — close
|
||||
// the inspector so it doesn't dangle on a deleted task.
|
||||
inspectorTaskId = nil
|
||||
}
|
||||
)
|
||||
}
|
||||
|
||||
@@ -24,12 +24,40 @@ struct KanbanTaskRef: Transferable {
|
||||
/// - **Running** gets a blue left-edge accent + live shimmer
|
||||
/// - **Blocked** gets a warning left-edge accent + ⚠ glyph
|
||||
/// - **Done** dims to 0.7 opacity (0.55 in dark mode)
|
||||
/// - **Hallucination-gate pending** (v0.13+) dims to 0.6 + ⚠ glyph and
|
||||
/// shows a one-line auto-blocked reason in the footer when present.
|
||||
struct KanbanCardView: View {
|
||||
let task: HermesKanbanTask
|
||||
let onTap: () -> Void
|
||||
/// True when the connected Hermes is on v0.13+ — gates the
|
||||
/// hallucination dim/glyph, auto-block sub-line, and diagnostics
|
||||
/// dot on the card. Pre-v0.13 hosts see the v2.7.5 chrome unchanged.
|
||||
let supportsKanbanDiagnostics: Bool
|
||||
/// Optimistic-aware accessor. Pre-v0.13 always nil. Otherwise delegates
|
||||
/// to the board VM so a Verify click un-dims the card immediately.
|
||||
let effectiveHallucinationGate: (HermesKanbanTask) -> KanbanHallucinationGate?
|
||||
|
||||
init(
|
||||
task: HermesKanbanTask,
|
||||
supportsKanbanDiagnostics: Bool = false,
|
||||
effectiveHallucinationGate: @escaping (HermesKanbanTask) -> KanbanHallucinationGate? = { _ in nil },
|
||||
onTap: @escaping () -> Void
|
||||
) {
|
||||
self.task = task
|
||||
self.supportsKanbanDiagnostics = supportsKanbanDiagnostics
|
||||
self.effectiveHallucinationGate = effectiveHallucinationGate
|
||||
self.onTap = onTap
|
||||
}
|
||||
|
||||
@Environment(\.colorScheme) private var colorScheme
|
||||
|
||||
/// Cached gate read — derived once per body eval rather than recomputed
|
||||
/// in each subview helper.
|
||||
private var hallucinationGate: KanbanHallucinationGate? {
|
||||
guard supportsKanbanDiagnostics else { return nil }
|
||||
return effectiveHallucinationGate(task)
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
Button(action: onTap) {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
@@ -66,13 +94,22 @@ struct KanbanCardView: View {
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.scarfShadow(.sm)
|
||||
.opacity(task.isDone ? doneOpacity : 1.0)
|
||||
// v0.13: hallucination-pending cards dim to 0.6 to signal "needs
|
||||
// verification before running" without making them unreadable.
|
||||
// Done cards stay at the established doneOpacity (0.7 / 0.55).
|
||||
.opacity(cardOpacity)
|
||||
.draggable(KanbanTaskRef(id: task.id)) {
|
||||
// Drag preview — the live card with a heavier shadow.
|
||||
self.dragPreview
|
||||
}
|
||||
}
|
||||
|
||||
private var cardOpacity: Double {
|
||||
if task.isDone { return doneOpacity }
|
||||
if hallucinationGate == .pending { return 0.6 }
|
||||
return 1.0
|
||||
}
|
||||
|
||||
private var titleRow: some View {
|
||||
HStack(alignment: .top, spacing: ScarfSpace.s2) {
|
||||
statusGlyph
|
||||
@@ -82,7 +119,15 @@ struct KanbanCardView: View {
|
||||
.lineLimit(2)
|
||||
.multilineTextAlignment(.leading)
|
||||
Spacer(minLength: 0)
|
||||
if needsAssignmentWarning {
|
||||
// v0.13 hallucination glyph takes precedence over the
|
||||
// unassigned glyph — the hallucination state is the more
|
||||
// specific signal (a worker created this card; verify it).
|
||||
if hallucinationGate == .pending {
|
||||
Image(systemName: "questionmark.diamond.fill")
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
.font(.system(size: 11, weight: .semibold))
|
||||
.help("Worker-created — verify before running")
|
||||
} else if needsAssignmentWarning {
|
||||
Image(systemName: "exclamationmark.triangle.fill")
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
.font(.system(size: 11, weight: .semibold))
|
||||
@@ -186,13 +231,37 @@ struct KanbanCardView: View {
|
||||
}
|
||||
|
||||
private var footerRow: some View {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
Text(relativeTimeLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
Spacer(minLength: 0)
|
||||
if let priority = task.priority, priority >= 70 {
|
||||
priorityIndicator(priority)
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
// v0.13: server-supplied auto-blocked reason. Renders verbatim
|
||||
// (truncated to one line; full reason in the inspector).
|
||||
// Pre-v0.13 hosts always have task.autoBlockedReason == nil.
|
||||
if supportsKanbanDiagnostics,
|
||||
KanbanStatus.from(task.status) == .blocked,
|
||||
let reason = task.autoBlockedReason, !reason.isEmpty {
|
||||
Text(reason)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.danger)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.tail)
|
||||
.help(reason)
|
||||
}
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
Text(relativeTimeLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
Spacer(minLength: 0)
|
||||
// v0.13: diagnostics dot — small stethoscope glyph when
|
||||
// any cross-run distress signal is attached. Matches the
|
||||
// chip count in the inspector.
|
||||
if supportsKanbanDiagnostics, !task.diagnostics.isEmpty {
|
||||
Image(systemName: "stethoscope")
|
||||
.font(.system(size: 9))
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
.help("\(task.diagnostics.count) diagnostic signal\(task.diagnostics.count == 1 ? "" : "s")")
|
||||
}
|
||||
if let priority = task.priority, priority >= 70 {
|
||||
priorityIndicator(priority)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -17,6 +17,38 @@ struct KanbanColumnView: View {
|
||||
let onCreate: () -> Void
|
||||
let onDrop: (KanbanTaskRef) -> Void
|
||||
let canCreate: Bool
|
||||
/// True when the connected Hermes is on v0.13+. Forwarded to each
|
||||
/// `KanbanCardView` so the hallucination dim/glyph + diagnostics dot
|
||||
/// + auto-block sub-line gate uniformly.
|
||||
let supportsKanbanDiagnostics: Bool
|
||||
/// Optimistic-aware accessor forwarded to cards. Default is
|
||||
/// "no override" so Previews and harness contexts still render
|
||||
/// without wiring up a board VM.
|
||||
let effectiveHallucinationGate: (HermesKanbanTask) -> KanbanHallucinationGate?
|
||||
|
||||
init(
|
||||
column: KanbanBoardColumn,
|
||||
tasks: [HermesKanbanTask],
|
||||
isLive: Bool,
|
||||
readyPillCount: Int,
|
||||
onTaskTap: @escaping (HermesKanbanTask) -> Void,
|
||||
onCreate: @escaping () -> Void,
|
||||
onDrop: @escaping (KanbanTaskRef) -> Void,
|
||||
canCreate: Bool,
|
||||
supportsKanbanDiagnostics: Bool = false,
|
||||
effectiveHallucinationGate: @escaping (HermesKanbanTask) -> KanbanHallucinationGate? = { _ in nil }
|
||||
) {
|
||||
self.column = column
|
||||
self.tasks = tasks
|
||||
self.isLive = isLive
|
||||
self.readyPillCount = readyPillCount
|
||||
self.onTaskTap = onTaskTap
|
||||
self.onCreate = onCreate
|
||||
self.onDrop = onDrop
|
||||
self.canCreate = canCreate
|
||||
self.supportsKanbanDiagnostics = supportsKanbanDiagnostics
|
||||
self.effectiveHallucinationGate = effectiveHallucinationGate
|
||||
}
|
||||
|
||||
@State private var isTargeted = false
|
||||
|
||||
@@ -36,7 +68,11 @@ struct KanbanColumnView: View {
|
||||
.padding(.top, ScarfSpace.s4)
|
||||
} else {
|
||||
ForEach(tasks) { task in
|
||||
KanbanCardView(task: task) {
|
||||
KanbanCardView(
|
||||
task: task,
|
||||
supportsKanbanDiagnostics: supportsKanbanDiagnostics,
|
||||
effectiveHallucinationGate: effectiveHallucinationGate
|
||||
) {
|
||||
onTaskTap(task)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -14,6 +14,12 @@ struct KanbanCreateSheet: View {
|
||||
/// Pre-filled project workspace path on per-project boards. When
|
||||
/// non-nil, the workspace picker is locked to "Project Dir".
|
||||
let projectWorkspacePath: String?
|
||||
/// True when the connected Hermes is on v0.13+ — gates the
|
||||
/// `--max-retries` field and decides whether to strip newlines from
|
||||
/// the title at submit time. Pre-v0.13 hosts may truncate at the
|
||||
/// first `\n`; we keep the multi-line input rendering on either way
|
||||
/// since a taller `TextField` is harmless on v0.12.
|
||||
let supportsKanbanDiagnostics: Bool
|
||||
/// Closure invoked when the user submits — VM owner constructs the
|
||||
/// `KanbanService.create` call.
|
||||
let onSubmit: (KanbanCreateRequest) async throws -> Void
|
||||
@@ -33,6 +39,11 @@ struct KanbanCreateSheet: View {
|
||||
@State private var skillsInput: String = ""
|
||||
@State private var tenant: String = ""
|
||||
@State private var sendToTriage: Bool = false
|
||||
/// v0.13: per-task retry budget. Toggle-gated so the user can opt
|
||||
/// into "send the flag" vs. "let Hermes pick its default" (the
|
||||
/// release notes default to 3 — see TODO in KanbanCreateRequest).
|
||||
@State private var maxRetriesEnabled: Bool = false
|
||||
@State private var maxRetries: Int = 3
|
||||
@State private var isSubmitting: Bool = false
|
||||
@State private var submitError: String?
|
||||
@FocusState private var titleFocused: Bool
|
||||
@@ -62,6 +73,9 @@ struct KanbanCreateSheet: View {
|
||||
assigneePicker
|
||||
workspaceField
|
||||
priorityField
|
||||
if supportsKanbanDiagnostics {
|
||||
maxRetriesField
|
||||
}
|
||||
skillsField
|
||||
if projectWorkspacePath == nil {
|
||||
tenantField
|
||||
@@ -114,10 +128,60 @@ struct KanbanCreateSheet: View {
|
||||
// MARK: - Fields
|
||||
|
||||
private var titleField: some View {
|
||||
// v0.13 server tolerates multi-line titles. We keep the
|
||||
// multi-line input rendering on for ALL versions of Hermes —
|
||||
// visually a taller TextField is harmless on v0.12 — and decide
|
||||
// at submit time whether to strip newlines (see `makeRequest`).
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
ScarfSectionHeader("Title")
|
||||
ScarfTextField("What needs doing?", text: $title)
|
||||
.focused($titleFocused)
|
||||
TextField(
|
||||
"What needs doing?",
|
||||
text: $title,
|
||||
axis: .vertical
|
||||
)
|
||||
.lineLimit(1...4)
|
||||
.textFieldStyle(.plain)
|
||||
.scarfStyle(.body)
|
||||
.padding(.horizontal, ScarfSpace.s3)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
.background(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.fill(ScarfColor.backgroundSecondary)
|
||||
)
|
||||
.overlay(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.strokeBorder(ScarfColor.borderStrong, lineWidth: 1)
|
||||
)
|
||||
.focused($titleFocused)
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13: per-task retry budget. Toggle gates whether `--max-retries`
|
||||
/// is sent at all so the user can preserve "let Hermes pick the
|
||||
/// default" semantics by leaving the toggle off.
|
||||
private var maxRetriesField: some View {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
ScarfSectionHeader(
|
||||
"Max retries",
|
||||
subtitle: "0 = no retries. Defaults to 3."
|
||||
)
|
||||
HStack(spacing: ScarfSpace.s3) {
|
||||
Toggle("Override default", isOn: $maxRetriesEnabled)
|
||||
.toggleStyle(.switch)
|
||||
.labelsHidden()
|
||||
Stepper(value: $maxRetries, in: 0...20) {
|
||||
Text("\(maxRetries)")
|
||||
.scarfStyle(.bodyEmph)
|
||||
.frame(minWidth: 24, alignment: .trailing)
|
||||
.foregroundStyle(
|
||||
maxRetriesEnabled
|
||||
? ScarfColor.foregroundPrimary
|
||||
: ScarfColor.foregroundFaint
|
||||
)
|
||||
}
|
||||
.disabled(!maxRetriesEnabled)
|
||||
Spacer()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -307,7 +371,14 @@ struct KanbanCreateSheet: View {
|
||||
}
|
||||
|
||||
private func makeRequest() -> KanbanCreateRequest {
|
||||
let trimmedTitle = title.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
var trimmedTitle = title.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
// Pre-v0.13 hosts may truncate titles at the first `\n`. Strip
|
||||
// newlines client-side when we know the connected Hermes hasn't
|
||||
// shipped multi-line title support — replace with a space to
|
||||
// keep the user's intent visible. v0.13+ keeps newlines verbatim.
|
||||
if !supportsKanbanDiagnostics {
|
||||
trimmedTitle = trimmedTitle.replacingOccurrences(of: "\n", with: " ")
|
||||
}
|
||||
let trimmedBody = bodyText.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
let trimmedAssignee = assignee.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
let trimmedTenant = tenant.trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
@@ -330,6 +401,14 @@ struct KanbanCreateSheet: View {
|
||||
}
|
||||
}
|
||||
|
||||
// Belt-and-suspenders: the `maxRetriesField` is only rendered
|
||||
// when `supportsKanbanDiagnostics` is true, but gate again here
|
||||
// so a programmatic state change can't smuggle the flag onto a
|
||||
// pre-v0.13 host (where the verb would error).
|
||||
let resolvedMaxRetries: Int? = (supportsKanbanDiagnostics && maxRetriesEnabled)
|
||||
? maxRetries
|
||||
: nil
|
||||
|
||||
return KanbanCreateRequest(
|
||||
title: trimmedTitle,
|
||||
body: trimmedBody.isEmpty ? nil : trimmedBody,
|
||||
@@ -342,7 +421,8 @@ struct KanbanCreateSheet: View {
|
||||
idempotencyKey: nil,
|
||||
maxRuntimeSeconds: nil,
|
||||
createdBy: nil,
|
||||
skills: parsedSkills
|
||||
skills: parsedSkills,
|
||||
maxRetries: resolvedMaxRetries
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -8,6 +8,16 @@ import ScarfDesign
|
||||
struct KanbanInspectorPane: View {
|
||||
@State private var viewModel: KanbanTaskDetailViewModel
|
||||
let availableAssignees: [HermesKanbanAssignee]
|
||||
/// True when the connected Hermes is on v0.13+ — gates the
|
||||
/// hallucination banner, max_retries chip, diagnostics block,
|
||||
/// and auto-blocked reason banner. Pre-v0.13 hosts see the v2.7.5
|
||||
/// inspector unchanged.
|
||||
let supportsKanbanDiagnostics: Bool
|
||||
/// Resolves an effective hallucination gate — the board VM owns the
|
||||
/// optimistic-override merge so the banner disappears immediately on
|
||||
/// Verify before the polled state confirms the new gate. Falls back
|
||||
/// to the wire-level value when no override is in flight.
|
||||
let effectiveHallucinationGate: (HermesKanbanTask) -> KanbanHallucinationGate?
|
||||
let onClose: () -> Void
|
||||
let onClaim: () -> Void
|
||||
let onComplete: () -> Void
|
||||
@@ -15,6 +25,8 @@ struct KanbanInspectorPane: View {
|
||||
let onUnblock: () -> Void
|
||||
let onArchive: () -> Void
|
||||
let onReassign: (String?) -> Void
|
||||
let onVerifyHallucination: () -> Void
|
||||
let onRejectHallucination: () -> Void
|
||||
|
||||
@State private var selectedTab: DetailTab = .comments
|
||||
|
||||
@@ -30,16 +42,22 @@ struct KanbanInspectorPane: View {
|
||||
service: KanbanService,
|
||||
taskId: String,
|
||||
availableAssignees: [HermesKanbanAssignee] = [],
|
||||
supportsKanbanDiagnostics: Bool = false,
|
||||
effectiveHallucinationGate: @escaping (HermesKanbanTask) -> KanbanHallucinationGate? = { _ in nil },
|
||||
onClose: @escaping () -> Void,
|
||||
onClaim: @escaping () -> Void,
|
||||
onComplete: @escaping () -> Void,
|
||||
onBlock: @escaping () -> Void,
|
||||
onUnblock: @escaping () -> Void,
|
||||
onArchive: @escaping () -> Void,
|
||||
onReassign: @escaping (String?) -> Void = { _ in }
|
||||
onReassign: @escaping (String?) -> Void = { _ in },
|
||||
onVerifyHallucination: @escaping () -> Void = {},
|
||||
onRejectHallucination: @escaping () -> Void = {}
|
||||
) {
|
||||
_viewModel = State(initialValue: KanbanTaskDetailViewModel(service: service, taskId: taskId))
|
||||
self.availableAssignees = availableAssignees
|
||||
self.supportsKanbanDiagnostics = supportsKanbanDiagnostics
|
||||
self.effectiveHallucinationGate = effectiveHallucinationGate
|
||||
self.onClose = onClose
|
||||
self.onClaim = onClaim
|
||||
self.onComplete = onComplete
|
||||
@@ -47,6 +65,8 @@ struct KanbanInspectorPane: View {
|
||||
self.onUnblock = onUnblock
|
||||
self.onArchive = onArchive
|
||||
self.onReassign = onReassign
|
||||
self.onVerifyHallucination = onVerifyHallucination
|
||||
self.onRejectHallucination = onRejectHallucination
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
@@ -159,6 +179,16 @@ struct KanbanInspectorPane: View {
|
||||
ScarfBadge(workspace, kind: .neutral)
|
||||
.fixedSize()
|
||||
}
|
||||
// v0.13: max_retries chip. Read-only — Hermes
|
||||
// has no `update --max-retries` verb. The
|
||||
// `if let` guards pre-v0.13 hosts (always nil)
|
||||
// and the explicit capability gate adds
|
||||
// belt-and-suspenders.
|
||||
if supportsKanbanDiagnostics, let maxRetries = task.maxRetries {
|
||||
ScarfBadge("retries: \(maxRetries)", kind: .neutral)
|
||||
.fixedSize()
|
||||
.help("Max retries set at create time. Hermes has no update verb — re-create the task to change this.")
|
||||
}
|
||||
if let tenant = task.tenant, !tenant.isEmpty {
|
||||
ScarfBadge(tenant, kind: .brand)
|
||||
.fixedSize()
|
||||
@@ -251,13 +281,18 @@ struct KanbanInspectorPane: View {
|
||||
// MARK: - Body
|
||||
|
||||
/// Inline health banner shown above the task body when something
|
||||
/// requires user attention. Two conditions trigger today:
|
||||
/// 1. Task is in `ready`/`todo` with no assignee — explains that
|
||||
/// the dispatcher silently skips unassigned tasks.
|
||||
/// 2. The most recent run ended in a non-success outcome
|
||||
/// (`stale_lock`/`crashed`/`gave_up`/`timed_out`/`spawn_failed`/
|
||||
/// `reclaimed`/`failed`) — surfaces the error so the user
|
||||
/// doesn't have to dig into the Runs tab to discover it.
|
||||
/// requires user attention. Stack vertically (multiple can apply at
|
||||
/// once on a v0.13 task — e.g. unassigned + hallucination pending +
|
||||
/// last-run-blocked).
|
||||
/// Order top-to-bottom:
|
||||
/// 1. **Hallucination gate (v0.13+)** — pending worker-created card.
|
||||
/// User must verify or reject before any other action makes sense.
|
||||
/// 2. **Auto-blocked reason (v0.13+)** — server-supplied reason
|
||||
/// overrides the generic "Last run: blocked" banner.
|
||||
/// 3. Task is in `ready`/`todo` with no assignee — explains that the
|
||||
/// dispatcher silently skips unassigned tasks.
|
||||
/// 4. The most recent run ended in a non-success outcome — surfaces
|
||||
/// the error so the user doesn't have to dig into the Runs tab.
|
||||
@ViewBuilder
|
||||
private func healthBanner(for task: HermesKanbanTask) -> some View {
|
||||
let status = KanbanStatus.from(task.status)
|
||||
@@ -292,25 +327,137 @@ struct KanbanInspectorPane: View {
|
||||
// Also suppress for `done` (terminal success).
|
||||
let suppressFailureBanner = (status == .running) || (status == .done)
|
||||
|
||||
if needsAssignee {
|
||||
bannerRow(
|
||||
icon: "exclamationmark.triangle.fill",
|
||||
tint: ScarfColor.warning,
|
||||
title: "Won't run automatically",
|
||||
message: "Unassigned tasks are silently skipped by Hermes's dispatcher. Add an assignee to get this scheduled."
|
||||
)
|
||||
} else if hadFailedEndedRun, let lastEndedRun, !suppressFailureBanner {
|
||||
let label = (lastEndedRun.outcome ?? lastEndedRun.status).lowercased()
|
||||
let detail = lastEndedRun.error ?? lastEndedRun.summary ?? "no details"
|
||||
bannerRow(
|
||||
icon: "exclamationmark.octagon.fill",
|
||||
tint: ScarfColor.danger,
|
||||
title: "Last run: \(label)",
|
||||
message: detail
|
||||
)
|
||||
// v0.13: hallucination-gate state. Read through the VM's
|
||||
// optimistic-aware accessor so a Verify click takes effect
|
||||
// before the polled state confirms. Belt-and-suspenders gate
|
||||
// on capability flag.
|
||||
let hallucination: KanbanHallucinationGate? = supportsKanbanDiagnostics
|
||||
? effectiveHallucinationGate(task)
|
||||
: nil
|
||||
// v0.13: structured auto-blocked reason. Renders the server's
|
||||
// string verbatim; takes precedence over the generic "Last run:
|
||||
// blocked" banner.
|
||||
let autoBlockedReason: String? = (supportsKanbanDiagnostics
|
||||
&& status == .blocked
|
||||
&& (task.autoBlockedReason?.isEmpty == false))
|
||||
? task.autoBlockedReason
|
||||
: nil
|
||||
// Suppress the generic last-run banner when the more specific
|
||||
// server-side reason supersedes it.
|
||||
let suppressGenericFailure = autoBlockedReason != nil
|
||||
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
if hallucination == .pending {
|
||||
hallucinationBanner
|
||||
}
|
||||
if let reason = autoBlockedReason {
|
||||
bannerRow(
|
||||
icon: "exclamationmark.octagon.fill",
|
||||
tint: ScarfColor.danger,
|
||||
title: "Auto-blocked",
|
||||
// Verbatim — Hermes-side message is the source of truth.
|
||||
message: reason
|
||||
)
|
||||
}
|
||||
if needsAssignee {
|
||||
bannerRow(
|
||||
icon: "exclamationmark.triangle.fill",
|
||||
tint: ScarfColor.warning,
|
||||
title: "Won't run automatically",
|
||||
message: "Unassigned tasks are silently skipped by Hermes's dispatcher. Add an assignee to get this scheduled."
|
||||
)
|
||||
}
|
||||
if hadFailedEndedRun, let lastEndedRun,
|
||||
!suppressFailureBanner, !suppressGenericFailure {
|
||||
let label = (lastEndedRun.outcome ?? lastEndedRun.status).lowercased()
|
||||
let detail = lastEndedRun.error ?? lastEndedRun.summary ?? "no details"
|
||||
bannerRow(
|
||||
icon: "exclamationmark.octagon.fill",
|
||||
tint: ScarfColor.danger,
|
||||
title: "Last run: \(label)",
|
||||
message: detail
|
||||
)
|
||||
}
|
||||
// v0.13: cross-run diagnostics on the task header.
|
||||
if supportsKanbanDiagnostics, !task.diagnostics.isEmpty {
|
||||
diagnosticsBlock(task.diagnostics)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13 hallucination-gate banner — Verify / Reject affordances for
|
||||
/// worker-created cards waiting on user verification.
|
||||
private var hallucinationBanner: some View {
|
||||
HStack(alignment: .top, spacing: ScarfSpace.s2) {
|
||||
Image(systemName: "questionmark.diamond.fill")
|
||||
.foregroundStyle(ScarfColor.warning)
|
||||
.font(.system(size: 13, weight: .semibold))
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("Created by a worker — verify before running")
|
||||
.scarfStyle(.captionStrong)
|
||||
.foregroundStyle(ScarfColor.foregroundPrimary)
|
||||
Text("A worker claimed it created this card; Hermes hasn't confirmed the underlying work exists. Verify the card matches a real follow-up, or reject if it's a hallucinated reference.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
Button("Verify", action: onVerifyHallucination)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
Button("Reject", action: onRejectHallucination)
|
||||
.buttonStyle(ScarfDestructiveButton())
|
||||
}
|
||||
.padding(.top, 2)
|
||||
}
|
||||
Spacer(minLength: 0)
|
||||
}
|
||||
.padding(ScarfSpace.s2)
|
||||
.background(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.fill(ScarfColor.warning.opacity(0.10))
|
||||
)
|
||||
.overlay(
|
||||
RoundedRectangle(cornerRadius: ScarfRadius.md, style: .continuous)
|
||||
.strokeBorder(ScarfColor.warning.opacity(0.4), lineWidth: 1)
|
||||
)
|
||||
}
|
||||
|
||||
/// v0.13 diagnostics block — renders a list of distress signals.
|
||||
/// Used both at the task-header level (cross-run signals) and per
|
||||
/// run on the Runs tab (in-flight signals). Wraps in a horizontal
|
||||
/// scroll so a long diag list doesn't blow out inspector width.
|
||||
private func diagnosticsBlock(_ diags: [HermesKanbanDiagnostic]) -> some View {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("Diagnostics")
|
||||
.scarfStyle(.captionUppercase)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
ScrollView(.horizontal, showsIndicators: false) {
|
||||
HStack(spacing: 4) {
|
||||
ForEach(diags) { diag in
|
||||
diagnosticBadge(diag)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
.padding(.top, 4)
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private func diagnosticBadge(_ diag: HermesKanbanDiagnostic) -> some View {
|
||||
let kind = KanbanDiagnosticKind.from(diag.kind)
|
||||
let badgeKind: ScarfBadgeKind = {
|
||||
switch kind.severity {
|
||||
case .danger: return .danger
|
||||
case .warning: return .warning
|
||||
case .neutral: return .neutral
|
||||
}
|
||||
}()
|
||||
// Render the raw kind string — view code stays in sync with
|
||||
// whatever future kinds Hermes ships. The typed mirror picks
|
||||
// the badge tint and tooltip glyph; the verbatim wire string
|
||||
// is the user-facing label.
|
||||
ScarfBadge(diag.kind, kind: badgeKind)
|
||||
.help(diag.message ?? diag.kind)
|
||||
}
|
||||
|
||||
private func bannerRow(
|
||||
icon: String,
|
||||
tint: Color,
|
||||
@@ -562,6 +709,9 @@ struct KanbanInspectorPane: View {
|
||||
private func runRow(_ run: HermesKanbanRun) -> some View {
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
// Render the wire-side outcome / status string verbatim so
|
||||
// v0.13's richer outcome strings ("zombied — reclaimed by
|
||||
// reaper", etc.) surface unchanged.
|
||||
ScarfBadge(run.outcome ?? run.status, kind: outcomeKind(run.outcome ?? run.status))
|
||||
if let profile = run.profile {
|
||||
Text(profile)
|
||||
@@ -585,6 +735,12 @@ struct KanbanInspectorPane: View {
|
||||
.foregroundStyle(ScarfColor.danger)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
}
|
||||
// v0.13: per-run diagnostics. Gated on capability so a future
|
||||
// server-side change can't accidentally surface partial UX
|
||||
// on a pre-v0.13 host.
|
||||
if supportsKanbanDiagnostics, !run.diagnostics.isEmpty {
|
||||
diagnosticsBlock(run.diagnostics)
|
||||
}
|
||||
}
|
||||
.padding(ScarfSpace.s2)
|
||||
.background(
|
||||
@@ -619,23 +775,32 @@ struct KanbanInspectorPane: View {
|
||||
@ViewBuilder
|
||||
private var primaryAction: some View {
|
||||
if let task = viewModel.detail?.task {
|
||||
switch KanbanStatus.from(task.status) {
|
||||
case .ready, .todo:
|
||||
Button("Start", action: onClaim)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.help("Atomically claim this task and start the worker. Moves it to Running.")
|
||||
case .running:
|
||||
Button("Complete", action: onComplete)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.help("Mark this task as Done. You'll be prompted for an optional result summary.")
|
||||
case .blocked:
|
||||
Button("Unblock", action: onUnblock)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.help("Return this task to the Up Next queue so the dispatcher can pick it up again.")
|
||||
case .triage:
|
||||
EmptyView()
|
||||
default:
|
||||
// v0.13: when the hallucination gate is pending, suppress the
|
||||
// primary action — the banner provides Verify / Reject as the
|
||||
// gate. Showing "Start" alongside the banner would let the
|
||||
// user dispatch a card Hermes hasn't confirmed exists.
|
||||
if supportsKanbanDiagnostics,
|
||||
effectiveHallucinationGate(task) == .pending {
|
||||
EmptyView()
|
||||
} else {
|
||||
switch KanbanStatus.from(task.status) {
|
||||
case .ready, .todo:
|
||||
Button("Start", action: onClaim)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.help("Atomically claim this task and start the worker. Moves it to Running.")
|
||||
case .running:
|
||||
Button("Complete", action: onComplete)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.help("Mark this task as Done. You'll be prompted for an optional result summary.")
|
||||
case .blocked:
|
||||
Button("Unblock", action: onUnblock)
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.help("Return this task to the Up Next queue so the dispatcher can pick it up again.")
|
||||
case .triage:
|
||||
EmptyView()
|
||||
default:
|
||||
EmptyView()
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -21,6 +21,9 @@ final class MCPServerEditorViewModel {
|
||||
var promptsEnabled: Bool
|
||||
var timeoutDraft: String
|
||||
var connectTimeoutDraft: String
|
||||
/// SSE-only — renders as a third numeric on `.sse` servers. Empty string
|
||||
/// means "use Hermes default" (writer drops the scalar).
|
||||
var sseReadTimeoutDraft: String
|
||||
var showSecrets: Bool = false
|
||||
var isSaving: Bool = false
|
||||
var saveError: String?
|
||||
@@ -37,6 +40,7 @@ final class MCPServerEditorViewModel {
|
||||
self.promptsEnabled = server.promptsEnabled
|
||||
self.timeoutDraft = server.timeout.map { String($0) } ?? ""
|
||||
self.connectTimeoutDraft = server.connectTimeout.map { String($0) } ?? ""
|
||||
self.sseReadTimeoutDraft = server.sseReadTimeout.map { String($0) } ?? ""
|
||||
}
|
||||
|
||||
func appendEnvRow() {
|
||||
@@ -69,6 +73,8 @@ final class MCPServerEditorViewModel {
|
||||
let exclude = excludeDraft.split(separator: ",").map { $0.trimmingCharacters(in: .whitespaces) }.filter { !$0.isEmpty }
|
||||
let timeoutValue = Int(timeoutDraft.trimmingCharacters(in: .whitespaces))
|
||||
let connectValue = Int(connectTimeoutDraft.trimmingCharacters(in: .whitespaces))
|
||||
let trimmedSSE = sseReadTimeoutDraft.trimmingCharacters(in: .whitespaces)
|
||||
let sseTimeoutValue: Int? = trimmedSSE.isEmpty ? nil : Int(trimmedSSE)
|
||||
|
||||
let service = fileService
|
||||
let transport = server.transport
|
||||
@@ -87,6 +93,11 @@ final class MCPServerEditorViewModel {
|
||||
if !service.setMCPServerEnv(name: name, env: envMap) { ok = false }
|
||||
case .http:
|
||||
if !service.setMCPServerHeaders(name: name, headers: headerMap) { ok = false }
|
||||
case .sse:
|
||||
// SSE servers carry headers like .http does, plus an
|
||||
// optional sse_read_timeout written below.
|
||||
if !service.setMCPServerHeaders(name: name, headers: headerMap) { ok = false }
|
||||
if !service.setMCPServerSSETimeout(name: name, sseReadTimeout: sseTimeoutValue) { ok = false }
|
||||
}
|
||||
if !service.updateMCPToolFilters(
|
||||
name: name,
|
||||
|
||||
@@ -42,6 +42,10 @@ final class MCPServersViewModel {
|
||||
filteredServers.filter { $0.transport == .http }
|
||||
}
|
||||
|
||||
var sseServers: [HermesMCPServer] {
|
||||
filteredServers.filter { $0.transport == .sse }
|
||||
}
|
||||
|
||||
var selectedServer: HermesMCPServer? {
|
||||
guard let name = selectedServerName else { return nil }
|
||||
return servers.first(where: { $0.name == name })
|
||||
@@ -167,6 +171,11 @@ final class MCPServersViewModel {
|
||||
url: preset.url ?? "",
|
||||
auth: preset.auth
|
||||
)
|
||||
case .sse:
|
||||
// No SSE-transport presets ship today; the preset picker
|
||||
// only surfaces stdio/http servers. Treat as a no-op
|
||||
// failure if a preset somehow declares .sse.
|
||||
addResult = (exitCode: 1, output: "SSE-transport presets are not supported.")
|
||||
}
|
||||
guard addResult.exitCode == 0 else {
|
||||
await MainActor.run {
|
||||
@@ -196,6 +205,11 @@ final class MCPServersViewModel {
|
||||
result = fileService.addMCPServerStdio(name: name, command: command, args: args)
|
||||
case .http:
|
||||
result = fileService.addMCPServerHTTP(name: name, url: url, auth: auth)
|
||||
case .sse:
|
||||
// Routed through addCustomSSE; this branch is unreachable from
|
||||
// the add-server form (which dispatches per-transport in submit())
|
||||
// but kept so the switch is exhaustive without `@unknown default`.
|
||||
result = (exitCode: 1, output: "SSE servers must be added via addCustomSSE.")
|
||||
}
|
||||
await MainActor.run {
|
||||
if result.exitCode == 0 {
|
||||
@@ -211,6 +225,28 @@ final class MCPServersViewModel {
|
||||
}
|
||||
}
|
||||
|
||||
/// v0.13+ SSE-transport server creation. Caller is responsible for
|
||||
/// capability-gating; the form filters `.sse` out of `availableTransports`
|
||||
/// when `hasMCPSSETransport` is false, so this method is unreachable
|
||||
/// from the UI on pre-v0.13 hosts.
|
||||
func addCustomSSE(name: String, url: String, sseReadTimeout: Int?) {
|
||||
let fileService = self.fileService
|
||||
Task.detached {
|
||||
let result = fileService.addMCPServerSSE(name: name, url: url, sseReadTimeout: sseReadTimeout)
|
||||
await MainActor.run {
|
||||
if result.exitCode == 0 {
|
||||
self.flashStatus("Added \(name)")
|
||||
self.load()
|
||||
self.selectedServerName = name
|
||||
self.showRestartBanner = true
|
||||
self.showAddCustom = false
|
||||
} else {
|
||||
self.activeError = "Add failed: \(result.output)"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func restartGateway() {
|
||||
let fileService = self.fileService
|
||||
Task.detached {
|
||||
|
||||
@@ -6,12 +6,26 @@ struct MCPServerAddCustomView: View {
|
||||
let viewModel: MCPServersViewModel
|
||||
|
||||
@Environment(\.dismiss) private var dismiss
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
@State private var name: String = ""
|
||||
@State private var transport: MCPTransport = .stdio
|
||||
@State private var command: String = "npx"
|
||||
@State private var argsText: String = ""
|
||||
@State private var url: String = ""
|
||||
@State private var auth: String = "none"
|
||||
@State private var sseReadTimeout: String = ""
|
||||
|
||||
/// `.sse` is a v0.13+ surface; pre-v0.13 hosts only see stdio + http.
|
||||
/// Iterating `MCPTransport.allCases` directly would render the SSE
|
||||
/// segment unconditionally and Hermes would reject the resulting CLI
|
||||
/// invocation at argparse time.
|
||||
private var availableTransports: [MCPTransport] {
|
||||
var t: [MCPTransport] = [.stdio, .http]
|
||||
if capabilitiesStore?.capabilities.hasMCPSSETransport ?? false {
|
||||
t.append(.sse)
|
||||
}
|
||||
return t
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
VStack(spacing: 0) {
|
||||
@@ -44,17 +58,20 @@ struct MCPServerAddCustomView: View {
|
||||
}
|
||||
sectionBox(title: "Transport") {
|
||||
Picker("", selection: $transport) {
|
||||
ForEach(MCPTransport.allCases) { t in
|
||||
ForEach(availableTransports) { t in
|
||||
Text(t.displayName).tag(t)
|
||||
}
|
||||
}
|
||||
.pickerStyle(.segmented)
|
||||
.labelsHidden()
|
||||
}
|
||||
if transport == .stdio {
|
||||
switch transport {
|
||||
case .stdio:
|
||||
stdioSection
|
||||
} else {
|
||||
case .http:
|
||||
httpSection
|
||||
case .sse:
|
||||
sseSection
|
||||
}
|
||||
Text("Env vars, headers, and tool filters can be edited after the server is added.")
|
||||
.font(.caption)
|
||||
@@ -112,6 +129,28 @@ struct MCPServerAddCustomView: View {
|
||||
}
|
||||
}
|
||||
|
||||
private var sseSection: some View {
|
||||
sectionBox(title: "Endpoint (SSE)") {
|
||||
VStack(alignment: .leading, spacing: 8) {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("URL").font(.caption.bold())
|
||||
TextField("https://.../sse", text: $url)
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.font(.system(.body, design: .monospaced))
|
||||
}
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("SSE Read Timeout (seconds)").font(.caption.bold())
|
||||
TextField("default 300", text: $sseReadTimeout)
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.frame(maxWidth: 140)
|
||||
Text("Hermes-side keepalive interval. Leave blank to use the default.")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var canSubmit: Bool {
|
||||
let trimmedName = name.trimmingCharacters(in: .whitespaces)
|
||||
guard !trimmedName.isEmpty else { return false }
|
||||
@@ -120,6 +159,8 @@ struct MCPServerAddCustomView: View {
|
||||
return !command.trimmingCharacters(in: .whitespaces).isEmpty
|
||||
case .http:
|
||||
return !url.trimmingCharacters(in: .whitespaces).isEmpty
|
||||
case .sse:
|
||||
return !url.trimmingCharacters(in: .whitespaces).isEmpty
|
||||
}
|
||||
}
|
||||
|
||||
@@ -130,14 +171,25 @@ struct MCPServerAddCustomView: View {
|
||||
.map { $0.trimmingCharacters(in: .whitespaces) }
|
||||
.filter { !$0.isEmpty }
|
||||
let resolvedAuth: String? = (auth == "none") ? nil : auth
|
||||
viewModel.addCustom(
|
||||
name: trimmedName,
|
||||
transport: transport,
|
||||
command: command.trimmingCharacters(in: .whitespaces),
|
||||
args: args,
|
||||
url: url.trimmingCharacters(in: .whitespaces),
|
||||
auth: resolvedAuth
|
||||
)
|
||||
switch transport {
|
||||
case .stdio, .http:
|
||||
viewModel.addCustom(
|
||||
name: trimmedName,
|
||||
transport: transport,
|
||||
command: command.trimmingCharacters(in: .whitespaces),
|
||||
args: args,
|
||||
url: url.trimmingCharacters(in: .whitespaces),
|
||||
auth: resolvedAuth
|
||||
)
|
||||
case .sse:
|
||||
let trimmedTimeout = sseReadTimeout.trimmingCharacters(in: .whitespaces)
|
||||
let parsedTimeout: Int? = trimmedTimeout.isEmpty ? nil : Int(trimmedTimeout)
|
||||
viewModel.addCustomSSE(
|
||||
name: trimmedName,
|
||||
url: url.trimmingCharacters(in: .whitespaces),
|
||||
sseReadTimeout: parsedTimeout
|
||||
)
|
||||
}
|
||||
dismiss()
|
||||
}
|
||||
|
||||
|
||||
@@ -127,6 +127,11 @@ struct MCPServerDetailView: View {
|
||||
if let auth = server.auth, !auth.isEmpty {
|
||||
summaryRow(label: "Auth", value: auth)
|
||||
}
|
||||
case .sse:
|
||||
summaryRow(label: "URL", value: server.url ?? "—")
|
||||
if let timeout = server.sseReadTimeout {
|
||||
summaryRow(label: "Read TO", value: "\(timeout)s")
|
||||
}
|
||||
}
|
||||
}
|
||||
.padding(ScarfSpace.s3)
|
||||
|
||||
@@ -186,6 +186,16 @@ struct MCPServerEditorView: View {
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.frame(maxWidth: 140)
|
||||
}
|
||||
if viewModel.server.transport == .sse {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("SSE read timeout")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
TextField("default 300", text: $viewModel.sseReadTimeoutDraft)
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.frame(maxWidth: 140)
|
||||
}
|
||||
}
|
||||
Spacer()
|
||||
}
|
||||
}
|
||||
|
||||
@@ -132,6 +132,14 @@ struct MCPServersView: View {
|
||||
}
|
||||
}
|
||||
}
|
||||
if !viewModel.sseServers.isEmpty {
|
||||
Section("Remote (SSE)") {
|
||||
ForEach(viewModel.sseServers) { server in
|
||||
serverRow(server)
|
||||
.tag(server.name as String?)
|
||||
}
|
||||
}
|
||||
}
|
||||
if viewModel.servers.isEmpty && !viewModel.isLoading {
|
||||
Section {
|
||||
Text("No servers configured yet")
|
||||
|
||||
+140
@@ -0,0 +1,140 @@
|
||||
import Foundation
|
||||
import ScarfCore
|
||||
import os
|
||||
|
||||
/// View-model for the v0.13 Messaging Gateway behavior subsection composed
|
||||
/// into each per-platform setup view. Owns the four v0.13 controls
|
||||
/// (allowlist + three behavior toggles) so the existing per-platform VMs
|
||||
/// don't grow another set of fields.
|
||||
///
|
||||
/// Capability-gated. Pre-v0.13 hosts skip the entire subsection (the
|
||||
/// owning view returns `EmptyView` when none of the v0.13 flags is on),
|
||||
/// so this VM never has its `save()` called against a host that can't
|
||||
/// honor it.
|
||||
@Observable
|
||||
@MainActor
|
||||
final class GatewayBehaviorViewModel {
|
||||
private static let logger = Logger(subsystem: "com.scarf", category: "GatewayBehavior")
|
||||
|
||||
let platform: String
|
||||
let context: ServerContext
|
||||
let capabilities: HermesCapabilities
|
||||
/// Allowlist kind for this platform, or `nil` for platforms without
|
||||
/// an allowlist surface (Discord, Signal, etc. — `GatewayBehaviorSection`
|
||||
/// short-circuits before instantiating this VM in that case, but the
|
||||
/// field is `nil` for safety).
|
||||
let kind: GatewayAllowlistKind?
|
||||
|
||||
// Allowlist
|
||||
var items: [String] = []
|
||||
|
||||
// Behavior toggles
|
||||
var busyAckEnabled: Bool = true
|
||||
var gatewayRestartNotification: Bool = false
|
||||
var slashCommandNoticeTTLSeconds: Int = 0
|
||||
|
||||
var message: String?
|
||||
var isSaving: Bool = false
|
||||
|
||||
init(
|
||||
platform: String,
|
||||
capabilities: HermesCapabilities,
|
||||
context: ServerContext = .local
|
||||
) {
|
||||
self.platform = platform
|
||||
self.capabilities = capabilities
|
||||
self.context = context
|
||||
self.kind = GatewayAllowlistKind.kind(for: platform)
|
||||
}
|
||||
|
||||
/// Hydrate from `~/.hermes/config.yaml`. Called from the section's
|
||||
/// `.onAppear`. Empty when the platform has no `gateway:` block in
|
||||
/// the file — defaults match v0.13 server-side defaults so the form
|
||||
/// looks identical to a fresh-install host.
|
||||
func load() {
|
||||
let cfg = HermesFileService(context: context).loadConfig()
|
||||
let block = cfg.gatewayPlatforms[platform] ?? .empty
|
||||
if let kind {
|
||||
switch kind {
|
||||
case .channels: items = block.allowedChannels
|
||||
case .chats: items = block.allowedChats
|
||||
case .rooms: items = block.allowedRooms
|
||||
}
|
||||
} else {
|
||||
items = []
|
||||
}
|
||||
busyAckEnabled = block.busyAckEnabled
|
||||
gatewayRestartNotification = block.gatewayRestartNotification
|
||||
slashCommandNoticeTTLSeconds = block.slashCommandNoticeTTLSeconds
|
||||
}
|
||||
|
||||
/// Persist edits in two phases:
|
||||
///
|
||||
/// 1. **Allowlist write** via `GatewayConfigWriter.saveList` — direct
|
||||
/// YAML edit, since `hermes config set` can't write list values.
|
||||
/// Skipped when the platform has no `kind` (no allowlist surface)
|
||||
/// or the host doesn't advertise `hasGatewayAllowlists`.
|
||||
/// 2. **Scalar saves** via `PlatformSetupHelpers.saveForm` for the
|
||||
/// three v0.13 behavior toggles. Each gated on its own capability
|
||||
/// flag; the TTL field rides on the `hasGatewayBusyAckToggle ‖
|
||||
/// hasGatewayRestartNotification` proxy (see WS-5 plan §Open Questions
|
||||
/// Q5 + WS-1 Decision F).
|
||||
func save() {
|
||||
isSaving = true
|
||||
defer {
|
||||
isSaving = false
|
||||
DispatchQueue.main.asyncAfter(deadline: .now() + 3) { [weak self] in
|
||||
self?.message = nil
|
||||
}
|
||||
}
|
||||
|
||||
// Step 1: list write via direct YAML edit. Detached so the SCP
|
||||
// round-trip on remote hosts doesn't block MainActor — local
|
||||
// writes are still cheap, but the same posture works for both.
|
||||
if let kind, capabilities.hasGatewayAllowlists {
|
||||
let trimmed = items
|
||||
.map { $0.trimmingCharacters(in: .whitespaces) }
|
||||
.filter { !$0.isEmpty }
|
||||
let ok = GatewayConfigWriter.saveList(
|
||||
context: context,
|
||||
platform: platform,
|
||||
key: kind.yamlKey,
|
||||
items: trimmed
|
||||
)
|
||||
if !ok {
|
||||
Self.logger.warning("GatewayConfigWriter.saveList failed for \(self.platform, privacy: .public)")
|
||||
message = "Failed to write allowlist to config.yaml"
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
// Step 2: scalar saves via `hermes config set`.
|
||||
var configKV: [String: String] = [:]
|
||||
let prefix = "gateway.platforms.\(platform)."
|
||||
if capabilities.hasGatewayBusyAckToggle {
|
||||
configKV[prefix + "busy_ack_enabled"] =
|
||||
PlatformSetupHelpers.envBool(busyAckEnabled)
|
||||
}
|
||||
if capabilities.hasGatewayRestartNotification {
|
||||
configKV[prefix + "gateway_restart_notification"] =
|
||||
PlatformSetupHelpers.envBool(gatewayRestartNotification)
|
||||
}
|
||||
// TTL field rides on either of the v0.13 toggles being available —
|
||||
// proxy gating per WS-1 Decision F + WS-5 Q5. // TODO(WS-5-Q5)
|
||||
if capabilities.hasGatewayBusyAckToggle
|
||||
|| capabilities.hasGatewayRestartNotification {
|
||||
configKV[prefix + "slash_command_notice_ttl_seconds"] =
|
||||
String(slashCommandNoticeTTLSeconds)
|
||||
}
|
||||
|
||||
if configKV.isEmpty {
|
||||
message = "Allowlist saved — restart gateway to apply"
|
||||
return
|
||||
}
|
||||
|
||||
let result = PlatformSetupHelpers.saveForm(
|
||||
context: context, envPairs: [:], configKV: configKV
|
||||
)
|
||||
message = result
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,103 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Reusable list-of-strings editor for v0.13 cross-platform allowlists.
|
||||
/// Shape: a vertical stack of rows, each with a delete glyph; an "Add row"
|
||||
/// button at the bottom appends an empty entry.
|
||||
///
|
||||
/// Stateless — binds to the parent VM's `items` array. The VM owns
|
||||
/// persistence and change tracking; this view is pure presentation.
|
||||
struct AllowlistEditor: View {
|
||||
@Binding var items: [String]
|
||||
let kind: GatewayAllowlistKind
|
||||
|
||||
var body: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s2) {
|
||||
HStack {
|
||||
Text("Allowed \(kind.pluralNoun)")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
Spacer()
|
||||
Text(itemsCountLabel)
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
}
|
||||
|
||||
if items.isEmpty {
|
||||
Text("No restrictions — agent responds in any \(kind.noun).")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
} else {
|
||||
VStack(spacing: 4) {
|
||||
ForEach(Array(items.enumerated()), id: \.offset) { idx, _ in
|
||||
AllowlistRow(
|
||||
value: Binding(
|
||||
get: { items[safe: idx] ?? "" },
|
||||
set: { newValue in
|
||||
guard idx < items.count else { return }
|
||||
items[idx] = newValue
|
||||
}
|
||||
),
|
||||
placeholder: kind.inputPlaceholder,
|
||||
onDelete: {
|
||||
guard idx < items.count else { return }
|
||||
items.remove(at: idx)
|
||||
}
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
HStack {
|
||||
Button {
|
||||
items.append("")
|
||||
} label: {
|
||||
Label("Add \(kind.noun)", systemImage: "plus.circle")
|
||||
.font(.caption)
|
||||
}
|
||||
.buttonStyle(.borderless)
|
||||
Spacer()
|
||||
}
|
||||
}
|
||||
.padding(.horizontal, ScarfSpace.s3)
|
||||
.padding(.vertical, ScarfSpace.s2)
|
||||
}
|
||||
|
||||
private var itemsCountLabel: String {
|
||||
let nonEmpty = items.filter { !$0.trimmingCharacters(in: .whitespaces).isEmpty }.count
|
||||
if nonEmpty == 0 { return "0 \(kind.pluralNoun)" }
|
||||
if nonEmpty == 1 { return "1 \(kind.noun)" }
|
||||
return "\(nonEmpty) \(kind.pluralNoun)"
|
||||
}
|
||||
}
|
||||
|
||||
private struct AllowlistRow: View {
|
||||
@Binding var value: String
|
||||
let placeholder: String
|
||||
let onDelete: () -> Void
|
||||
|
||||
var body: some View {
|
||||
HStack(spacing: ScarfSpace.s2) {
|
||||
TextField(placeholder, text: $value)
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.font(ScarfFont.monoSmall)
|
||||
Button {
|
||||
onDelete()
|
||||
} label: {
|
||||
Image(systemName: "minus.circle.fill")
|
||||
.foregroundStyle(ScarfColor.danger)
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.help("Remove")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private extension Array {
|
||||
subscript(safe index: Int) -> Element? {
|
||||
guard index >= 0, index < count else { return nil }
|
||||
return self[index]
|
||||
}
|
||||
}
|
||||
+96
@@ -0,0 +1,96 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// v0.13 Messaging Gateway behavior subsection composed into each per-
|
||||
/// platform setup view (Slack, Mattermost, Telegram, WhatsApp, Matrix,
|
||||
/// Google Chat). Owns its own `@State` view-model so the existing per-
|
||||
/// platform VMs don't grow another set of fields.
|
||||
///
|
||||
/// **Capability gating.** Hides itself entirely on pre-v0.13 hosts
|
||||
/// (returns `EmptyView` when none of the three v0.13 flags is on). Each
|
||||
/// internal control gates on its own flag, so a host that gains, say,
|
||||
/// `hasGatewayAllowlists` but not `hasGatewayBusyAckToggle` still gets
|
||||
/// the allowlist editor with the toggles hidden.
|
||||
struct GatewayBehaviorSection: View {
|
||||
let platform: String
|
||||
let capabilities: HermesCapabilities
|
||||
let context: ServerContext
|
||||
|
||||
@State private var viewModel: GatewayBehaviorViewModel
|
||||
|
||||
init(platform: String, capabilities: HermesCapabilities, context: ServerContext) {
|
||||
self.platform = platform
|
||||
self.capabilities = capabilities
|
||||
self.context = context
|
||||
_viewModel = State(initialValue: GatewayBehaviorViewModel(
|
||||
platform: platform,
|
||||
capabilities: capabilities,
|
||||
context: context
|
||||
))
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
// Pre-v0.13 host — hide the entire subsection so the existing
|
||||
// platform forms look unchanged. Critical regression invariant
|
||||
// per WS-5 plan §"How to test" #1.
|
||||
if !capabilities.hasGatewayAllowlists
|
||||
&& !capabilities.hasGatewayBusyAckToggle
|
||||
&& !capabilities.hasGatewayRestartNotification {
|
||||
EmptyView()
|
||||
} else {
|
||||
content
|
||||
}
|
||||
}
|
||||
|
||||
private var content: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s3) {
|
||||
SettingsSection(title: "Gateway behavior (v0.13+)", icon: "dot.radiowaves.left.and.right") {
|
||||
if capabilities.hasGatewayAllowlists,
|
||||
let kind = viewModel.kind {
|
||||
AllowlistEditor(
|
||||
items: $viewModel.items,
|
||||
kind: kind
|
||||
)
|
||||
}
|
||||
if capabilities.hasGatewayBusyAckToggle {
|
||||
ToggleRow(
|
||||
label: "Send 'Agent is working…' ack",
|
||||
isOn: viewModel.busyAckEnabled
|
||||
) { viewModel.busyAckEnabled = $0 }
|
||||
}
|
||||
if capabilities.hasGatewayRestartNotification {
|
||||
ToggleRow(
|
||||
label: "Post 'Gateway restarted' notice on boot",
|
||||
isOn: viewModel.gatewayRestartNotification
|
||||
) { viewModel.gatewayRestartNotification = $0 }
|
||||
}
|
||||
// TTL field rides on either v0.13 toggle being available
|
||||
// — proxy gating per WS-1 Decision F. // TODO(WS-5-Q5)
|
||||
if capabilities.hasGatewayBusyAckToggle
|
||||
|| capabilities.hasGatewayRestartNotification {
|
||||
StepperRow(
|
||||
label: "Auto-delete slash-command notices (s)",
|
||||
value: viewModel.slashCommandNoticeTTLSeconds,
|
||||
range: 0...3600,
|
||||
step: 5
|
||||
) { viewModel.slashCommandNoticeTTLSeconds = $0 }
|
||||
}
|
||||
}
|
||||
|
||||
HStack {
|
||||
if let msg = viewModel.message {
|
||||
Label(msg, systemImage: "checkmark.circle.fill")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.green)
|
||||
}
|
||||
Spacer()
|
||||
Button("Save behavior") { viewModel.save() }
|
||||
.buttonStyle(ScarfPrimaryButton())
|
||||
.controlSize(.small)
|
||||
.disabled(viewModel.isSaving)
|
||||
}
|
||||
}
|
||||
.onAppear { viewModel.load() }
|
||||
}
|
||||
}
|
||||
@@ -4,7 +4,13 @@ import ScarfDesign
|
||||
|
||||
struct MatrixSetupView: View {
|
||||
@State private var viewModel: MatrixSetupViewModel
|
||||
init(context: ServerContext) { _viewModel = State(initialValue: MatrixSetupViewModel(context: context)) }
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
let context: ServerContext
|
||||
|
||||
init(context: ServerContext) {
|
||||
self.context = context
|
||||
_viewModel = State(initialValue: MatrixSetupViewModel(context: context))
|
||||
}
|
||||
|
||||
|
||||
var body: some View {
|
||||
@@ -45,6 +51,13 @@ struct MatrixSetupView: View {
|
||||
}
|
||||
|
||||
saveBar
|
||||
|
||||
// v0.13 Messaging Gateway behavior — self-hides on pre-v0.13.
|
||||
GatewayBehaviorSection(
|
||||
platform: "matrix",
|
||||
capabilities: capabilitiesStore?.capabilities ?? .empty,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
.onAppear { viewModel.load() }
|
||||
}
|
||||
|
||||
@@ -4,7 +4,13 @@ import ScarfDesign
|
||||
|
||||
struct MattermostSetupView: View {
|
||||
@State private var viewModel: MattermostSetupViewModel
|
||||
init(context: ServerContext) { _viewModel = State(initialValue: MattermostSetupViewModel(context: context)) }
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
let context: ServerContext
|
||||
|
||||
init(context: ServerContext) {
|
||||
self.context = context
|
||||
_viewModel = State(initialValue: MattermostSetupViewModel(context: context))
|
||||
}
|
||||
|
||||
|
||||
var body: some View {
|
||||
@@ -28,6 +34,13 @@ struct MattermostSetupView: View {
|
||||
}
|
||||
|
||||
saveBar
|
||||
|
||||
// v0.13 Messaging Gateway behavior — self-hides on pre-v0.13.
|
||||
GatewayBehaviorSection(
|
||||
platform: "mattermost",
|
||||
capabilities: capabilitiesStore?.capabilities ?? .empty,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
.onAppear { viewModel.load() }
|
||||
}
|
||||
|
||||
@@ -4,7 +4,13 @@ import ScarfDesign
|
||||
|
||||
struct SlackSetupView: View {
|
||||
@State private var viewModel: SlackSetupViewModel
|
||||
init(context: ServerContext) { _viewModel = State(initialValue: SlackSetupViewModel(context: context)) }
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
let context: ServerContext
|
||||
|
||||
init(context: ServerContext) {
|
||||
self.context = context
|
||||
_viewModel = State(initialValue: SlackSetupViewModel(context: context))
|
||||
}
|
||||
|
||||
|
||||
var body: some View {
|
||||
@@ -30,6 +36,13 @@ struct SlackSetupView: View {
|
||||
}
|
||||
|
||||
saveBar
|
||||
|
||||
// v0.13 Messaging Gateway behavior — self-hides on pre-v0.13.
|
||||
GatewayBehaviorSection(
|
||||
platform: "slack",
|
||||
capabilities: capabilitiesStore?.capabilities ?? .empty,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
.onAppear { viewModel.load() }
|
||||
}
|
||||
|
||||
@@ -4,7 +4,13 @@ import ScarfDesign
|
||||
|
||||
struct TelegramSetupView: View {
|
||||
@State private var viewModel: TelegramSetupViewModel
|
||||
init(context: ServerContext) { _viewModel = State(initialValue: TelegramSetupViewModel(context: context)) }
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
let context: ServerContext
|
||||
|
||||
init(context: ServerContext) {
|
||||
self.context = context
|
||||
_viewModel = State(initialValue: TelegramSetupViewModel(context: context))
|
||||
}
|
||||
|
||||
|
||||
var body: some View {
|
||||
@@ -29,6 +35,13 @@ struct TelegramSetupView: View {
|
||||
}
|
||||
|
||||
saveBar
|
||||
|
||||
// v0.13 Messaging Gateway behavior — self-hides on pre-v0.13.
|
||||
GatewayBehaviorSection(
|
||||
platform: "telegram",
|
||||
capabilities: capabilitiesStore?.capabilities ?? .empty,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
.onAppear { viewModel.load() }
|
||||
}
|
||||
|
||||
@@ -4,7 +4,13 @@ import ScarfDesign
|
||||
|
||||
struct WhatsAppSetupView: View {
|
||||
@State private var viewModel: WhatsAppSetupViewModel
|
||||
init(context: ServerContext) { _viewModel = State(initialValue: WhatsAppSetupViewModel(context: context)) }
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
let context: ServerContext
|
||||
|
||||
init(context: ServerContext) {
|
||||
self.context = context
|
||||
_viewModel = State(initialValue: WhatsAppSetupViewModel(context: context))
|
||||
}
|
||||
|
||||
|
||||
var body: some View {
|
||||
@@ -29,6 +35,14 @@ struct WhatsAppSetupView: View {
|
||||
}
|
||||
|
||||
saveBar
|
||||
|
||||
// v0.13 Messaging Gateway behavior — self-hides on pre-v0.13.
|
||||
GatewayBehaviorSection(
|
||||
platform: "whatsapp",
|
||||
capabilities: capabilitiesStore?.capabilities ?? .empty,
|
||||
context: context
|
||||
)
|
||||
|
||||
Divider()
|
||||
pairingSection
|
||||
}
|
||||
|
||||
@@ -5,6 +5,33 @@ import ScarfDesign
|
||||
struct PlatformsView: View {
|
||||
@State private var viewModel: PlatformsViewModel
|
||||
@Environment(HermesFileWatcher.self) private var fileWatcher
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
/// Capabilities resolved at view-eval time. Defaults to `.empty` outside
|
||||
/// the per-server `ContextBoundRoot`. Used to filter `KnownPlatforms.all`
|
||||
/// for v0.13-only entries (Google Chat) — see `visiblePlatforms` for
|
||||
/// the deliberate asymmetry: pre-v0.12 hosts still see Yuanbao + Teams
|
||||
/// unfiltered, by design.
|
||||
private var capabilities: HermesCapabilities {
|
||||
capabilitiesStore?.capabilities ?? .empty
|
||||
}
|
||||
|
||||
/// Capability-filtered platform list. Today only **Google Chat** is
|
||||
/// gated — Yuanbao and Microsoft Teams stay unfiltered to avoid
|
||||
/// changing v0.12 host UX in a v0.13 work-stream (WS-5 plan §Q4).
|
||||
/// If we later decide to gate the v0.12 platforms too, add their
|
||||
/// flags here; the `default: true` arm keeps every other platform
|
||||
/// visible.
|
||||
private var visiblePlatforms: [HermesToolPlatform] {
|
||||
KnownPlatforms.all.filter { p in
|
||||
switch p.name {
|
||||
case "google-chat", "googlechat":
|
||||
return capabilities.hasGoogleChatPlatform
|
||||
default:
|
||||
return true
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
init(context: ServerContext) {
|
||||
_viewModel = State(initialValue: PlatformsViewModel(context: context))
|
||||
@@ -40,12 +67,12 @@ struct PlatformsView: View {
|
||||
List(selection: Binding(
|
||||
get: { viewModel.selected.name },
|
||||
set: { name in
|
||||
if let p = viewModel.platforms.first(where: { $0.name == name }) {
|
||||
if let p = visiblePlatforms.first(where: { $0.name == name }) {
|
||||
viewModel.selected = p
|
||||
}
|
||||
}
|
||||
)) {
|
||||
ForEach(viewModel.platforms) { platform in
|
||||
ForEach(visiblePlatforms) { platform in
|
||||
HStack(spacing: 8) {
|
||||
Image(systemName: KnownPlatforms.icon(for: platform.name))
|
||||
.frame(width: 20)
|
||||
@@ -149,6 +176,7 @@ struct PlatformsView: View {
|
||||
case "webhook": WebhookSetupView(context: ctx)
|
||||
case "yuanbao": yuanbaoPanel
|
||||
case "microsoft-teams": microsoftTeamsPanel
|
||||
case "google-chat", "googlechat": googleChatPanel
|
||||
default:
|
||||
SettingsSection(title: LocalizedStringKey(viewModel.selected.displayName), icon: KnownPlatforms.icon(for: viewModel.selected.name)) {
|
||||
ReadOnlyRow(label: "Setup", value: "No setup form for this platform yet.")
|
||||
@@ -180,6 +208,27 @@ struct PlatformsView: View {
|
||||
}
|
||||
}
|
||||
|
||||
/// Hermes v0.13 — Google Chat is the 20th gateway platform. Like
|
||||
/// Yuanbao + Microsoft Teams, the auth dance is OAuth-style and
|
||||
/// lives outside Scarf, so the panel surfaces the setup verb rather
|
||||
/// than a per-field form. The `GatewayBehaviorSection` below it picks
|
||||
/// up the v0.13 allowlist + behavior toggles, capability-gated.
|
||||
@ViewBuilder
|
||||
private var googleChatPanel: some View {
|
||||
VStack(alignment: .leading, spacing: ScarfSpace.s3) {
|
||||
SettingsSection(title: "Google Chat", icon: KnownPlatforms.icon(for: "google-chat")) {
|
||||
ReadOnlyRow(label: "Type", value: "Generic env-driven gateway adapter (v0.13+)")
|
||||
ReadOnlyRow(label: "Setup", value: "Run `hermes setup` and select Google Chat to walk the OAuth flow.")
|
||||
ReadOnlyRow(label: "Configured", value: viewModel.hasConfigBlock(for: viewModel.selected) ? "Yes" : "No")
|
||||
}
|
||||
GatewayBehaviorSection(
|
||||
platform: "google-chat",
|
||||
capabilities: capabilities,
|
||||
context: viewModel.context
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
private var cliPanel: some View {
|
||||
SettingsSection(title: "CLI", icon: "terminal") {
|
||||
ReadOnlyRow(label: "Scope", value: "Local terminal sessions")
|
||||
|
||||
@@ -112,10 +112,17 @@ final class ProfilesViewModel {
|
||||
}
|
||||
}
|
||||
|
||||
func create(name: String, cloneConfig: Bool, cloneAll: Bool) {
|
||||
func create(name: String, cloneConfig: Bool, cloneAll: Bool, noSkills: Bool = false) {
|
||||
var args = ["profile", "create", name]
|
||||
if cloneAll { args.append("--clone-all") }
|
||||
else if cloneConfig { args.append("--clone") }
|
||||
// v0.13+: Empty-profile creation. The wire is independent of
|
||||
// --clone / --clone-all per the v0.13 release notes — the user
|
||||
// can stack `--clone --no-skills` to clone config but skip
|
||||
// skills, which is a plausible workflow. The UI still disables
|
||||
// the toggle under --clone-all (Decision H, see ProfilesView)
|
||||
// but the wire is permissive.
|
||||
if noSkills { args.append("--no-skills") }
|
||||
runAndReload(args, success: "Profile '\(name)' created")
|
||||
}
|
||||
|
||||
|
||||
@@ -11,7 +11,12 @@ struct ProfilesView: View {
|
||||
@State private var createName = ""
|
||||
@State private var createCloneConfig = true
|
||||
@State private var createCloneAll = false
|
||||
/// v0.13+ `--no-skills` toggle. Mutually exclusive with `--clone-all`
|
||||
/// at the UX layer (Decision H from the WS-7 plan): a full clone
|
||||
/// copies skills wholesale — `--no-skills` would be a contradiction.
|
||||
@State private var createNoSkills = false
|
||||
@State private var showRename = false
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
init(context: ServerContext) {
|
||||
_viewModel = State(initialValue: ProfilesViewModel(context: context))
|
||||
@@ -123,7 +128,7 @@ struct ProfilesView: View {
|
||||
}
|
||||
Spacer()
|
||||
Button {
|
||||
createName = ""; createCloneConfig = true; createCloneAll = false
|
||||
createName = ""; createCloneConfig = true; createCloneAll = false; createNoSkills = false
|
||||
showCreate = true
|
||||
} label: {
|
||||
Label("Create", systemImage: "plus")
|
||||
@@ -300,11 +305,31 @@ struct ProfilesView: View {
|
||||
Toggle("Clone config, .env, SOUL.md from active profile", isOn: $createCloneConfig)
|
||||
.disabled(createCloneAll)
|
||||
Toggle("Full copy of active profile (all state)", isOn: $createCloneAll)
|
||||
// TODO(WS-7-Q8): Decision H — disable --no-skills when --clone-all
|
||||
// is on. A full clone copies skills wholesale; --no-skills would
|
||||
// be a contradiction. Verify Hermes's behaviour with both flags
|
||||
// (argparse mutual exclusion vs. last-flag-wins vs. clone-but-
|
||||
// skip-skills) and relax the disabled state if Hermes does
|
||||
// something useful with the combination.
|
||||
if capabilitiesStore?.capabilities.hasProfileNoSkills ?? false {
|
||||
Toggle("Empty profile (no skills)", isOn: $createNoSkills)
|
||||
.disabled(createCloneAll)
|
||||
}
|
||||
HStack {
|
||||
Spacer()
|
||||
Button("Cancel") { showCreate = false }
|
||||
Button("Create") {
|
||||
viewModel.create(name: createName, cloneConfig: createCloneConfig, cloneAll: createCloneAll)
|
||||
viewModel.create(
|
||||
name: createName,
|
||||
cloneConfig: createCloneConfig,
|
||||
cloneAll: createCloneAll,
|
||||
// Defensive: if the toggle isn't visible (pre-v0.13)
|
||||
// the state is always `false`, but read it through
|
||||
// the capability gate anyway so a stale state value
|
||||
// can't sneak `--no-skills` to a CLI that doesn't
|
||||
// know it.
|
||||
noSkills: (capabilitiesStore?.capabilities.hasProfileNoSkills ?? false) ? createNoSkills : false
|
||||
)
|
||||
showCreate = false
|
||||
}
|
||||
.buttonStyle(.borderedProminent)
|
||||
|
||||
@@ -170,6 +170,16 @@ final class SettingsViewModel {
|
||||
func setBrowserAllowPrivateURLs(_ value: Bool) { setSetting("browser.allow_private_urls", value: value ? "true" : "false") }
|
||||
func setCamofoxManagedPersistence(_ value: Bool) { setSetting("browser.camofox.managed_persistence", value: value ? "true" : "false") }
|
||||
|
||||
// MARK: - Web Tools
|
||||
|
||||
/// Pre-v0.13 combined backend. Pre-v0.13 hosts read this; v0.13+
|
||||
/// hosts read it for back-compat but the WebToolsTab gates writes
|
||||
/// on `hasWebToolsBackendSplit` so the tab only writes the split
|
||||
/// keys on v0.13.
|
||||
func setWebToolsBackend(_ value: String) { setSetting("web_tools.backend", value: value) }
|
||||
func setWebToolsSearchBackend(_ value: String) { setSetting("web_tools.search.backend", value: value) }
|
||||
func setWebToolsExtractBackend(_ value: String) { setSetting("web_tools.extract.backend", value: value) }
|
||||
|
||||
// MARK: - Voice / TTS / STT
|
||||
|
||||
func setAutoTTS(_ value: Bool) { setSetting("voice.auto_tts", value: value ? "true" : "false") }
|
||||
@@ -226,6 +236,24 @@ final class SettingsViewModel {
|
||||
setSetting("auxiliary.\(task).timeout", value: String(value))
|
||||
}
|
||||
|
||||
// MARK: - Image generation (v0.13+)
|
||||
|
||||
/// `image_gen.model` — overrides the per-provider default image
|
||||
/// model (Hermes v0.13+). Empty string clears the override.
|
||||
/// Capability-gated in `AuxiliaryTab` so pre-v0.13 hosts never
|
||||
/// invoke this setter.
|
||||
func setImageGenModel(_ value: String) { setSetting("image_gen.model", value: value) }
|
||||
|
||||
/// `openrouter.response_cache.enabled` — toggles OpenRouter
|
||||
/// response caching for repeat prompts (Hermes v0.13+).
|
||||
/// Capability-gated in `AuxiliaryTab` so pre-v0.13 hosts never
|
||||
/// invoke this setter.
|
||||
// TODO(WS-6-Q1): the YAML key path is provisional — keep in lockstep
|
||||
// with `HermesConfig+YAML.swift`'s parser line.
|
||||
func setOpenRouterResponseCache(_ value: Bool) {
|
||||
setSetting("openrouter.response_cache.enabled", value: value ? "true" : "false")
|
||||
}
|
||||
|
||||
// MARK: - Security / Privacy
|
||||
|
||||
func setRedactSecrets(_ value: Bool) { setSetting("security.redact_secrets", value: value ? "true" : "false") }
|
||||
|
||||
@@ -26,6 +26,7 @@ struct SettingsView: View {
|
||||
case agent = "Agent"
|
||||
case terminal = "Terminal"
|
||||
case browser = "Browser"
|
||||
case webTools = "Web Tools"
|
||||
case voice = "Voice"
|
||||
case memory = "Memory"
|
||||
case auxiliary = "Aux Models"
|
||||
@@ -41,6 +42,7 @@ struct SettingsView: View {
|
||||
case .agent: return "Agent"
|
||||
case .terminal: return "Terminal"
|
||||
case .browser: return "Browser"
|
||||
case .webTools: return "Web Tools"
|
||||
case .voice: return "Voice"
|
||||
case .memory: return "Memory"
|
||||
case .auxiliary: return "Aux Models"
|
||||
@@ -56,6 +58,7 @@ struct SettingsView: View {
|
||||
case .agent: return "brain.head.profile"
|
||||
case .terminal: return "terminal"
|
||||
case .browser: return "globe"
|
||||
case .webTools: return "globe.americas"
|
||||
case .voice: return "mic"
|
||||
case .memory: return "memorychip"
|
||||
case .auxiliary: return "sparkles.rectangle.stack"
|
||||
@@ -171,6 +174,7 @@ struct SettingsView: View {
|
||||
case .agent: AgentTab(viewModel: viewModel)
|
||||
case .terminal: TerminalTab(viewModel: viewModel)
|
||||
case .browser: BrowserTab(viewModel: viewModel)
|
||||
case .webTools: WebToolsTab(viewModel: viewModel)
|
||||
case .voice: VoiceTab(viewModel: viewModel)
|
||||
case .memory: MemoryTab(viewModel: viewModel)
|
||||
case .auxiliary: AuxiliaryTab(viewModel: viewModel)
|
||||
|
||||
@@ -139,6 +139,23 @@ struct AuxiliaryTab: View {
|
||||
auxRows(for: task.key)
|
||||
}
|
||||
}
|
||||
// -- Hermes v0.13 additions ---------------------------------
|
||||
// Image-gen model picker. Hermes v0.13 honors `image_gen.model`
|
||||
// as a top-level YAML key; pre-v0.13 hosts ignore it silently.
|
||||
// Hide the section on pre-v0.13 hosts to spare users a
|
||||
// "I set this and nothing happened" trap.
|
||||
if capabilitiesStore?.capabilities.hasImageGenModel ?? false {
|
||||
SettingsSection(title: "Image Generation", icon: "photo") {
|
||||
imageGenRow
|
||||
}
|
||||
}
|
||||
// OpenRouter response caching toggle (v0.13+). Same hide-on-
|
||||
// pre-v0.13 rationale: the toggle no-ops on older Hermes hosts.
|
||||
if capabilitiesStore?.capabilities.hasOpenRouterResponseCache ?? false {
|
||||
SettingsSection(title: "OpenRouter", icon: "shippingbox") {
|
||||
openRouterResponseCacheRow
|
||||
}
|
||||
}
|
||||
// Unknown / unrecognised aux tasks present in config.yaml.
|
||||
// Shown only when at least one such key is present so the
|
||||
// typical user with a clean config never sees this section.
|
||||
@@ -225,6 +242,60 @@ struct AuxiliaryTab: View {
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - v0.13 surfaces
|
||||
|
||||
/// Image-gen model picker — curated allowlist + free-form custom
|
||||
/// entry. Capability-gated by the caller; this view assumes the
|
||||
/// host honors `image_gen.model` (Hermes v0.13+).
|
||||
@ViewBuilder
|
||||
private var imageGenRow: some View {
|
||||
let value = viewModel.config.imageGenModel
|
||||
Picker("Model", selection: Binding(
|
||||
get: { value },
|
||||
set: { viewModel.setImageGenModel($0) }
|
||||
)) {
|
||||
Text("Provider default").tag("")
|
||||
Divider()
|
||||
ForEach(ModelCatalogService.imageGenModels) { model in
|
||||
Text(model.display).tag(model.modelID)
|
||||
}
|
||||
// User has set a custom value not in the curated list;
|
||||
// preserve it as a tagged option so the picker renders the
|
||||
// actual selection rather than collapsing to "Provider
|
||||
// default".
|
||||
if !value.isEmpty
|
||||
&& !ModelCatalogService.imageGenModels.contains(where: { $0.modelID == value }) {
|
||||
Divider()
|
||||
Text(value + " (custom)").tag(value)
|
||||
}
|
||||
}
|
||||
.pickerStyle(.menu)
|
||||
EditableTextField(label: "Custom model ID", value: value) { newValue in
|
||||
viewModel.setImageGenModel(newValue.trimmingCharacters(in: .whitespaces))
|
||||
}
|
||||
Text("Used for image generation calls. Leave as Provider default unless your provider documents a specific model ID for image-gen.")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.tertiary)
|
||||
.padding(.horizontal, 12)
|
||||
.padding(.bottom, 4)
|
||||
}
|
||||
|
||||
/// OpenRouter response-caching toggle (Hermes v0.13+). Off by
|
||||
/// default; surfaced for users with highly repeated prompts who
|
||||
/// want OpenRouter to cache identical-prompt responses.
|
||||
@ViewBuilder
|
||||
private var openRouterResponseCacheRow: some View {
|
||||
let isOn = viewModel.config.openrouterResponseCacheEnabled
|
||||
ToggleRow(label: "Response caching", isOn: isOn) { newValue in
|
||||
viewModel.setOpenRouterResponseCache(newValue)
|
||||
}
|
||||
Text("OpenRouter caches identical prompts within a session to reduce token costs. Off by default — enable when your workload has highly repeated prompts.")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.tertiary)
|
||||
.padding(.horizontal, 12)
|
||||
.padding(.bottom, 4)
|
||||
}
|
||||
|
||||
private func auxModel(for key: String) -> AuxiliaryModel {
|
||||
switch key {
|
||||
case "vision": return viewModel.config.auxiliary.vision
|
||||
|
||||
@@ -0,0 +1,76 @@
|
||||
import SwiftUI
|
||||
import ScarfCore
|
||||
import ScarfDesign
|
||||
|
||||
/// Web Tools tab — search + extract backend pickers. Pre-v0.13 hosts
|
||||
/// see a single "Combined backend" row writing to the legacy
|
||||
/// `web_tools.backend` key. v0.13+ hosts see two rows writing to the
|
||||
/// per-capability split keys (`web_tools.search.backend` +
|
||||
/// `web_tools.extract.backend`); SearXNG appears in the search picker
|
||||
/// only because Hermes registers it as a search-only backend.
|
||||
struct WebToolsTab: View {
|
||||
@Bindable var viewModel: SettingsViewModel
|
||||
@Environment(\.hermesCapabilities) private var capabilitiesStore
|
||||
|
||||
private var split: Bool {
|
||||
capabilitiesStore?.capabilities.hasWebToolsBackendSplit ?? false
|
||||
}
|
||||
|
||||
// TODO(WS-7-Q6): Backend lists are curated inline based on the v0.13
|
||||
// release notes ("SearXNG joined search-only"). The exact dispatch
|
||||
// table lives in `~/.hermes/hermes-agent/hermes_cli/web_tools.py` —
|
||||
// verify during integration. A wrong entry just produces a
|
||||
// `hermes config set` failure on save (recoverable, not silent).
|
||||
private static let searchBackends: [String] = [
|
||||
"duckduckgo", "tavily", "brave", "exa", "you", "searxng"
|
||||
]
|
||||
private static let extractBackends: [String] = [
|
||||
"reader", "browserless", "trafilatura", "firecrawl"
|
||||
]
|
||||
/// v0.12 combined-backend list — superset of the v0.13 search list
|
||||
/// minus SearXNG (which only dispatches as search) plus the v0.13
|
||||
/// extract-only entries that pre-v0.13 hosts handled under the
|
||||
/// combined key.
|
||||
private static let combinedBackends: [String] = [
|
||||
"duckduckgo", "tavily", "brave", "exa", "you",
|
||||
"reader", "browserless", "trafilatura", "firecrawl"
|
||||
]
|
||||
|
||||
var body: some View {
|
||||
if split {
|
||||
SettingsSection(title: "Web Tools", icon: "globe.americas") {
|
||||
PickerRow(
|
||||
label: "Search backend",
|
||||
selection: viewModel.config.webToolsSearchBackend,
|
||||
options: Self.searchBackends
|
||||
) { viewModel.setWebToolsSearchBackend($0) }
|
||||
PickerRow(
|
||||
label: "Extract backend",
|
||||
selection: viewModel.config.webToolsExtractBackend,
|
||||
options: Self.extractBackends
|
||||
) { viewModel.setWebToolsExtractBackend($0) }
|
||||
}
|
||||
Text("SearXNG joined v0.13 as a search-only backend. Backend-specific tuning (host URLs, API keys) lives in the raw YAML editor for now.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundMuted)
|
||||
.padding(.horizontal, ScarfSpace.s4)
|
||||
} else {
|
||||
// TODO(WS-7-Q7): Pre-v0.13 hosts fall back to the legacy single
|
||||
// backend. v0.13 may or may not honour `web_tools.backend` as a
|
||||
// fallback when the split keys are absent — verify with Hermes
|
||||
// and consider a one-time migration prompt in a follow-up if
|
||||
// upgrading from v0.12 silently resets the user's backend.
|
||||
SettingsSection(title: "Web Tools", icon: "globe.americas") {
|
||||
PickerRow(
|
||||
label: "Backend",
|
||||
selection: viewModel.config.webToolsBackend,
|
||||
options: Self.combinedBackends
|
||||
) { viewModel.setWebToolsBackend($0) }
|
||||
}
|
||||
Text("Hermes v0.13 splits search and extract into separate backends. Update Hermes to access the per-capability picker.")
|
||||
.scarfStyle(.caption)
|
||||
.foregroundStyle(ScarfColor.foregroundFaint)
|
||||
.padding(.horizontal, ScarfSpace.s4)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -307,6 +307,16 @@ struct SkillsView: View {
|
||||
case .missing(let hint) = designMdNpxStatus {
|
||||
designMdNpxBanner(hint: hint)
|
||||
}
|
||||
// v0.13 `[[as_document]]` directive — informational
|
||||
// only. Rendered when the skill body contains the
|
||||
// marker AND the host advertises Google Chat support
|
||||
// (cheap proxy: the directive shipped in v0.13
|
||||
// alongside Google Chat — see WS-5 plan §Q5/Q6).
|
||||
if (capabilitiesStore?.capabilities.hasGoogleChatPlatform ?? false),
|
||||
skillContentMentionsAsDocument {
|
||||
asDocumentInfoRow
|
||||
}
|
||||
|
||||
// v2.5 SKILL.md frontmatter chips. Render only the
|
||||
// sections that are populated — old skills without
|
||||
// this metadata show no extra rows.
|
||||
@@ -402,6 +412,39 @@ struct SkillsView: View {
|
||||
}
|
||||
}
|
||||
|
||||
/// Returns true when the loaded skill body contains the v0.13
|
||||
/// `[[as_document]]` directive. Substring scan over `skillContent`
|
||||
/// — `[[as_document]]` is a literal token Hermes pattern-matches at
|
||||
/// runtime, not a frontmatter key, so the body is the right place
|
||||
/// to look. // TODO(WS-5-Q6): if Hermes ever moves the directive
|
||||
/// into frontmatter, switch to `SkillFrontmatterParser` instead.
|
||||
private var skillContentMentionsAsDocument: Bool {
|
||||
viewModel.skillContent.contains("[[as_document]]")
|
||||
}
|
||||
|
||||
/// Compact informational row about the `[[as_document]]` directive.
|
||||
/// Does not block any action — it's a label so users understand why
|
||||
/// images in the skill might land as document attachments on certain
|
||||
/// platforms (Google Chat, Microsoft Teams) rather than inline.
|
||||
private var asDocumentInfoRow: some View {
|
||||
HStack(alignment: .top, spacing: 8) {
|
||||
Image(systemName: "doc.badge.gearshape")
|
||||
.foregroundStyle(.blue)
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
Text("Document-attachment directive present (v0.13+)")
|
||||
.font(.caption.bold())
|
||||
Text("Media in this skill marked with `[[as_document]]` is sent as document attachments instead of inline images on platforms that distinguish (Google Chat, Microsoft Teams).")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
}
|
||||
.padding(10)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.background(.blue.opacity(0.08))
|
||||
.clipShape(RoundedRectangle(cornerRadius: 8))
|
||||
}
|
||||
|
||||
/// Yellow banner surfaced on the design-md skill detail when the
|
||||
/// host's `npx` probe came back missing. Reuses the same color
|
||||
/// language as the missing-config banner.
|
||||
|
||||
Reference in New Issue
Block a user