gooneyryan/scarf
1
0
Fork 0
mirror of https://github.com/awizemann/scarf.git synced 2026-05-10 02:26:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(chat): detach NSOpenPanel image read off MainActor

Browse Source 
`presentImagePicker()` ran `Data(contentsOf: url)` synchronously on
MainActor inside the URL loop before the detached `encode()`. A 24 MP
HEIC at 8-15 MB stalled the chat composer per file. The drag/drop and
paste paths already read off-main via `loadObject`/`loadDataRepresentation`
callbacks; this brings the open-panel branch in line by capturing the
URLs into a `Task.detached` and reading bytes there.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Alan Wizemann
2026-05-01 13:20:50 +02:00
parent 3d85b91392
commit 11bb2bd0c3
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scarf/scarf/Features/Chat/Views/RichChatInputBar.swift
+8 -6
View File
@@ -486,12 +486,14 @@ struct RichChatInputBar: View {
panel.prompt = "Attach" panel.prompt = "Attach"
let response = panel.runModal() let response = panel.runModal()
guard response == .OK else { return } guard response == .OK else { return }
let urls = panel.urls let urls = Array(panel.urls.prefix(Self.maxAttachments - attachments.count))
let remainingSlots = Self.maxAttachments - attachments.count guard !urls.isEmpty else { return }
for url in urls.prefix(remainingSlots) { isEncodingAttachment = true
guard let data = try? Data(contentsOf: url) else { continue } Task.detached(priority: .userInitiated) {
isEncodingAttachment = true for url in urls {
encode(data: data, filename: url.lastPathComponent) guard let data = try? Data(contentsOf: url) else { continue }
encode(data: data, filename: url.lastPathComponent)
}
} }
#endif #endif
} }